Skip to content

Commit 4168cf8

Browse files
fix: Custom resources details wrong opening (#3629)
* Using Suspense to gently open the columns * Removing unnecessary scroll under list item
1 parent b32cf54 commit 4168cf8

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

src/components/CustomResources/GroupingListPage.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
ui5-table-cell[slot='default-2'] {
77
width: 22vw;
88
}
9+
10+
ui5-panel {
11+
&::part(content) {
12+
overflow: unset;
13+
}
14+
}
915
}
1016

1117
@media (max-width: 850px) {

src/resources/other/CustomResourcesByGroup.routes.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,21 @@ export const ColumnWrapper = ({ defaultColumn = 'list' }) => {
199199
<FlexibleColumnLayout
200200
style={{ height: '100%' }}
201201
layout={layoutState?.layout || 'OneColumn'}
202-
startColumn={<div className="column-content">{startColumnComponent}</div>}
203-
midColumn={<div className="column-content">{midColumnComponent}</div>}
204-
endColumn={<div className="column-content">{endColumnComponent}</div>}
202+
startColumn={
203+
<div className="column-content">
204+
<Suspense fallback={<Spinner />}>{startColumnComponent}</Suspense>
205+
</div>
206+
}
207+
midColumn={
208+
<div className="column-content">
209+
<Suspense fallback={<Spinner />}>{midColumnComponent}</Suspense>
210+
</div>
211+
}
212+
endColumn={
213+
<div className="column-content">
214+
<Suspense fallback={<Spinner />}>{endColumnComponent}</Suspense>
215+
</div>
216+
}
205217
/>
206218
);
207219
};

0 commit comments

Comments
 (0)