chore: Turn on prefer-const eslint rule (#4421)

Author: awoloszyn22

eslint.config.ts

@@ -74,7 +74,7 @@ export default defineConfig(
         'no-irregular-whitespace': 'warn',
         'no-prototype-builtins': 'warn',
         'no-unsafe-optional-chaining': 'warn',
-        'prefer-const': 'warn',
+        'prefer-const': 'error',
       },
     },
   ],

src/components/App/ClusterRoutes.jsx

@@ -27,7 +27,7 @@ import { useUrl } from 'hooks/useUrl';
 import { sidebarNavigationNodesAtom } from 'state/navigation/sidebarNavigationNodesAtom';
 
 export default function ClusterRoutes() {
-  let { currentClusterName } = useParams() || {};
+  const { currentClusterName } = useParams() || {};
 
   const navigate = useNavigate();
   const { t } = useTranslation();

src/components/App/resourceSchemas/resourceSchemaWorkerApi.js

@@ -10,7 +10,7 @@ if (typeof Worker !== 'undefined') {
   );
 }
 
-export let isWorkerAvailable = !!schemasWorker;
+export const isWorkerAvailable = !!schemasWorker;
 export const terminateWorker = () => {
   schemasWorker?.terminate();
 };

src/components/App/resourceSchemas/resourceSchemas.worker.js

@@ -13,14 +13,14 @@ const CUSTOM_FORMATS = {
 function getExistingCustomFormats(obj, path = '') {
   let existingData = [];
 
-  for (let i in obj) {
+  for (const i in obj) {
     if (!obj.hasOwnProperty(i)) continue;
     if (typeof obj[i] === 'object') {
       existingData = existingData.concat(
         getExistingCustomFormats(obj[i], path ? `${path}.${i}` : i),
       );
     } else if (i === CUSTOM_KEY) {
-      for (let formatKey of Object.keys(CUSTOM_FORMATS)) {
+      for (const formatKey of Object.keys(CUSTOM_FORMATS)) {
         if (formatKey === obj[i]) {
           existingData.push({ path, formatKey });
           break;
@@ -32,7 +32,7 @@ function getExistingCustomFormats(obj, path = '') {
 }
 
 function replaceObjects(existingCustomFormats, schema) {
-  for (let i in existingCustomFormats) {
+  for (const i in existingCustomFormats) {
     let object = {
       ...jp.value(schema, `$.${existingCustomFormats[i].path}`),
     };

src/components/Clusters/views/ClusterOverview/ClusterStats.jsx

@@ -27,8 +27,8 @@ const Injections = React.lazy(
 export default function ClusterStats({ nodesData }) {
   const { t } = useTranslation();
 
-  let cpu = { usage: 0, capacity: 0 };
-  let memory = { usage: 0, capacity: 0 };
+  const cpu = { usage: 0, capacity: 0 };
+  const memory = { usage: 0, capacity: 0 };
 
   if (nodesData) {
     for (const node of nodesData) {

src/components/Extensibility/ExtensibilityDetails.jsx

@@ -39,7 +39,8 @@ export const ExtensibilityDetailsCore = ({
     features,
     description: resourceDescription,
   } = resMetaData?.general ?? {};
-  let { disableEdit, disableDelete } = features?.actions || {};
+  let { disableDelete } = features?.actions || {};
+  const { disableEdit } = features?.actions || {};
   if (isModule) disableDelete = true;
 
   const { schema } = useGetSchema({

src/components/Extensibility/ExtensibilityInjections.jsx

@@ -22,7 +22,7 @@ export function ExtensibilityInjectionCore({ resMetaData, root }) {
     resource: isStatic ? staticResource : resource,
   });
 
-  let resourceUrl = usePrepareResourceUrl({
+  const resourceUrl = usePrepareResourceUrl({
     apiGroup: resource?.group,
     apiVersion: resource?.version,
     resourceType: pluralize(resource?.kind || '').toLowerCase(),

src/components/Extensibility/components-form/Modules/Modules.jsx

@@ -70,14 +70,14 @@ export function Modules({ storeKeys, resource, onChange, schema, required }) {
       console.warn('Widget::Modules');
       return null;
     }
-    let parsedOpt = {};
+    const parsedOpt = {};
     Promise.all(
       Object.keys(options).map(async (optionName) => {
         if (
           optionName === 'name' &&
           !Array.isArray(await makeJsonata(options[optionName]))
         ) {
-          let moduleName = await makeJsonata(options[optionName]);
+          const moduleName = await makeJsonata(options[optionName]);
           parsedOpt[optionName] = [moduleName];
         } else {
           parsedOpt[optionName] = await makeJsonata(options[optionName]);
@@ -103,7 +103,7 @@ export function Modules({ storeKeys, resource, onChange, schema, required }) {
       return v.name === name;
     });
 
-    let channelModuleTemplate = [];
+    const channelModuleTemplate = [];
 
     parsedOptions?.moduleTemplates?.map((moduleTemplate) => {
       if (

src/components/Extensibility/contexts/DataSources.tsx

@@ -111,10 +111,13 @@ export const DataSourcesContextProvider: FC<Props> = ({
     dataSource: DataSource,
     resource: Resource = {} as Resource,
   ) => {
-    let {
-      resource: { group, kind, version, name, namespace },
+    const {
+      resource: { group, kind, version, name },
       ownerLabelSelectorPath,
     } = dataSource;
+    let {
+      resource: { namespace },
+    } = dataSource;
     if (typeof namespace === 'undefined') {
       namespace = resource?.metadata?.namespace || fallbackNamespace;
     }

src/components/Extensibility/helpers/index.js

@@ -176,7 +176,7 @@ export const getResourceDescAndUrl = (descID) => {
     };
 
   const helmBracketsRegex = /{{"(.*?)"}}/g;
-  let trans = descID.replace(helmBracketsRegex, '$1');
+  const trans = descID.replace(helmBracketsRegex, '$1');
 
   if (typeof trans === 'string') {
     const links = extractLinks(trans);