Skip to content

Commit 4c2c913

Browse files
authored
chore: migrate preferencesmodalopen state to jotai (#4115)
1 parent c080e0f commit 4c2c913

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

src/command-pallette/CommandPalletteUI/useSearchResults.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useEffect } from 'react';
22
import { useTranslation } from 'react-i18next';
3-
import { useRecoilValue, useSetRecoilState } from 'recoil';
3+
import { useRecoilValue } from 'recoil';
44
import { useSetAtom } from 'jotai';
55
import { isPreferencesOpenState } from 'state/preferences/isPreferencesModalOpenAtom';
66
import { useFetch } from 'shared/hooks/BackendAPI/useFetch';
@@ -49,7 +49,7 @@ export function useSearchResults({
4949
const showHiddenNamespaces = useRecoilValue(showHiddenNamespacesState);
5050
const fetch = useFetch();
5151
const { t } = useTranslation();
52-
const setOpenPreferencesModal = useSetRecoilState(isPreferencesOpenState);
52+
const setOpenPreferencesModal = useSetAtom(isPreferencesOpenState);
5353
const setShowYamlUpload = useSetAtom(showYamlUploadDialogState);
5454
const clustersInfo = useClustersInfo();
5555
const navigate = useNavigate();

src/components/Preferences/Preferences.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Button, Icon, Dialog, Bar } from '@ui5/webcomponents-react';
22
import { useTranslation } from 'react-i18next';
3-
import { useRecoilState } from 'recoil';
3+
import { useAtom } from 'jotai';
44

55
import { useEventListener } from 'hooks/useEventListener';
66
import { TabContainer, Tab } from '@ui5/webcomponents-react';
@@ -21,7 +21,7 @@ import EditViewSettings from './EditViewSettings';
2121

2222
export function Preferences() {
2323
const { t } = useTranslation();
24-
const [isModalOpen, setModalOpen] = useRecoilState(isPreferencesOpenState);
24+
const [isModalOpen, setModalOpen] = useAtom(isPreferencesOpenState);
2525

2626
const tabs = [
2727
{

src/header/HeaderMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Menu, MenuItem } from '@ui5/webcomponents-react';
22
import { MenuDomRef, Ui5CustomEvent } from '@ui5/webcomponents-react';
33
import { MenuItemClickEventDetail } from '@ui5/webcomponents/dist/Menu.js';
4-
import { useSetRecoilState } from 'recoil';
4+
import { useSetAtom } from 'jotai';
55
import { isPreferencesOpenState } from 'state/preferences/isPreferencesModalOpenAtom';
66
import { useGetBusolaVersionDetails } from './SidebarMenu/useGetBusolaVersion';
77
import { useGetLegalLinks } from './SidebarMenu/useGetLegalLinks';
@@ -25,7 +25,7 @@ interface HeaderMenuProps {
2525

2626
export function HeaderMenu({ isMenuOpen, setIsMenuOpen }: HeaderMenuProps) {
2727
const { t } = useTranslation();
28-
const setPreferencesOpen = useSetRecoilState(isPreferencesOpenState);
28+
const setPreferencesOpen = useSetAtom(isPreferencesOpenState);
2929
const { githubLink, busolaVersion } = useGetBusolaVersionDetails();
3030
const legalLinks = useGetLegalLinks();
3131
const getHelpLinks = useGetHelpLinks();
Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
1-
import { atom, RecoilState } from 'recoil';
2-
3-
type IsPreferencesOpen = boolean;
1+
import { atom } from 'jotai';
42

53
const DEFAULT_IS_PREFERENCES_MODAL_OPEN = false;
64

7-
export const isPreferencesOpenState: RecoilState<IsPreferencesOpen> = atom<
8-
IsPreferencesOpen
9-
>({
10-
key: 'isPreferencesModalOpenedState',
11-
default: DEFAULT_IS_PREFERENCES_MODAL_OPEN,
12-
});
5+
export const isPreferencesOpenState = atom<boolean>(
6+
DEFAULT_IS_PREFERENCES_MODAL_OPEN,
7+
);
8+
isPreferencesOpenState.debugLabel = 'isPreferencesModalOpenedState';

0 commit comments

Comments
 (0)