PR corrections

Author: KonradPietocha

src/components/Extensibility/components-form/SimpleList.tsx

@@ -77,8 +77,6 @@ export function SimpleList({
   return (
     <ResourceForm.CollapsibleSection
       defaultOpen={defaultOpen}
-      /*@ts-expect-error Some type mismatch or probably no longer used*/
-      container
       title={tFromStoreKeys(storeKeys, schema)}
       required={required}
       nestingLevel={nestingLevel}

src/components/Extensibility/contexts/Trigger.tsx

@@ -1,6 +1,6 @@
 import { StoreKeys } from '@ui-schema/ui-schema';
 import { fromJS } from 'immutable';
-import { createContext, useState, useRef } from 'react';
+import { createContext, useState, useRef, ReactNode } from 'react';
 
 export function scopePaths(storeKeys: StoreKeys) {
   const indexes = fromJS(storeKeys)
@@ -50,11 +50,7 @@ export const TriggerContext = createContext({
   subs: [] as any,
 });
 
-export function TriggerContextProvider({
-  children,
-}: {
-  children: React.ReactNode;
-}) {
+export function TriggerContextProvider({ children }: { children: ReactNode }) {
   const subs = useRef<Record<string, any>[]>([]);
   const [enabled, setEnabled] = useState(true);
 

src/components/Extensibility/contexts/VarStore.tsx

@@ -1,4 +1,4 @@
-import { createContext, SetStateAction, useState } from 'react';
+import { createContext, ReactNode, SetStateAction, useState } from 'react';
 import jp from 'jsonpath';
 
 export const VarStoreContext = createContext({
@@ -7,11 +7,7 @@ export const VarStoreContext = createContext({
   setVars: (() => {}) as (value: SetStateAction<Record<string, any>>) => void,
 });
 
-export function VarStoreContextProvider({
-  children,
-}: {
-  children: React.ReactNode;
-}) {
+export function VarStoreContextProvider({ children }: { children: ReactNode }) {
   const [vars, setVars] = useState({});
 
   const setVar = (path: string, value: any) => {

src/shared/components/ResourceDetails/ResourceActions.tsx

@@ -1,4 +1,4 @@
-import { lazy, Suspense } from 'react';
+import { lazy, ReactNode, Suspense } from 'react';
 import { Spinner } from '../Spinner/Spinner';
 import { ToolbarButton } from '@ui5/webcomponents-react';
 import { createPortal } from 'react-dom';
@@ -13,10 +13,10 @@ const Injections = lazy(
 );
 
 type ResourceActionsProps = {
-  headerActions?: React.ReactNode;
+  headerActions?: ReactNode;
   readOnly?: boolean;
   resource: K8sResource & Resource;
-  resourceHeaderActions: Array<(resource: any) => React.ReactNode>;
+  resourceHeaderActions: Array<(resource: any) => ReactNode>;
   resourceType: string;
   resourceUrl?: string;
   disableDelete?: boolean;
@@ -33,7 +33,7 @@ type ResourceActionsProps = {
   showDeleteDialog: boolean;
   performDelete: (
     resource: any,
-    resourceUrl: any,
+    resourceUrl: string,
     deleteFn: any,
   ) => Promise<void>;
   performCancel: (cancelFn: any) => void;

src/shared/components/ResourceDetails/ResourceComponent.tsx

@@ -25,6 +25,7 @@ import { Resource } from 'components/Extensibility/contexts/DataSources';
 import { ResourceActions } from './ResourceActions';
 import { ResourceDetailsCardContent } from './ResourceDetailsCardContent';
 import { ResourceStatusCardContent } from './ResourceStatusCardContent';
+import './ResourceDetailsCard.scss';
 
 // This component is loaded after the page mounts.
 // Don't try to load it on scroll. It was tested.

src/shared/components/ResourceDetails/ResourceDetails.tsx

@@ -1,4 +1,10 @@
-import { createContext, useEffect, useState } from 'react';
+import {
+  ComponentType,
+  createContext,
+  ReactNode,
+  useEffect,
+  useState,
+} from 'react';
 import { ResourceNotFound } from 'shared/components/ResourceNotFound/ResourceNotFound';
 import { useGet } from 'shared/hooks/BackendAPI/useGet';
 import { getErrorMessage, prettifyNameSingular } from 'shared/utils/helpers';
@@ -14,18 +20,16 @@ export const ResourceDetailContext = createContext(false);
 
 export type ResourceDetailsProps = {
   customColumns?: CustomColumnsType;
-  children?: React.ReactNode;
-  customComponents?: Array<
-    (resource: any, resourceUrl: string) => React.ReactNode
-  >;
+  children?: ReactNode;
+  customComponents?: Array<(resource: any, resourceUrl: string) => ReactNode>;
   description?: string;
   resourceUrl?: string;
   resourceType: string;
   resourceName?: string;
   resourceTitle?: string;
   namespace?: string;
-  headerActions?: React.ReactNode;
-  resourceHeaderActions?: Array<(resource: any) => React.ReactNode>;
+  headerActions?: ReactNode;
+  resourceHeaderActions?: Array<(resource: any) => ReactNode>;
   readOnly?: boolean;
   editActionLabel?: string;
   windowTitle?: string;
@@ -36,7 +40,7 @@ export type ResourceDetailsProps = {
   showYamlTab?: boolean;
   layoutCloseCreateUrl?: string;
   layoutNumber?: string;
-  customHealthCards?: Array<(resource: any, index: number) => React.ReactNode>;
+  customHealthCards?: Array<(resource: any, index: number) => ReactNode>;
   showHealthCardsTitle?: boolean;
   isModule?: boolean;
   isEntireListProtected?: boolean;
@@ -45,7 +49,7 @@ export type ResourceDetailsProps = {
   hideLabels?: boolean;
   hideAnnotations?: boolean;
   hideLastUpdate?: boolean;
-  createResourceForm: React.ComponentType<{
+  createResourceForm: ComponentType<{
     resource: any;
     resourceType: string;
     resourceUrl: string;
@@ -57,16 +61,16 @@ export type ResourceDetailsProps = {
   }>;
   customConditionsComponents?: CustomColumnsType;
   title?: string;
-  statusBadge?: (resource: any) => React.ReactNode;
+  statusBadge?: (resource: any) => ReactNode;
   customStatusColumns?: CustomColumnsType;
-  customStatus?: React.ReactNode;
+  customStatus?: ReactNode;
   statusConditions?: (resource: any) => Array<{
     type: string;
     status: string;
     reason?: string;
     message?: string;
   }>;
-  headerContent?: React.ReactNode;
+  headerContent?: ReactNode;
   className?: string;
   headerDescription?: string;
 };