Skip to content

Commit 9e5f3f2

Browse files
committed
get rid of useGet in Add Modules and add skips
1 parent b39e2e4 commit 9e5f3f2

File tree

3 files changed

+15
-16
lines changed

3 files changed

+15
-16
lines changed

src/components/KymaModules/KymaModulesAddModule.js

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,16 @@ import { useCallback, useEffect, useState } from 'react';
22
import { MessageStrip } from '@ui5/webcomponents-react';
33
import { spacing } from '@ui5/webcomponents-react-base';
44
import { useTranslation } from 'react-i18next';
5-
import { useGet } from 'shared/hooks/BackendAPI/useGet';
65
import { ResourceForm } from 'shared/ResourceForm';
76
import { Spinner } from 'shared/components/Spinner/Spinner';
87
import ModulesCard from './ModulesCard';
9-
import './KymaModulesAddModule.scss';
108
import { cloneDeep } from 'lodash';
9+
import {
10+
useModulesReleaseQuery,
11+
useModuleTemplatesQuery,
12+
} from './kymaModulesQueries';
13+
14+
import './KymaModulesAddModule.scss';
1115

1216
export default function KymaModulesAddModule({
1317
resourceName,
@@ -21,10 +25,6 @@ export default function KymaModulesAddModule({
2125
}) {
2226
const { t } = useTranslation();
2327

24-
const modulesResourceUrl = `/apis/operator.kyma-project.io/v1beta2/moduletemplates`;
25-
26-
const modulesReleaseMetaResourceUrl = `/apis/operator.kyma-project.io/v1beta2/modulereleasemetas`;
27-
2828
const [resource, setResource] = useState(cloneDeep(kymaResource));
2929

3030
const [selectedModules, setSelectedModules] = useState([]);
@@ -48,13 +48,10 @@ export default function KymaModulesAddModule({
4848
}
4949
}, [setKymaResource, kymaResource, selectedModules, activeKymaModules]);
5050

51-
const { data: modules } = useGet(modulesResourceUrl, {
52-
pollingInterval: 3000,
51+
const { data: moduleReleaseMetas } = useModulesReleaseQuery({
5352
skip: !resourceName,
5453
});
55-
56-
const { data: moduleReleaseMetas } = useGet(modulesReleaseMetaResourceUrl, {
57-
pollingInterval: 3000,
54+
const { data: moduleTemplates } = useModuleTemplatesQuery({
5855
skip: !resourceName,
5956
});
6057

@@ -99,7 +96,7 @@ export default function KymaModulesAddModule({
9996
);
10097
}
10198

102-
const modulesAddData = modules?.items.reduce((acc, module) => {
99+
const modulesAddData = moduleTemplates?.items.reduce((acc, module) => {
103100
const name = module.metadata.labels['operator.kyma-project.io/module-name'];
104101
const existingModule = acc.find(item => item.name === name);
105102
const isAlreadyInstalled = initialUnchangedResource?.spec?.modules?.find(

src/components/KymaModules/KymaModulesList.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,13 @@ export default function KymaModulesList({
8686

8787
const namespace = 'kyma-system';
8888

89-
const { data: moduleReleaseMetas } = useModulesReleaseQuery(!resourceName);
89+
const { data: moduleReleaseMetas } = useModulesReleaseQuery({
90+
skip: !resourceName,
91+
});
9092
const {
9193
data: moduleTemplates,
9294
loading: moduleTemplateLoading,
93-
} = useModuleTemplatesQuery(!resourceName);
95+
} = useModuleTemplatesQuery({ skip: !resourceName });
9496

9597
const crdUrl = `/apis/apiextensions.k8s.io/v1/customresourcedefinitions`;
9698
const { data: crds } = useGet(crdUrl, {

src/components/KymaModules/kymaModulesQueries.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export function useKymaQuery() {
3939
};
4040
}
4141

42-
export function useModuleTemplatesQuery(skip = false) {
42+
export function useModuleTemplatesQuery({ skip = false }) {
4343
const modulesResourceUrl = `/apis/operator.kyma-project.io/v1beta2/moduletemplates`;
4444

4545
const { data, loading } = useGet(modulesResourceUrl, {
@@ -52,7 +52,7 @@ export function useModuleTemplatesQuery(skip = false) {
5252
};
5353
}
5454

55-
export function useModulesReleaseQuery(skip = false) {
55+
export function useModulesReleaseQuery({ skip = false }) {
5656
const modulesReleaseMetaResourceUrl = `/apis/operator.kyma-project.io/v1beta2/modulereleasemetas`;
5757

5858
const { data, loading } = useGet(modulesReleaseMetaResourceUrl, {

0 commit comments

Comments
 (0)