Skip to content

Commit b66f5e4

Browse files
committed
feat: Add additional info on Module delete modal
1 parent 7e8a999 commit b66f5e4

File tree

3 files changed

+49
-40
lines changed

3 files changed

+49
-40
lines changed

public/i18n/en.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -766,6 +766,7 @@ kyma-companion:
766766
chat: Chat
767767
page-insights: Page Insights
768768
kyma-modules:
769+
delete-module: Before you delete the {{name}} module, make sure the module resources are no longer needed. This action also permanently removes the namespaces, service instances, and service bindings created by the module. Are you sure you want to continue?
769770
associated-resources: Associated Resources
770771
unmanaged-modules-info: One of the modules is not managed and may not work properly. We cannot guarantee any service level agreement (SLA) or provide updates and maintenance for the module.
771772
unmanaged-modules-save-warning: Before proceeding, be aware that disabling module management may impact the stability and data integrity of your cluster. Once the management is disabled, reverting back may not be possible. Are you sure you want to continue?

src/components/KymaModules/KymaModulesList.js

Lines changed: 47 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -469,46 +469,53 @@ export default function KymaModulesList({
469469
<DeleteMessageBox
470470
disableDeleteButton={checkIfAssociatedResourceLeft()}
471471
additionalDeleteInfo={
472-
getAssociatedResources().length > 0 && (
473-
<>
474-
<MessageStrip design="Critical" hideCloseButton>
475-
{t('kyma-modules.associated-resources-warning')}
476-
</MessageStrip>
477-
<List
478-
headerText={t('kyma-modules.associated-resources')}
479-
mode="None"
480-
separators="All"
481-
>
482-
{getAssociatedResources().map(assResource => {
483-
const resourceCount =
484-
resourceCounts[
485-
`${assResource.kind}-${assResource.group}-${assResource.version}`
486-
];
487-
488-
return (
489-
<ListItemStandard
490-
onClick={e => {
491-
e.preventDefault();
492-
handleItemClick(
493-
assResource.kind,
494-
assResource.group,
495-
assResource.version,
496-
);
497-
}}
498-
type="Active"
499-
key={`${assResource.kind}-${assResource.group}-${assResource.version}`}
500-
additionalText={
501-
(resourceCount === 0 ? '0' : resourceCount) ||
502-
t('common.headers.loading')
503-
}
504-
>
505-
{pluralize(assResource?.kind)}
506-
</ListItemStandard>
507-
);
508-
})}
509-
</List>
510-
</>
511-
)
472+
<>
473+
<Text>
474+
{t('kyma-modules.delete-module', {
475+
name: selectedModules[chosenModuleIndex]?.name,
476+
})}
477+
</Text>
478+
{getAssociatedResources().length > 0 && (
479+
<>
480+
<MessageStrip design="Critical" hideCloseButton>
481+
{t('kyma-modules.associated-resources-warning')}
482+
</MessageStrip>
483+
<List
484+
headerText={t('kyma-modules.associated-resources')}
485+
mode="None"
486+
separators="All"
487+
>
488+
{getAssociatedResources().map(assResource => {
489+
const resourceCount =
490+
resourceCounts[
491+
`${assResource.kind}-${assResource.group}-${assResource.version}`
492+
];
493+
494+
return (
495+
<ListItemStandard
496+
onClick={e => {
497+
e.preventDefault();
498+
handleItemClick(
499+
assResource.kind,
500+
assResource.group,
501+
assResource.version,
502+
);
503+
}}
504+
type="Active"
505+
key={`${assResource.kind}-${assResource.group}-${assResource.version}`}
506+
additionalText={
507+
(resourceCount === 0 ? '0' : resourceCount) ||
508+
t('common.headers.loading')
509+
}
510+
>
511+
{pluralize(assResource?.kind)}
512+
</ListItemStandard>
513+
);
514+
})}
515+
</List>
516+
</>
517+
)}
518+
</>
512519
}
513520
resourceTitle={selectedModules[chosenModuleIndex]?.name}
514521
deleteFn={() => {

src/shared/hooks/useDeleteResource.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ export function useDeleteResource({
178178
}) => {
179179
return (
180180
<MessageBox
181+
style={{ maxWidth: '700px' }}
181182
type="Warning"
182183
titleText={t(
183184
resourceIsCluster

0 commit comments

Comments
 (0)