fix: External links and links to telemetry broken (#4293)

* jsonata added to dependecy array. Makehref corrected

* Correction because of too many rerenders

Author: KonradPietocha

src/components/Extensibility/components/ExternalLink.jsx

@@ -10,7 +10,8 @@ import { Button, Icon, Link } from '@ui5/webcomponents-react';
 import { isNil } from 'lodash';
 
 const makeHref = ({ linkObject, value }) => {
-  if (linkObject?.linkError) return linkObject?.linkError?.message;
+  const [link, linkError] = linkObject;
+  if (linkError) return linkError;
 
   let href;
   if (typeof value === 'string') {
@@ -19,8 +20,7 @@ const makeHref = ({ linkObject, value }) => {
         ? value
         : `https://${value}`;
   }
-
-  return linkObject?.link || href;
+  return link || href;
 };
 
 export const ExternalLink = ({

src/sidebar/NavItem.tsx

@@ -52,7 +52,7 @@ export function NavItem({ node, subItem = false }: NavItemProps) {
       setJsonataError(error);
     });
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [node.externalUrl, emptyResource]);
+  }, [node.externalUrl, emptyResource, jsonata]);
 
   const isSelected = useMemo(() => {
     if (node.externalUrl) return false;