Skip to content

Commit bd46223

Browse files
committed
Merge branch 'main' of github.com:kyma-project/busola into fix-acc-column-layout
2 parents b320bb4 + e2d9f8a commit bd46223

File tree

5 files changed

+18
-7
lines changed

5 files changed

+18
-7
lines changed

.github/pull-request-template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Changes proposed in this pull request:
2727
- docs: Documentation only changes
2828
- refactor: A code change that neither fixes a bug nor adds a feature
2929
- test: Adding tests
30+
- revert: Revert commit
3031
- chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
3132
- [ ] Related issues are linked. To link internal trackers, use the issue IDs like `backlog#4567`
3233
- [ ] Explain clearly why you created the PR and what changes it introduces

.github/workflows/pr-title-check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: PR Title Check
22

3-
on:
3+
on:
44
pull_request:
55
types: [opened, edited, synchronize, reopened, ready_for_review]
66

@@ -19,5 +19,6 @@ jobs:
1919
refactor
2020
test
2121
chore
22+
revert
2223
requireScope: false
2324
subjectPattern: ^([A-Z].*[^.]|bump .*)$

src/components/CustomResources/CustomResources.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export function CustomResources({
1919
}) {
2020
const { group, names } = crd.spec;
2121
const name = names.plural;
22-
const customUrl = useCustomResourceUrl(crd);
22+
const customUrl = useCustomResourceUrl(crd, true);
2323
const { namespace } = useUrl();
2424
const resourceUrl =
2525
namespace && namespace !== '-all-'

src/resources/CustomResourceDefinitions/CRCreate.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,16 @@ function CRCreate({
2828
const [initialResource] = useState(
2929
initialCustomResource || createTemplate(crd),
3030
);
31-
const customUrl = useCustomResourceUrl(crd);
31+
const currUrl = window.location.href;
32+
33+
const customUrl = useCustomResourceUrl(
34+
crd,
35+
currUrl.includes('customresources/'),
36+
);
3237

3338
const navigate = useNavigate();
3439
const { nextQuery, currentQuery } = usePrepareLayout(layoutNumber);
35-
const goToLayoutQuery = customUrl(cr)?.includes('customresources/')
40+
const goToLayoutQuery = customUrl(cr).includes('customresources/')
3641
? nextQuery
3742
: currentQuery;
3843

src/resources/CustomResourceDefinitions/useCustomResourceUrl.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { useRecoilValue } from 'recoil';
33
import { allNodesSelector } from 'state/navigation/allNodesSelector';
44
import { useUrl } from 'hooks/useUrl';
55

6-
export function useCustomResourceUrl(crd) {
7-
const { clusterUrl, namespaceUrl } = useUrl();
6+
export function useCustomResourceUrl(crd, columnLayout = false) {
7+
const { resourceUrl, clusterUrl, namespaceUrl } = useUrl();
88
const clusterNodes = useRecoilValue(allNodesSelector).filter(
99
node => !node.namespaced,
1010
);
@@ -22,10 +22,14 @@ export function useCustomResourceUrl(crd) {
2222
);
2323

2424
if (clusterNode) {
25+
return resourceUrl(cr, { resourceType: clusterNode.pathSegment });
26+
} else if (namespaceNode && !columnLayout) {
27+
return resourceUrl(cr, { resourceType: namespaceNode.pathSegment });
28+
} else if (crd.spec.scope === 'Cluster') {
2529
return clusterUrl(
2630
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
2731
);
28-
} else if (namespaceNode) {
32+
} else {
2933
return namespaceUrl(
3034
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
3135
{ namespace: cr.metadata.namespace },

0 commit comments

Comments
 (0)