Skip to content

Commit c839524

Browse files
Tests corrections
1 parent 5ebbea3 commit c839524

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

src/command-pallette/CommandPalletteUI/components/components.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ export function CommandPalletteHelp({
9090
<table className="help-text">
9191
<thead>
9292
<tr>
93-
<th scope="col">{t('common.headers.name')}</th>
94-
<th scope="col">{t('common.headers.description')}</th>
93+
<th>{t('common.headers.name')}</th>
94+
<th>{t('common.headers.description')}</th>
9595
</tr>
9696
</thead>
9797
<tbody>

src/shared/components/GenericList/GenericList.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ export const GenericList = ({
196196
if (serverDataError) {
197197
return (
198198
<BodyFallback key="tableErrorMessage">
199-
<p role="text">{getErrorMessage(serverDataError)}</p>
199+
<p>{getErrorMessage(serverDataError)}</p>
200200
</BodyFallback>
201201
);
202202
}
@@ -212,7 +212,7 @@ export const GenericList = ({
212212
if (searchQuery) {
213213
return (
214214
<BodyFallback>
215-
<p role="text">
215+
<p>
216216
{i18n.exists(searchSettings.noSearchResultMessage)
217217
? t(searchSettings.noSearchResultMessage)
218218
: searchSettings.noSearchResultMessage}
@@ -236,7 +236,7 @@ export const GenericList = ({
236236
image={emptyListProps?.image}
237237
/>
238238
) : (
239-
<p role="text">
239+
<p>
240240
{emptyListProps?.titleText ? (
241241
<Trans i18nKey={emptyListProps?.titleText} />
242242
) : i18n.exists(notFoundMessage) ? (

src/shared/components/GenericList/Pagination/Pagination.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ export const Pagination = ({
110110
isInteractable={currentPage !== 1}
111111
onClick={() => onChangePage(1)}
112112
accessibleName="First page"
113+
accesskey="first-page-link"
113114
>
114115
<Icon
115116
accessibleName="first page icon"
@@ -122,6 +123,7 @@ export const Pagination = ({
122123
isInteractable={currentPage !== 1}
123124
onClick={() => onChangePage(currentPage - 1)}
124125
accessibleName="Previous page"
126+
accesskey="previous-page-link"
125127
>
126128
<Icon
127129
accessibleName="previous page icon"
@@ -170,6 +172,7 @@ export const Pagination = ({
170172
isInteractable={currentPage !== pagesCount}
171173
onClick={() => onChangePage(currentPage + 1)}
172174
accessibleName="Next page"
175+
accesskey="next-page-link"
173176
>
174177
<Icon
175178
accessibleName="next page icon"
@@ -182,6 +185,7 @@ export const Pagination = ({
182185
isInteractable={currentPage !== pagesCount}
183186
onClick={() => onChangePage(pagesCount)}
184187
accessibleName="Last page"
188+
accesskey="last-page-link"
185189
>
186190
<Icon
187191
accessibleName="last page icon"

src/shared/components/GenericList/components.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const HeaderRenderer = ({
4141
importance={0}
4242
popinHidden={true}
4343
key="actions-column"
44+
scope="col"
4445
aria-label="actions-column"
4546
minWidth={`${30 * actions.length}px`}
4647
>
@@ -77,6 +78,7 @@ export const HeaderRenderer = ({
7778
{headerRenderer()?.map((h, index) => {
7879
return (
7980
<TableHeaderCell
81+
scope="col"
8082
key={`${typeof h === 'object' ? index : h}-column`}
8183
popinText={h === 'Popin' ? t('common.headers.specification') : h}
8284
popinHidden={h !== 'Popin' && !noHideFields?.includes(h)}

src/shared/components/PodTemplate/components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function PodTemplateTable({ className, items, columns, rowRenderer }) {
2929
headerRow={
3030
<TableHeaderRow style={{ width: '50%' }}>
3131
{columns.map(column => (
32-
<TableHeaderCell>
32+
<TableHeaderCell scope="col" key={column}>
3333
<Title level="H5">{column}</Title>
3434
</TableHeaderCell>
3535
))}

0 commit comments

Comments
 (0)