Skip to content

Commit d88df2e

Browse files
authored
fix: Fix width of linear charts in lists and placement of action buttons (#3891)
* fix: columns widths * fix job test
1 parent dd53245 commit d88df2e

File tree

6 files changed

+14
-2
lines changed

6 files changed

+14
-2
lines changed

src/shared/components/GenericList/GenericList.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
border-bottom: var(--sapList_BorderWidth) solid
2020
var(--sapList_SelectionBorderColor);
2121
}
22+
23+
ui5-table-cell {
24+
width: 100%;
25+
}
2226
}
2327

2428
.cursor-pointer {

src/shared/components/GenericList/components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ const DefaultRowRenderer = ({
150150
}
151151
});
152152
const actionsCell = (
153-
<TableCell>
153+
<TableCell horizontalAlign="Right">
154154
<ListActions actions={actions} entry={entry} />
155155
</TableCell>
156156
);

src/shared/components/ProgressIndicatorWithPercentage/ProgressIndicatorWithPercentage.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@ export const ProgressIndicatorWithPercentage = ({
3232
}
3333
};
3434

35+
const tooltipProps = { ...tooltip, style: { width: '100%' } };
36+
3537
return (
36-
<TooltipWrapper tooltipProps={tooltip}>
38+
<TooltipWrapper tooltipProps={tooltipProps}>
3739
<div className="progress-indicator-percentage">
3840
{rightTitle && (
3941
<p className="progress-indicator-percentage__percents">

src/shared/components/ProgressIndicatorWithPercentage/ProgressIndicatorWithPercentage.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
.progress-indicator-percentage {
2+
width: 100%;
3+
min-width: 6rem;
4+
25
&__percents {
36
text-align: end;
47
position: relative;

src/shared/components/Tooltip/Tooltip.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const Tooltip = ({
1212
trigger = 'mouseenter',
1313
tippyProps,
1414
delay = [200, 0],
15+
style,
1516
}) => {
1617
return (
1718
<TippyTooltip
@@ -20,6 +21,7 @@ export const Tooltip = ({
2021
trigger={trigger}
2122
distance={0}
2223
delay={delay}
24+
style={style}
2325
{...tippyProps}
2426
>
2527
{children}

tests/integration/tests/namespace/test-jobs.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ context('Test Jobs', () => {
168168
.find('input')
169169
.filterWithNoValue()
170170
.first()
171+
.click()
171172
.type('b', { force: true });
172173

173174
cy.saveChanges('Edit');

0 commit comments

Comments
 (0)