test: Stabilize tests (#4398)

* test: stabilize a-run-before test

* fix: localstorage not persisting after kubeconfig id login

* test: stabilize custom-resources test

* test: stabilize z-run-after test

* test: stabilize acc tests

* test: stabilize z-run-after test

* test: stabilize chooseComboboxOption helper

* test: stabilize custom-resources test

* test: stabilize typeInSearch helper

* test: stabilize typeInSearch helper

* fix: retry transient streamin API errors

* test: stabilize inspectTab helper

* test: stabilize other helpers as well

* test: stabilize acc-custom-resources

* test: stabilize acc tests

* test: stabilize community modules test

* test: stabilize jobs test

* test: stabilize jobs test

* test: stabilize z run after test

* fix: go network errors regex

* fix: compile regex

Author: chriskari

src/shared/hooks/BackendAPI/useGet.js

@@ -11,6 +11,12 @@ import { authDataAtom } from '../../../state/authDataAtom';
 // allow <n> consecutive requests to fail before displaying error
 const ERROR_TOLERANCY = 2;
 
+// Regex to detect Kubernetes API errors returned as stream content
+// These have the format: Get "https://...". EOF or similar
+const K8S_STREAM_ERROR_REGEX =
+  /Get "https?:\/\/[^"]+"[.:]\s*(EOF|connection refused|i\/o timeout)/i;
+const MAX_LINE_LENGTH_TO_CHECK = 1000;
+
 const useGetHook = (processDataFn) =>
   function (
     path,
@@ -187,15 +193,42 @@ export const useGetStream = (path) => {
   const fetch = useFetch();
   const readerRef = useRef(null);
   const abortController = useRef(new AbortController());
+  const k8sErrorRetryCount = useRef(0);
 
   const processError = (error) => {
     console.error(error);
     setError(error);
   };
 
+  // Unified retry logic for both text-based and exception-based errors
+  const handleTransientError = (e) => {
+    if (k8sErrorRetryCount.current < 5) {
+      console.warn(`Transient stream error detected (${e}), retrying...`);
+      k8sErrorRetryCount.current++;
+
+      if (timeoutRef.current) clearTimeout(timeoutRef.current);
+      timeoutRef.current = setTimeout(refetchData, 1000);
+    } else {
+      processError(e);
+    }
+  };
+
   const processData = (data) => {
     const string = new TextDecoder().decode(data);
     const streams = string?.split('\n').filter((stream) => stream !== '');
+
+    const hasK8sError = streams.some((line) => {
+      if (line.length > MAX_LINE_LENGTH_TO_CHECK) return false;
+
+      return K8S_STREAM_ERROR_REGEX.test(line);
+    });
+
+    if (hasK8sError) {
+      handleTransientError(new Error('Stream contained Kubernetes API Error'));
+      return;
+    }
+
+    k8sErrorRetryCount.current = 0;
     setData((prevData) => [...prevData, ...streams]);
   };
 
@@ -235,14 +268,16 @@ export const useGetStream = (path) => {
 
               return push();
             } catch (e) {
-              processError(e);
+              // Handle stream read errors (network-level)
+              handleTransientError(e);
             }
           };
           push();
         },
       });
     } catch (e) {
-      if (!e.toString().includes('abort')) processError(e);
+      // Handle connection errors (network-level)
+      if (!e.toString().includes('abort')) handleTransientError(e);
     }
   };
 

src/state/clustersAtom.ts

@@ -9,11 +9,30 @@ export type ClustersState = {
   [clusterName: string]: Cluster;
 } | null;
 
-export const clustersAtom = atom<ClustersState>({});
-clustersAtom.debugLabel = 'clustersAtom';
-
 const inMemoryClusters: ClustersState = {};
 
+const getInitialClustersState = (): ClustersState => {
+  try {
+    const localStorageClusters = JSON.parse(
+      localStorage.getItem(CLUSTERS_STORAGE_KEY) || '{}',
+    );
+    const sessionStorageClusters = JSON.parse(
+      sessionStorage.getItem(CLUSTERS_STORAGE_KEY) || '{}',
+    );
+    return {
+      ...localStorageClusters,
+      ...sessionStorageClusters,
+      ...inMemoryClusters,
+    };
+  } catch (e) {
+    console.warn('Cannot get clusters', e);
+    return {};
+  }
+};
+
+export const clustersAtom = atom<ClustersState>(getInitialClustersState());
+clustersAtom.debugLabel = 'clustersAtom';
+
 export const clustersAtomEffectSetSelf = withAtomEffect(
   clustersAtom,
   (_get, set) => {

tests/integration/cypress.config.js

@@ -37,7 +37,7 @@ module.exports = defineConfig({
       'tests/accessibility/test-acc-performance.spec.js',
       'tests/accessibility/test-acc-extensions.spec.js',
       'tests/accessibility/test-acc-pizzas.spec.js',
-      'tests/accessibility/test-acc-custom-resoureces.spec.js',
+      'tests/accessibility/test-acc-custom-resources.spec.js',
       'tests/cluster/test-download-a-kubeconfig.spec.js',
       'tests/cluster/test-edit-cluster.spec.js',
       'tests/cluster/test-cluster-overview.spec.js',

tests/integration/support/commands.js

@@ -52,6 +52,8 @@ Cypress.Commands.add('clickGenericListLink', (resourceName) => {
     .find('ui5-table-cell')
     .contains('ui5-text', resourceName)
     .click();
+
+  cy.wait(500);
 });
 
 Cypress.Commands.add('clickListLink', (resourceName) => {
@@ -129,6 +131,10 @@ Cypress.Commands.add('getLeftNav', () => {
   return cy.get('aside');
 });
 
+Cypress.Commands.add('getStartColumn', () => {
+  return cy.get('div[slot="startColumn"]');
+});
+
 Cypress.Commands.add('getMidColumn', () => {
   return cy.get('div[slot="midColumn"]');
 });
@@ -334,9 +340,10 @@ Cypress.Commands.add('closeEndColumn', (checkIfNotExist = false) => {
   else cy.getEndColumn().should('not.be.visible');
 });
 
-Cypress.Commands.add('typeInSearch', (searchPhrase, force) => {
+Cypress.Commands.add('typeInSearch', (searchPhrase, force = false) => {
+  cy.wait(500);
   cy.get('ui5-input[id^=search-]:visible')
     .find('input')
-    .wait(1000)
+    .should('be.visible')
     .type(searchPhrase, { force });
 });

tests/integration/support/create-edit-support.js

@@ -1,5 +1,6 @@
 Cypress.Commands.add('openCreate', () => {
   cy.get('ui5-panel').contains('ui5-button', 'Create').click();
+  cy.wait(500);
 });
 
 Cypress.Commands.add('saveChanges', (action = 'Create') => {

tests/integration/support/helpers.js

@@ -2,9 +2,10 @@ export function chooseComboboxOption(selector, optionText, force = false) {
   cy.get(`ui5-combobox${selector}`)
     .find('input')
     .filterWithNoValue()
-    .as('comboboxInput')
-    .click();
-  cy.get('@comboboxInput').type(optionText);
+    .click()
+    .wait(500)
+    .type(optionText)
+    .wait(500);
 
   cy.get('ui5-cb-item:visible').contains(optionText).click({ force: force });
 

tests/integration/support/inspectTab.js

@@ -2,16 +2,15 @@ Cypress.Commands.add(
   'inspectTab',
   { prevSubject: ['optional', 'element'] },
   (subject, tabName) => {
-    (subject
-      ? cy.wrap(subject).find('ui5-tabcontainer')
-      : cy.get('ui5-tabcontainer')
+    return (
+      subject
+        ? cy.wrap(subject).find('ui5-tabcontainer')
+        : cy.get('ui5-tabcontainer')
     )
       .find('[role="tablist"]')
       .find('[role="tab"]')
       .contains(tabName)
       .should('be.visible')
-      .as('tabButton');
-
-    return cy.get('@tabButton').click();
+      .click();
   },
 );

tests/integration/support/navigate-to.js

@@ -2,18 +2,14 @@ Cypress.Commands.add('navigateTo', (leftNav, resource) => {
   cy.wait(1500)
     .getLeftNav()
     .get(`ui5-side-navigation-item[text="${leftNav}"]`)
-    .as('btn-1')
-    .should('be.visible');
-
-  cy.get('@btn-1').click();
+    .should('be.visible')
+    .click();
 
   if (resource) {
     cy.getLeftNav()
       .get(`ui5-side-navigation-sub-item[text="${resource}"]`)
-      .as('btn-2')
-      .should('be.visible');
-
-    cy.get('@btn-2').click();
+      .should('be.visible')
+      .click();
   }
   cy.wait(1500);
 });

tests/integration/tests/accessibility/test-acc-cron-jobs.spec.js

@@ -15,6 +15,10 @@ context('Accessibility test Cron Jobs', () => {
     cy.createNamespace(NAMESPACE_NAME);
   });
 
+  beforeEach(() => {
+    cy.wait(500);
+  });
+
   it('Acc test Cron Jobs list', () => {
     cy.loginAndSelectCluster();
 

…ility/test-acc-custom-resoureces.spec.js …bility/test-acc-custom-resources.spec.jstests/integration/tests/accessibility/test-acc-custom-resoureces.spec.js renamed to tests/integration/tests/accessibility/test-acc-custom-resources.spec.js tests/integration/tests/accessibility/test-acc-custom-resoureces.spec.js renamed to tests/integration/tests/accessibility/test-acc-custom-resources.spec.js

@@ -27,6 +27,10 @@ context('Accessibility test Custom Resources', () => {
     cy.saveChanges('Create');
   });
 
+  beforeEach(() => {
+    cy.wait(500);
+  });
+
   it('Acc test Custom Resources overview', () => {
     cy.getLeftNav().contains('Custom Resources').click();
 
@@ -70,7 +74,7 @@ context('Accessibility test Custom Resources', () => {
 
     cy.clickGenericListLink('Tclusters');
 
-    cy.contains('ui5-button', 'Create').click();
+    cy.openCreate();
 
     cy.wrap(loadFile(TCLUSTER_FILE_NAME)).then((TC_CONFIG) => {
       const TC = JSON.stringify(TC_CONFIG);