Skip to content

Commit 72635b3

Browse files
committed
Add TODO in implementation where needed.
1 parent b19ce31 commit 72635b3

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

internal/reconciliations/istio/gateway_api_crds.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ func (g *GatewayAPICRDManager) Install(ctx context.Context) (GatewayAPICRDInstal
114114
continue
115115
}
116116

117+
// TODO(gateway-api-parked): This feature was parked in April 2026.
118+
// The paragraph below with version checking should be extended,
119+
// so that only conformant with Istio upstream version Gateway API CRDs versions are being installed.
120+
117121
// CRD already exists and is managed by Istio module.
118122
// Check specific CRD target version with expected gatewayAPI CRD version
119123
existingVersion := existingCRD.Annotations[bundleVersionKey]
@@ -172,6 +176,12 @@ func (g *GatewayAPICRDManager) Uninstall(
172176
) error {
173177
ctrl.Log.Info("Starting Gateway API CRDs removal (labeled CRDs only)", "version", gatewayAPIVersion)
174178

179+
// TODO(gateway-api-parked): This feature was parked in April 2026.
180+
// Need to be checked why:
181+
// If there exist Gateway API CR managed by Istio and it is blocking the uninstallation
182+
// the uninstallation won't happen - probably because of modified latAppliedConfig annotation
183+
// or some issue in the condition logic below.
184+
175185
// Check for blocking Gateway API CRs once, before touching any CRD.
176186
// Only CRs belonging to module-managed CRDs are considered blocking.
177187
blocking, err := FindBlockingGatewayAPIResources(ctx, g.client)
@@ -230,7 +240,6 @@ func (g *GatewayAPICRDManager) Uninstall(
230240
continue
231241
}
232242

233-
234243
ctrl.Log.Info("Deleting managed Gateway API CRD", "name", crd.Name)
235244
if deleteErr := g.client.Delete(ctx, existingCRD); deleteErr != nil {
236245
if apierrors.IsNotFound(deleteErr) {

internal/reconciliations/istio/gateway_api_crds_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ import (
1414
"github.com/kyma-project/istio/operator/internal/reconciliations/istio"
1515
)
1616

17+
// TODO(gateway-api-parked): This feature was parked in April 2026.
18+
// This test file needs full rewrite of test cases based on new gateway_api_crds.go implementation.
19+
1720
var _ = Describe("Gateway API CRDs", func() {
1821
var (
1922
ctx context.Context

0 commit comments

Comments
 (0)