Fix sync update response - additional worker nodes config nil equals … (#2867)

Fix sync update response - additional worker nodes config nil equals empty list

Author: piotrmiskiewicz

internal/broker/instance_update.go

@@ -484,7 +484,8 @@ func (b *UpdateEndpoint) shouldSkipNewOperation(previousInstance, currentInstanc
 	}
 	// do not compare "Active" field
 	previousInstance.Parameters.ErsContext.Active = currentInstance.Parameters.ErsContext.Active
-	if !reflect.DeepEqual(previousInstance.Parameters, currentInstance.Parameters) {
+
+	if !previousInstance.Parameters.IsEqual(currentInstance.Parameters) {
 		logger.Info("Parameters changed, cannot skip new operation")
 
 		if !reflect.DeepEqual(previousInstance.Parameters.ErsContext, currentInstance.Parameters.ErsContext) {

internal/broker/instance_update_test.go

@@ -2442,6 +2442,16 @@ func TestUpdateWithoutOperation(t *testing.T) {
 			updateParameters:  `{"machineType":"m5.xlarge", "foo":"bar"}`,
 			expectedSync:      true,
 		},
+		"Update with additional worker node pool change": {
+			initialParameters: `{"machineType":"m5.xlarge","region":"eu-west-1", "additionalWorkerNodePools": []}`,
+			updateParameters:  `{                                                "additionalWorkerNodePools": []}`,
+			expectedSync:      true,
+		},
+		"Update with oidc": {
+			initialParameters: `{"machineType":"m5.xlarge","region":"eu-west-1", "oidc.list": []}`,
+			updateParameters:  `{                                                "oidc.list": []}`,
+			expectedSync:      true,
+		},
 	} {
 		t.Run(tn, func(t *testing.T) {
 			initialParams := pkg.ProvisioningParametersDTO{}

internal/dto.go

@@ -34,6 +34,11 @@ func (p ProvisioningParameters) IsEqual(input ProvisioningParameters) bool {
 		return false
 	}
 
+	// empty list and nil does not make any difference
+	if (p.Parameters.AdditionalWorkerNodePools == nil && len(input.Parameters.AdditionalWorkerNodePools) == 0) ||
+		(input.Parameters.AdditionalWorkerNodePools == nil && len(p.Parameters.AdditionalWorkerNodePools) == 0) {
+		p.Parameters.AdditionalWorkerNodePools = input.Parameters.AdditionalWorkerNodePools
+	}
 	p.Parameters.TargetSecret = nil
 
 	if !reflect.DeepEqual(p.Parameters, input.Parameters) {