Fix provider setting in the instance creation (#1958)

* Fix provider setting in the instance creation

* wip

* wip

Author: piotrmiskiewicz

internal/broker/instance_create.go

@@ -250,6 +250,7 @@ func (b *ProvisionEndpoint) Provision(ctx context.Context, instanceID string, de
 		ServicePlanName: PlanNamesMapping[provisioningParameters.PlanID],
 		DashboardURL:    dashboardURL,
 		Parameters:      operation.ProvisioningParameters,
+		Provider:        pkg.CloudProviderFromString(providerValues.ProviderType),
 	}
 	err = b.instanceStorage.Insert(instance)
 	if err != nil {

internal/broker/instance_create_test.go

@@ -122,6 +122,7 @@ func TestProvision_Provision(t *testing.T) {
 		assert.Regexp(t, `^https:\/\/dashboard\.example\.com\/\?kubeconfigID=`, response.DashboardURL)
 		assert.Equal(t, instance.GlobalAccountID, globalAccountID)
 		assert.Equal(t, fixDNSProviders(), instance.InstanceDetails.ShootDNSProviders)
+		assert.Equal(t, pkg.Azure, instance.Provider)
 	})
 
 	t.Run("new operation for own_cluster plan with kubeconfig will be created", func(t *testing.T) {

internal/runtime/converter.go

@@ -44,6 +44,11 @@ func (c *converter) ApplyProvisioningOperation(dto *pkg.RuntimeDTO, pOpr *intern
 		c.applyOperation(&pOpr.Operation, dto.Status.Provisioning)
 		c.adjustRuntimeState(dto)
 		dto.SubscriptionSecretName = pOpr.ProvisioningParameters.Parameters.TargetSecret
+
+		// fallback if the field is not set, the provisioning operation contains it in the ProviderValues, see instance creation in the instance_create.go
+		if dto.Provider == "" && pOpr.ProviderValues != nil {
+			dto.Provider = string(pkg.CloudProviderFromString(pOpr.ProviderValues.ProviderType))
+		}
 	}
 }