staticcheck linter

[jaroslaw-pieszka]

https://wiki.one.int.sap/wiki/spaces/kyma/pages/5825828909/Linter+analyisis
minor issues but a lot of them
399 issues:

• staticcheck: 399

Here you can find settings for linter:

• https://golangci-lint.run/docs/linters/configuration/#staticcheck
  probably copilot can do that and there will be less after finishing other linters.
• here you can find settings for golangci-yaml to e.g. exclude some files/ directories etc: https://golangci-lint.run/docs/configuration/file/
• So the configuration is 2 levels
  • specific for linter
  • global configuration e.g. exclusions (those can be used globally or apply only with selected linter)

[jaroslaw-pieszka]

2 findings done

[jaroslaw-pieszka]

To configure add line to .golangci.yaml

linters:
  default: none
  enable:
    - staticcheck # Advanced static analysis

[jaroslaw-pieszka]

In future use:

    - staticcheck
  settings:
    staticcheck:
      checks: ["all", "-QF1008"]  # Disable specific staticcheck rules

[piotrek1459]

Update:
SA4006 (105) - Remove unused assignments
ST1005 (47) - Error string formatting
S1009 (7) - Remove unnecessary nil checks
ST1019 (4) - Duplicate imports
SA4009 (4) - Fix function arguments
S1008 (3) - Simplify returns
Remaining smaller groups

with such settings:

linters:
  default: none
  enable:
    - staticcheck # Advanced static analysis
settings:
    staticcheck:
      checks: ["all", "-QF1008"]  # Disable specific staticcheck rules

[piotrek1459]

    staticcheck:
      checks:
        - "all"
        - "-QF1008"
        - "-ST1000"

this is current state of settings for staticcheck linter. The ST1000 is error that tells that there is no package comment.