fix Buffer breaking types in non-Node TypeScript environments. (#1542)

Author: igalklebanov

src/util/type-utils.ts

@@ -250,7 +250,12 @@ export type ShallowDehydrateValue<T> = T extends null | undefined
             ? never
             : string)
 
-export type StringsWhenDataTypeNotAvailable = Date | Buffer | ArrayBuffer
+export type StringsWhenDataTypeNotAvailable =
+  | Date
+  // Many Node.js drivers return `Buffer` by default for some column data types.
+  // Buffer is a subclass of `Uint8Array`. `Buffer` doesn't exist in non-Node TypeScript
+  // environments - and results in `any` or a compilation error if used.
+  | Uint8Array
 
 export type NumbersWhenDataTypeNotAvailable = bigint | NumericString
 

test/typings/test-d/postgres-json.test-d.ts

@@ -46,6 +46,7 @@ async function testPostgresJsonSelects(db: Kysely<Database>) {
         modified_at: eb.ref('modified_at'),
         people_with_same_name_by_2050: sql<bigint>`custom_function(first_name)`,
         people_with_same_name_by_2050_str: sql<NumericString>`custom_function(first_name)::text`,
+        binary_thing: sql<Buffer>`another_custom_function()`,
       }).as('name'),
 
     // Nest other people with same first name.
@@ -90,6 +91,7 @@ async function testPostgresJsonSelects(db: Kysely<Database>) {
         modified_at: string
         people_with_same_name_by_2050: number
         people_with_same_name_by_2050_str: number
+        binary_thing: string
       }
       people_same_first_name: {
         id: number