Skip to content

Commit 75b0bbb

Browse files
committed
fix: make Home and Config pages scrollable (#40)
1 parent 42595df commit 75b0bbb

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

app/src/main/java/dev/bluehouse/enablevolte/pages/Config.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package dev.bluehouse.enablevolte.pages
33
import android.telephony.CarrierConfigManager
44
import androidx.compose.foundation.layout.Column
55
import androidx.compose.foundation.layout.padding
6+
import androidx.compose.foundation.rememberScrollState
7+
import androidx.compose.foundation.verticalScroll
68
import androidx.compose.runtime.Composable
79
import androidx.compose.runtime.getValue
810
import androidx.compose.runtime.mutableStateOf
@@ -27,6 +29,7 @@ import java.lang.IllegalStateException
2729
fun Config(navController: NavController, subId: Int) {
2830
val moder = SubscriptionModer(subId)
2931
val carrierModer = CarrierModer(LocalContext.current)
32+
val scrollState = rememberScrollState()
3033

3134
var configurable by rememberSaveable { mutableStateOf(false) }
3235
var voLTEEnabled by rememberSaveable { mutableStateOf(false) }
@@ -66,7 +69,7 @@ fun Config(navController: NavController, subId: Int) {
6669
}
6770
}
6871

69-
Column(modifier = Modifier.padding(Dp(16f))) {
72+
Column(modifier = Modifier.padding(Dp(16f)).verticalScroll(scrollState)) {
7073
HeaderText(text = "Toggles")
7174
BooleanPropertyView(label = "Enable VoLTE", toggled = voLTEEnabled) {
7275
voLTEEnabled = if (voLTEEnabled) {

app/src/main/java/dev/bluehouse/enablevolte/pages/Home.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import android.telephony.SubscriptionInfo
77
import android.util.Log
88
import androidx.compose.foundation.layout.Column
99
import androidx.compose.foundation.layout.padding
10+
import androidx.compose.foundation.rememberScrollState
11+
import androidx.compose.foundation.verticalScroll
1012
import androidx.compose.runtime.Composable
1113
import androidx.compose.runtime.getValue
1214
import androidx.compose.runtime.mutableStateOf
@@ -38,6 +40,7 @@ const val TAG = "HomeActivity:Home"
3840
fun Home(navController: NavController) {
3941
val carrierModer = CarrierModer(LocalContext.current)
4042
val context = LocalContext.current
43+
val scrollState = rememberScrollState()
4144

4245
var shizukuEnabled by rememberSaveable { mutableStateOf(false) }
4346
var shizukuGranted by rememberSaveable { mutableStateOf(false) }
@@ -84,7 +87,7 @@ fun Home(navController: NavController) {
8487
}
8588
}
8689

87-
Column(modifier = Modifier.padding(Dp(16f))) {
90+
Column(modifier = Modifier.padding(Dp(16f)).verticalScroll(scrollState)) {
8891
HeaderText(text = "Version")
8992
if (newerVersion.isNotEmpty()) {
9093
ClickablePropertyView(label = BuildConfig.VERSION_NAME, value = "Newer version $newerVersion available!") {

0 commit comments

Comments
 (0)