working av1 and h264 decoder, h265 is fucked up for some reason and idk why??

Author: l1npengtul

flake.lock

@@ -5,102 +5,100 @@
     rust-overlay.url = "github:oxalica/rust-overlay";
   };
 
-  outputs =
-    {
-      self,
-      nixpkgs,
-      rust-overlay,
-      flake-utils,
-      ...
-    }:
+  outputs = {
+    self,
+    nixpkgs,
+    rust-overlay,
+    flake-utils,
+    ...
+  }:
     flake-utils.lib.eachDefaultSystem (
-      system:
-      let
+      system: let
         pkgs = import nixpkgs {
           inherit system;
-          overlays = [ rust-overlay.overlays.default ];
+          overlays = [rust-overlay.overlays.default];
           config.allowUnfree = true;
         };
         rustshell = pkgs.mkShell.override {
-        	stdenv = pkgs.gccStdenv;
+          stdenv = pkgs.gccStdenv;
         };
         rustbin = pkgs.rust-bin.selectLatestNightlyWith (
           toolchain:
-          toolchain.default.override {
-            extensions = [
-              "rust-src"
-              "clippy"
-              "rustfmt"
-              "miri"
-              "rust-analyzer"
-            ];
-          }
+            toolchain.default.override {
+              extensions = [
+                "rust-src"
+                "clippy"
+                "rustfmt"
+                "miri"
+                "rust-analyzer"
+              ];
+            }
         );
-      in
-      {
+      in {
         formatter = pkgs.alejandra;
 
         devShells.default = rustshell {
-          packages = [
-            rustbin
-          ]
-          ++ (with pkgs; [
-            llvmPackages_21.clangWithLibcAndBasicRtAndLibcxx
-            pkg-config
-            cmake
-            vcpkg
-            lldb
-            rustPlatform.bindgenHook
-            xmlstarlet
-            opencv
-            alsa-lib
-            systemdLibs
-            cmake
-            fontconfig
-            linuxHeaders
-            v4l-utils
-            libv4l
-            pipewire
-            rustup
-            gcc
-            ffmpeg-full
-            nasm
-            libGL
-            flite
-            quirc
-            lcevcdec
-            xz
-            celt
-            opencore-amr
-            snappy
-            codec2
-            gsm
-            ilbc
-            lame
-            libtheora
-            libogg
-            twolame
-            vo-amrwbenc
-            vvenc
-            xavs
-            xvidcore
-            soxr
-            libvdpau
-            jetbrains.rust-rover
-          ]);
+          packages =
+            [
+              rustbin
+            ]
+            ++ (with pkgs; [
+              llvmPackages_21.clangWithLibcAndBasicRtAndLibcxx
+              pkg-config
+              cmake
+              vcpkg
+              lldb
+              rustPlatform.bindgenHook
+              xmlstarlet
+              opencv
+              alsa-lib
+              systemdLibs
+              cmake
+              fontconfig
+              linuxHeaders
+              v4l-utils
+              libv4l
+              pipewire
+              rustup
+              gcc
+              ffmpeg_8-full
+              nasm
+              libGL
+              flite
+              quirc
+              lcevcdec
+              xz
+              celt
+              opencore-amr
+              snappy
+              codec2
+              gsm
+              ilbc
+              lame
+              libtheora
+              libogg
+              twolame
+              vo-amrwbenc
+              vvenc
+              xavs
+              xvidcore
+              soxr
+              libvdpau
+              gmp
+              openapv
+              svt-av1
+            ]);
 
           env.RUST_SRC_PATH = "${rustbin}/lib/rustlib/src/rust/library";
           env.LIBCLANG_PATH = "${pkgs.llvmPackages.libclang.lib}/lib";
 
-          shellHook =
-            let
-              pathToRustProject = "/project/component[@name='RustProjectSettings']";
-            in
-            ''
-              echo "WONDERHOOOOOY!!!!"
-              xmlstarlet edit --inplace --update "${pathToRustProject}/option[@name='explicitPathToStdlib']/@value" --value "${rustbin}/lib/rustlib/src/rust/library" .idea/workspace.xml
-              xmlstarlet edit --inplace --update "${pathToRustProject}/option[@name='toolchainHomeDirectory']/@value" --value "${rustbin}/bin" .idea/workspace.xml
-            '';
+          shellHook = let
+            pathToRustProject = "/project/component[@name='RustProjectSettings']";
+          in ''
+            echo "WONDERHOOOOOY!!!!"
+            xmlstarlet edit --inplace --update "${pathToRustProject}/option[@name='explicitPathToStdlib']/@value" --value "${rustbin}/lib/rustlib/src/rust/library" .idea/workspace.xml
+            xmlstarlet edit --inplace --update "${pathToRustProject}/option[@name='toolchainHomeDirectory']/@value" --value "${rustbin}/bin" .idea/workspace.xml
+          '';
         };
       }
     );

flake.nix

@@ -47,7 +47,7 @@ pub trait CodecAsync: Codec {
     async fn set_format_async(&self, format: CameraFormat) -> Result<(), NokhwaError>;
 
     fn set_config_async(&mut self, config: Self::Config) -> Result<(), NokhwaError> {
-        self.set_config(config)
+        self.set_config(&config)
     }
 
     fn send_item_async(&mut self, input: Self::Input<'_>) -> Result<(), NokhwaError>;

nokhwa-core/src/codec.rs

@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 use crate::frame_format::{CustomFrameFormat, FrameFormat};
-use std::fmt::Debug;
-use thiserror::Error;
 use crate::pixel_destination::PixelDestination;
 use crate::types::Backends;
+use std::fmt::Debug;
+use thiserror::Error;
 
 pub type NokhwaResult<T> = Result<T, NokhwaError>;
 
@@ -85,7 +85,19 @@ pub enum NokhwaError {
     DecoderDestinationHintRequired,
     #[error("Decoder already deinitialized. Unusable, please make a new decoder.")]
     DecoderAlreadyDeinitialized,
+    #[error(
+        "Decoder requires more data to process - not actual error - please send more data to decode: {0}"
+    )]
+    DecoderNeedsMoreData(String),
 }
+
+impl NokhwaError {
+    #[must_use]
+    pub fn is_needs_more(&self) -> bool {
+        matches!(self, NokhwaError::DecoderNeedsMoreData(_))
+    }
+}
+
 //
 // pub enum InitializeError {}
 //

nokhwa-core/src/error.rs

@@ -90,11 +90,31 @@ pub struct FrameBuffer<'a> {
 impl<'a> FrameBuffer<'a> {
     /// Creates a new buffer with a [`&[u8]`].
     #[must_use]
-    #[inline]
     pub fn new(buffer: Cow<'a, [u8]>, metadata: Option<Metadata>) -> Self {
         Self { buffer, metadata }
     }
 
+    #[must_use]
+    pub fn from_buffer(buffer: &'a [u8], metadata: Option<Metadata>) -> Self {
+        FrameBuffer {
+            buffer: Cow::Borrowed(buffer),
+            metadata,
+        }
+    }
+
+    #[must_use]
+    pub fn from_cow(buffer: Cow<'a, [u8]>, metadata: Option<Metadata>) -> Self {
+        FrameBuffer { buffer, metadata }
+    }
+
+    #[must_use]
+    pub fn from_vec(buffer: Vec<u8>, metadata: Option<Metadata>) -> Self {
+        FrameBuffer {
+            buffer: Cow::Owned(buffer),
+            metadata,
+        }
+    }
+
     /// Get the data of this buffer.
     #[must_use]
     pub fn buffer(&'a self) -> &'a [u8] {
@@ -147,22 +167,28 @@ impl Deref for FrameBuffer<'_> {
     }
 }
 
-impl From<Vec<u8>> for FrameBuffer<'_> {
-    fn from(value: Vec<u8>) -> Self {
-        let buffer = Cow::Owned(value);
+impl<'a> From<&'a [u8]> for FrameBuffer<'a> {
+    fn from(value: &'a [u8]) -> Self {
+        FrameBuffer {
+            buffer: Cow::Borrowed(value),
+            metadata: None,
+        }
+    }
+}
 
+impl From<Vec<u8>> for FrameBuffer<'static> {
+    fn from(value: Vec<u8>) -> Self {
         FrameBuffer {
-            buffer,
+            buffer: Cow::Owned(value),
             metadata: None,
         }
     }
 }
 
-impl<'a> From<&'a [u8]> for FrameBuffer<'a> {
-    fn from(value: &'a [u8]) -> Self {
-        let buffer = Cow::Borrowed(value);
+impl<'a> From<Cow<'a, [u8]>> for FrameBuffer<'a> {
+    fn from(value: Cow<'a, [u8]>) -> Self {
         FrameBuffer {
-            buffer,
+            buffer: value,
             metadata: None,
         }
     }

nokhwa-core/src/frame_buffer.rs

@@ -1,53 +1,53 @@
 [package]
-name    = "nokhwa-decoders"
+name = "nokhwa-decoders"
 version = "0.1.0"
 edition = "2024"
 
 [features]
-ffmpeg = [ "ffmpeg-the-third" ]
-yuyv   = [ "dcv-color-primitives", "yuv" ]
-mjpeg  = [ "zune-jpeg", "zune-core" ]
-luma   = [ "nokhwa-iter-extensions", "itermore" ]
-# static = ["ffmpeg-the-third/static"]
+ffmpeg = ["ffmpeg-the-third"]
+yuyv = ["dcv-color-primitives", "yuv"]
+mjpeg = ["zune-jpeg", "zune-core"]
+luma = ["nokhwa-iter-extensions", "itermore"]
+static = ["ffmpeg-the-third/static"]
 #async = []
 
 [dependencies]
 bytemuck = "1.23"
 
 [dependencies.nokhwa-core]
 version = "0.2"
-path    = "../nokhwa-core"
+path = "../nokhwa-core"
 
 [dependencies.ffmpeg-the-third]
-version  = "4.0.0"
+version = "4.0.0"
 optional = true
 
 [dependencies.yuv]
-version  = "0.8"
+version = "0.8"
 optional = true
 
 [dependencies.dcv-color-primitives]
-version  = "0.7"
+version = "0.7"
 optional = true
 
 [dependencies.zune-jpeg]
-version  = "0.5.0-rc9"
+version = "0.5.0-rc9"
 optional = true
 
 [dependencies.zune-core]
-version  = "0.5.0-rc2"
+version = "0.5.0-rc2"
 optional = true
 
 [dependencies.itermore]
-version  = "0.8"
-features = [ "array_chunks" ]
+version = "0.8"
+features = ["array_chunks"]
 optional = true
 
 [dependencies.nokhwa-iter-extensions]
-version  = "0.1"
-path     = "../nokhwa-iter-extensions"
+version = "0.1"
+path = "../nokhwa-iter-extensions"
 optional = true
 
 [dev-dependencies.image]
 workspace = true
-features  = [ "png", "jpeg", "avif" ]
+features = ["png", "jpeg", "avif"]