Update GPX export path to Documents folder for user accessibility (#458)

* SDK and MinSKD update

* Change GPX export to user-accessible location

Modifies the GPX export path to save files in a user-accessible location. Previously, files were exported to a default location that was not visible to the user, making access difficult. Exports are now saved in the Downloads folder. The solution works up to the latest version, Android 14.

Co-Authored-By: Kevin Salazar <[email protected]>

* Update strings-preferences.xml

Changed the GPX export location to the Documents folder for better organization and user accessibility, as per feedback. Adjusted related strings and resolved conflicts with PR #451

* Update GPX export logic

* Update GpsStatusRecord.java

* Update About.java

* Update ExportToStorageTask.java

* Update strings-preferences.xml

* Update ExportToStorageTask.java

* Update ExportToStorageTask.java

* Update AndroidManifest.xml

---------

Co-authored-by: Kevin Salazar <[email protected]>
Co-authored-by: Binnette <[email protected]>

Author: 3 people

app/src/main/AndroidManifest.xml

@@ -17,11 +17,6 @@
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-
-    <!-- External storage permissions -->
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
-
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
 
     <application
@@ -129,4 +124,4 @@
 
     </application>
 
-</manifest>
+</manifest>

app/src/main/java/net/osmtracker/activity/About.java

@@ -48,7 +48,7 @@ protected void onCreate(Bundle savedInstanceState) {
 		} catch (NameNotFoundException nnfe) { 
 			// Should not occur
 		}
-		
+
 		findViewById(R.id.about_debug_info_button).setOnClickListener(
 				new OnClickListener() {
 

app/src/main/java/net/osmtracker/gpx/ExportToStorageTask.java

@@ -41,6 +41,7 @@ protected File getExportDirectory(Date startDate) throws ExportTrackException {
         String trackName = getSanitizedTrackNameByStartDate(startDate);
         boolean shouldCreateDirectoryPerTrack = shouldCreateDirectoryPerTrack(preferences);
         File finalExportDirectory = getBaseExportDirectory(preferences);
+		Log.d(TAG, "absolute dir: " + finalExportDirectory.getAbsolutePath().toString());
 
         if( shouldCreateDirectoryPerTrack && trackName.length() >= 1){
             String uniqueFolderName = getUniqueChildNameFor(finalExportDirectory, trackName, "");
@@ -86,32 +87,31 @@ private boolean isExternalStorageWritable() {
 	}
 
 	// Create before returning if not exists
-    public File getBaseExportDirectory(SharedPreferences prefs) throws ExportTrackException {
+	public File getBaseExportDirectory(SharedPreferences prefs) throws ExportTrackException {
 
 		if (!isExternalStorageWritable()) {
 			throw new ExportTrackException(
 					context.getResources().getString(R.string.error_externalstorage_not_writable));
 		}
-
 		String exportDirectoryNameInPreferences = prefs.getString(
 				OSMTracker.Preferences.KEY_STORAGE_DIR,	OSMTracker.Preferences.VAL_STORAGE_DIR);
 		Log.d(TAG,"exportDirectoryNameInPreferences: " + exportDirectoryNameInPreferences);
 
 		File baseExportDirectory = new File(Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOCUMENTS),
 				exportDirectoryNameInPreferences);
-
-		if(! baseExportDirectory.exists()){
+		
+		// if folder not exists, create it
+		if (!baseExportDirectory.exists()) {
 			boolean ok = baseExportDirectory.mkdirs();
 			if (!ok) {
 				throw new ExportTrackException(
-						context.getResources().getString(
-								R.string.error_externalstorage_not_writable));
+						context.getResources().getString(R.string.error_externalstorage_not_writable));
 			}
 		}
 
-		Log.d(TAG, "BaseExportDirectory: " + baseExportDirectory);
+		Log.d(TAG, "BaseExportDirectory: " + baseExportDirectory.getAbsolutePath());
 		return baseExportDirectory;
-    }
+	}
 
 	@Override
 	protected boolean exportMediaFiles() {

app/src/main/res/values/strings-preferences.xml

@@ -73,7 +73,7 @@
 	<string name="prefs_displaytrack_osm_summary_ask">Always display OpenStreetMap background? Requires a data connection</string>
 
 	<string name="prefs_output">GPX settings</string>
-	<string name="prefs_storage_dir">External storage (SD) directory</string>
+	<string name="prefs_storage_dir">Storage folder in documents</string>
 	<string name="prefs_storage_dir_hint">Effective for the next track (not the current one)</string>
 	<string name="prefs_output_one_dir_per_track">One directory per track</string>
 	<string name="prefs_output_one_dir_per_track_summary">Save each track and associated files to its own directory</string>