Skip to content

Commit c8ef8b3

Browse files
ZahnstocherBinnette
authored andcommitted
Export to public directory (Fix #443, Fix #440)
1 parent 1114efe commit c8ef8b3

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

app/src/main/java/net/osmtracker/activity/About.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import android.app.Dialog;
1111
import android.app.ProgressDialog;
1212
import android.content.DialogInterface;
13+
import android.content.SharedPreferences;
1314
import android.content.pm.PackageInfo;
1415
import android.content.pm.PackageManager.NameNotFoundException;
1516
import android.os.Bundle;
@@ -76,7 +77,7 @@ public void onClick(View view) {
7677

7778
File dbFile = getDatabasePath(DatabaseHelper.DB_NAME);
7879
File targetFolder = new File(
79-
view.getContext().getExternalFilesDir(null),
80+
Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOCUMENTS),
8081
//Environment.getExternalStorageDirectory(),
8182
PreferenceManager.getDefaultSharedPreferences(About.this).getString(
8283
OSMTracker.Preferences.KEY_STORAGE_DIR,
@@ -128,10 +129,17 @@ public ProgressDialog getExportDbProgressDialog() {
128129

129130
private String getDebugInfo() {
130131
File externalStorageDir = this.getExternalFilesDir(null);
132+
SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(this);
133+
String exportDirectoryNameInPreferences = preferences.getString(
134+
OSMTracker.Preferences.KEY_STORAGE_DIR, OSMTracker.Preferences.VAL_STORAGE_DIR);
135+
File baseExportDirectory = new File(Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOCUMENTS),
136+
exportDirectoryNameInPreferences);
131137
return "External Storage Directory: '" + externalStorageDir + "'\n"
132138
+ "External Storage State: '" + Environment.getExternalStorageState() + "'\n"
133139
+ "Can write to external storage: "
134-
+ Environment.getExternalStorageState().equals(Environment.MEDIA_MOUNTED) + "\n";
140+
+ Environment.getExternalStorageState().equals(Environment.MEDIA_MOUNTED) + "\n"
141+
+ "Export External Public Storage Directory: '"
142+
+ baseExportDirectory + "'\n";
135143
}
136144

137145
}

app/src/main/java/net/osmtracker/db/DataHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ public static File getTrackDirectory(long trackId, Context context) {
396396
File _return = null;
397397

398398
String trackStorageDirectory = context.getExternalFilesDir(null)
399-
+ "/osmtracker/track" + trackId;
399+
+ OSMTracker.Preferences.VAL_STORAGE_DIR + File.separator + "track" + trackId;
400400

401401
_return = new File(trackStorageDirectory);
402402
return _return;

app/src/main/java/net/osmtracker/gpx/ExportToStorageTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public File getBaseExportDirectory(SharedPreferences prefs) throws ExportTrackEx
9797
OSMTracker.Preferences.KEY_STORAGE_DIR, OSMTracker.Preferences.VAL_STORAGE_DIR);
9898
Log.d(TAG,"exportDirectoryNameInPreferences: " + exportDirectoryNameInPreferences);
9999

100-
File baseExportDirectory = new File(context.getExternalFilesDir(null),
100+
File baseExportDirectory = new File(Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOCUMENTS),
101101
exportDirectoryNameInPreferences);
102102

103103
if(! baseExportDirectory.exists()){

0 commit comments

Comments
 (0)