Skip to content

Commit 11d5d22

Browse files
committed
util/helper: fix process output getting truncated
A process that logs a lot of data before exiting could have its output truncated because ProcessWrapper used to stop reading the pipe once the process exits, but instead should always read to the end of the pipe. Signed-off-by: Zachary Deibert <Zachary.Deibert@garmin.com>
1 parent be8f3a2 commit 11d5d22

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

labgrid/util/helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def check_output(self, command, *, print_on_silent_log=False, input=None, stdin=
124124
stdin_w = None
125125

126126
process.poll()
127-
if process.returncode is not None:
127+
if process.returncode is not None and len(ready_r) == 0:
128128
break
129129

130130
if stdin_w is not None:

0 commit comments

Comments
 (0)