Skip to content

Commit a7e525e

Browse files
committed
[review] apply suggestions from JUMO-GmbH-Co-KG#4
Signed-off-by: Raffael Krakau <[email protected]>
1 parent ee362f3 commit a7e525e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

labgrid/driver/power/phoenix_fl_switch.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
PORT = 23
1212

1313

14-
def login_telnet(tn):
14+
def __login_telnet(tn):
1515
"""
1616
Login user with set credentials
1717
1818
@param tn : pyexpect-telnet-object
19-
@returns : logged in pyexpect-telnet-object
2019
"""
2120
username = "admin"
2221
password = "private"
@@ -40,7 +39,7 @@ def power_set(host, port, index: int, value: bool):
4039

4140
with pexpect.spawn(f"telnet {host} {port}", timeout=1) as tn:
4241
# login user with password
43-
login_telnet(tn)
42+
__login_telnet(tn)
4443

4544
# set value
4645
tn.send(bytes(f'pse port {index} power {action}\r\n', 'utf-8'))
@@ -62,7 +61,7 @@ def power_get(host, port, index: int) -> bool:
6261

6362
with pexpect.spawn(f"telnet {host} {port}", timeout=1) as tn:
6463
# login user with password
65-
login_telnet(tn)
64+
__login_telnet(tn)
6665

6766
# get value
6867
tn.send(bytes(f'show pse port port-no {index}\r\n', "utf-8"))

0 commit comments

Comments
 (0)