Skip to content

Commit 18d3fe9

Browse files
committed
feat(FR-2834): use Visibility row label with Public/Private tag for deployment OpenToPublic (#7287)
Resolves #7286 ([FR-2834](https://lablup.atlassian.net/browse/FR-2834)) ## Summary - Change the deployment overview row for endpoint accessibility from `OpenToPublic` (label "Public") to `Visibility` so the tag value reads naturally alongside the label. - `BooleanTag` now uses `t('deployment.Public')` / `t('deployment.Private')` for its true/false labels (cloud-provider standard convention) instead of the previous Yes/No, which read awkwardly inside a Tag. - Add `deployment.Visibility` and `deployment.Private` i18n keys across all 22 supported languages. ## Test plan - [ ] Open a deployment detail page; verify the row label shows "Visibility" (or its localized equivalent) instead of "Public". - [ ] Verify the BooleanTag value reads "Public" (green) when `openToPublic` is true and "Private" (subdued) when false. - [ ] Verify `-` fallback renders while the deployment is loading. - [ ] Spot-check at least Korean, Japanese, and one Latin-script locale to confirm both new keys are translated. [FR-2834]: https://lablup.atlassian.net/browse/FR-2834?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent ff9b535 commit 18d3fe9

22 files changed

Lines changed: 46 additions & 4 deletions

react/src/components/DeploymentConfigurationSection.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ const DeploymentOverviewContent: React.FC<{
101101
),
102102
},
103103
{
104-
key: 'open-to-public',
105-
label: t('deployment.OpenToPublic'),
104+
key: 'visibility',
105+
label: t('deployment.Visibility'),
106106
children: (
107107
<BooleanTag
108108
value={deployment?.networkAccess.openToPublic}
109-
trueLabel={t('button.Yes')}
110-
falseLabel={t('button.No')}
109+
trueLabel={t('deployment.Public')}
110+
falseLabel={t('deployment.Private')}
111111
fallback={renderFallback()}
112112
/>
113113
),

resources/i18n/de.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Öffentlich",
965965
"Overview": "Übersicht",
966966
"Owner": "Eigentümer",
967+
"Private": "Privat",
967968
"Project": "Projekt",
968969
"Public": "Öffentlich",
969970
"QuickDeploy": "Bereitstellen",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Bereitstellung aktualisieren",
998999
"UpdatedAt": "Aktualisiert am",
9991000
"ViewRevision": "Revision anzeigen",
1001+
"Visibility": "Sichtbarkeit",
10001002
"accessToken": {
10011003
"Create": "Zugriffstoken erstellen",
10021004
"Created": "Zugriffstoken wurde erstellt.",

resources/i18n/el.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Δημόσιο",
965965
"Overview": "Επισκόπηση",
966966
"Owner": "Ιδιοκτήτης",
967+
"Private": "Ιδιωτικό",
967968
"Project": "Έργο",
968969
"Public": "Δημόσιο",
969970
"QuickDeploy": "Ανάπτυξη",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Ενημέρωση ανάπτυξης",
998999
"UpdatedAt": "Ενημερώθηκε",
9991000
"ViewRevision": "Προβολή Revision",
1001+
"Visibility": "Ορατότητα",
10001002
"accessToken": {
10011003
"Create": "Δημιουργία διακριτικού πρόσβασης",
10021004
"Created": "Το διακριτικό πρόσβασης δημιουργήθηκε.",

resources/i18n/en.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -966,6 +966,7 @@
966966
"OpenToPublic": "Open To Public",
967967
"Overview": "Overview",
968968
"Owner": "Owner",
969+
"Private": "Private",
969970
"Project": "Project",
970971
"Public": "Public",
971972
"QuickDeploy": "Deploy",
@@ -999,6 +1000,7 @@
9991000
"UpdateDeployment": "Update Deployment",
10001001
"UpdatedAt": "Updated At",
10011002
"ViewRevision": "View Revision",
1003+
"Visibility": "Visibility",
10021004
"accessToken": {
10031005
"Create": "Create Access Token",
10041006
"Created": "Access token has been created.",

resources/i18n/es.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Público",
965965
"Overview": "Resumen",
966966
"Owner": "Propietario",
967+
"Private": "Privado",
967968
"Project": "Proyecto",
968969
"Public": "Público",
969970
"QuickDeploy": "Desplegar",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Actualizar despliegue",
998999
"UpdatedAt": "Actualizado el",
9991000
"ViewRevision": "Ver Revision",
1001+
"Visibility": "Visibilidad",
10001002
"accessToken": {
10011003
"Create": "Crear token de acceso",
10021004
"Created": "El token de acceso ha sido creado.",

resources/i18n/fi.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Julkinen",
965965
"Overview": "Yleiskatsaus",
966966
"Owner": "Omistaja",
967+
"Private": "Yksityinen",
967968
"Project": "Projekti",
968969
"Public": "Julkinen",
969970
"QuickDeploy": "Ota käyttöön",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Päivitä käyttöönotto",
998999
"UpdatedAt": "Päivitetty",
9991000
"ViewRevision": "Näytä Revision",
1001+
"Visibility": "Näkyvyys",
10001002
"accessToken": {
10011003
"Create": "Luo pääsytunnus",
10021004
"Created": "Pääsytunnus on luotu.",

resources/i18n/fr.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Public",
965965
"Overview": "Aperçu",
966966
"Owner": "Propriétaire",
967+
"Private": "Privé",
967968
"Project": "Projet",
968969
"Public": "Public",
969970
"QuickDeploy": "Déployer",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Mettre à jour le déploiement",
998999
"UpdatedAt": "Mis à jour le",
9991000
"ViewRevision": "Voir la Revision",
1001+
"Visibility": "Visibilité",
10001002
"accessToken": {
10011003
"Create": "Créer un jeton d'accès",
10021004
"Created": "Le jeton d'accès a été créé.",

resources/i18n/id.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Terbuka untuk Publik",
965965
"Overview": "Ikhtisar",
966966
"Owner": "Pemilik",
967+
"Private": "Privat",
967968
"Project": "Proyek",
968969
"Public": "Publik",
969970
"QuickDeploy": "Terapkan",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Perbarui Penerapan",
998999
"UpdatedAt": "Diperbarui Pada",
9991000
"ViewRevision": "Lihat Revision",
1001+
"Visibility": "Visibilitas",
10001002
"accessToken": {
10011003
"Create": "Buat Token Akses",
10021004
"Created": "Token akses telah dibuat.",

resources/i18n/it.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "Pubblico",
965965
"Overview": "Panoramica",
966966
"Owner": "Proprietario",
967+
"Private": "Privato",
967968
"Project": "Progetto",
968969
"Public": "Pubblico",
969970
"QuickDeploy": "Distribuisci",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "Aggiorna distribuzione",
998999
"UpdatedAt": "Aggiornato il",
9991000
"ViewRevision": "Visualizza Revision",
1001+
"Visibility": "Visibilità",
10001002
"accessToken": {
10011003
"Create": "Crea token di accesso",
10021004
"Created": "Il token di accesso è stato creato.",

resources/i18n/ja.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@
964964
"OpenToPublic": "公開",
965965
"Overview": "概要",
966966
"Owner": "オーナー",
967+
"Private": "非公開",
967968
"Project": "プロジェクト",
968969
"Public": "公開",
969970
"QuickDeploy": "デプロイ",
@@ -997,6 +998,7 @@
997998
"UpdateDeployment": "デプロイを更新",
998999
"UpdatedAt": "更新日時",
9991000
"ViewRevision": "Revision を表示",
1001+
"Visibility": "公開範囲",
10001002
"accessToken": {
10011003
"Create": "アクセストークンを作成",
10021004
"Created": "アクセストークンが作成されました。",

0 commit comments

Comments
 (0)