Commit 1902adc
committed
Resolves #7371 (FR-2825)
## Summary
Standardize **reversible** activate/deactivate (soft-delete/restore) confirmations to use `Popconfirm` across the app, per `.claude/rules/destructive-confirmation.md`. `BAIConfirmModalWithInput` is reserved for irreversible hard-delete in FR-2819; this PR is the reversible-action counterpart.
## Popconfirm copy convention applied here
- **Title** clearly states the action: e.g. `자격증명 비활성화`, `프로젝트 비활성화`, `역할 활성화`, `사용자 비활성화`.
- **Body** shows only the target identifier (resource name, email, access key, revision number) — no verbose `"정말로 X를 비활성화 시키겠습니까?"` sentence.
## Changes
### `BAINameActionCell` actions migrated to `popConfirm`
- `react/src/components/UserCredentialList.tsx` — keypair Activate / Deactivate (`record.user_id` as body).
- `react/src/components/UserManagement.tsx` — user Activate / Deactivate (`record.email` as body).
- `react/src/components/ResourceGroupList.tsx` — resource group Activate / Deactivate (`record.name` as body).
- `react/src/pages/RBACManagementPage.tsx` — role Activate / Deactivate (`role.name` as body).
- `react/src/components/DeploymentRevisionHistoryTab.tsx` — revision Deploy in table row (`#${revisionNumber}` as body).
### `<Popconfirm>` JSX wrappers tightened
- `react/src/components/DeploymentRevisionHistoryTab.tsx` (drawer Deploy button) — body simplified to `#${revisionNumber}`.
- `packages/backend.ai-ui/src/components/fragments/BAIProjectTable.tsx` — body simplified from `"정말로 {{projectName}} 프로젝트를 비활성화 시키겠습니까?"` → `value?.name`.
### i18n cleanup
- Removed unused `comp:BAIProjectTable.AreYouSureToDeactivateProject` (22 locales).
- Removed unused `deployment.DeployConfirm` (22 locales).
## Test plan
- [ ] Open **Users** → row action menu → Deactivate / Activate. Popconfirm title shows the action and body shows the email. Confirming flips the status.
- [ ] Open **Credentials** (Active/Inactive tabs) → row action menu → Deactivate / Activate. Popconfirm title shows the action and body shows the user_id.
- [ ] Open **Resource Groups** → row action menu → Deactivate / Activate. Popconfirm title shows the action and body shows the resource group name.
- [ ] Open **Projects** (BAIProjectTable consumers, e.g. admin Project page) → row Deactivate button. Popconfirm title shows the action and body shows just the project name.
- [ ] Open **RBAC** (`/rbac`) → role row action menu → Deactivate / Activate. Popconfirm title shows the action and body shows the role name.
- [ ] Open a **Deployment** detail → Revisions tab → row action menu → Deploy. Popconfirm shows `#<revisionNumber>` as body. Same flow via the drawer Deploy button.
- [ ] `bash scripts/verify.sh` — Relay / Lint / Format / TypeScript pass for the modified files.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent 0ca1f8b commit 1902adc
27 files changed
Lines changed: 256 additions & 261 deletions
File tree
- packages/backend.ai-ui/src
- components/fragments
- locale
- react/src
- components
- pages
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
| 146 | + | |
152 | 147 | | |
153 | 148 | | |
154 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
221 | 220 | | |
222 | 221 | | |
223 | 222 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
| |||
0 commit comments