feat(FR-2867): add unified memory accelerator UX in Resource Allocation

Author: yomybaby

react/src/components/SessionFormItems/ResourceAllocationFormItems.test.ts

@@ -8,7 +8,30 @@ import {
   ResourcePreset,
 } from '../../hooks/useResourceLimitAndRemaining';
 import { Image } from '../ImageEnvironmentSelectFormItems';
-import { getAllocatablePresetNames } from './ResourceAllocationFormItems';
+import {
+  getAllocatablePresetNames,
+  isUnifiedAcceleratorSlot,
+} from './ResourceAllocationFormItems';
+
+describe('isUnifiedAcceleratorSlot', () => {
+  it('returns true for slot names ending with .unified', () => {
+    expect(isUnifiedAcceleratorSlot('cuda.unified')).toBe(true);
+    expect(isUnifiedAcceleratorSlot('rocm.unified')).toBe(true);
+  });
+
+  it('returns false for discrete accelerator slot names', () => {
+    expect(isUnifiedAcceleratorSlot('cuda.shares')).toBe(false);
+    expect(isUnifiedAcceleratorSlot('cuda.device')).toBe(false);
+    expect(isUnifiedAcceleratorSlot('cuda.mem')).toBe(false);
+    expect(isUnifiedAcceleratorSlot('rocm.device')).toBe(false);
+  });
+
+  it('returns false for nullish or empty input', () => {
+    expect(isUnifiedAcceleratorSlot(undefined)).toBe(false);
+    expect(isUnifiedAcceleratorSlot(null)).toBe(false);
+    expect(isUnifiedAcceleratorSlot('')).toBe(false);
+  });
+});
 
 describe('getAllocatablePresetNames', () => {
   const presets: Array<ResourcePreset> = [

react/src/components/SessionFormItems/ResourceAllocationFormItems.tsx

@@ -62,6 +62,16 @@ export const isMinOversMaxValue = (min: number, max: number) => {
   return min >= max;
 };
 
+/**
+ * Returns true when the given accelerator slot name represents a unified
+ * memory architecture, where the accelerator memory and the host memory
+ * share a single physical pool. Identified by a `.unified` suffix on the
+ * slot name (e.g. `cuda.unified`).
+ */
+export const isUnifiedAcceleratorSlot = (slotName?: string | null): boolean => {
+  return !!slotName && _.endsWith(slotName, '.unified');
+};
+
 export interface ResourceAllocationFormValue {
   resource: {
     cpu: number;
@@ -521,6 +531,24 @@ const ResourceAllocationFormItems: React.FC<
     }
   }, [currentImage, currentAllocationPreset, updateResourceFieldsBasedOnImage]);
 
+  // When the selected accelerator slot has a unified memory architecture
+  // (slot name suffix `.unified`), accelerator memory shares a single
+  // physical pool with host memory. Mirror the `mem` field value into the
+  // accelerator field so the displayed allocation stays in lockstep with
+  // the host memory slider.
+  const currentAcceleratorTypeForSync = currentResourceValue?.acceleratorType;
+  const currentMemForSync = currentResourceValue?.mem;
+  useEffect(() => {
+    if (!isUnifiedAcceleratorSlot(currentAcceleratorTypeForSync)) {
+      return;
+    }
+    const memInG =
+      convertToBinaryUnit(currentMemForSync || '0g', 'g')?.number ?? 0;
+    if (form.getFieldValue(['resource', 'accelerator']) !== memInG) {
+      form.setFieldValue(['resource', 'accelerator'], memInG);
+    }
+  }, [currentAcceleratorTypeForSync, currentMemForSync, form]);
+
   return (
     <>
       <Form.Item
@@ -921,6 +949,10 @@ const ResourceAllocationFormItems: React.FC<
                         currentAcceleratorType as keyof typeof resourceSlots
                       ] === 'unique';
 
+                    const isUnifiedType = isUnifiedAcceleratorSlot(
+                      currentAcceleratorType,
+                    );
+
                     const isSingleCluster =
                       form.getFieldValue('cluster_size') < 2;
                     const hasQuantumSize = _.isNumber(
@@ -965,9 +997,15 @@ const ResourceAllocationFormItems: React.FC<
                             />
                           ),
                         }}
+                        extra={
+                          isUnifiedType
+                            ? t('session.launcher.UnifiedAcceleratorMemoryNote')
+                            : undefined
+                        }
                         dependencies={[
                           ['resource', 'acceleratorType'],
                           'cluster_size',
+                          ['resource', 'mem'],
                         ]}
                         rules={[
                           {
@@ -1139,7 +1177,8 @@ const ResourceAllocationFormItems: React.FC<
                             },
                           }}
                           disabled={
-                            supportedAcceleratorTypesInRGByImage?.length === 0
+                            supportedAcceleratorTypesInRGByImage?.length ===
+                              0 || isUnifiedType
                           }
                           min={0}
                           max={

resources/i18n/en.json

@@ -2882,6 +2882,7 @@
       "TensorBoardPrepared": "TensorBoard app prepared.",
       "TitleSession": "Session (Backend.AI)",
       "TotalAllocation": "Total Allocation",
+      "UnifiedAcceleratorMemoryNote": "Accelerator memory is shared with host memory on this device and cannot be set separately.",
       "UserResourceLimit": "User Resource Limit",
       "UsingBootstrapScriptInfo": "Bootstrap script is included.",
       "Version": "Version",