feat(FR-2719): address Copilot review feedback

- pdf-renderer.ts: fix RenderOptions docstring (uses page, not context),
  move tmpDir creation after browser launch and guard cleanup so a
  failed chromium.launch() cannot leak a temp directory.
- pdf-renderer.ts: extend DEFAULT_CJK_FONT_CANDIDATES with single-face
  paths for Japanese (TakaoGothic) and Thai (Loma.otf, Garuda) so the
  apt-installed fonts in the workflow are actually picked up.
- generate-pdf.ts: normalize args.concurrency through Number.isFinite
  so a NaN input does not silently produce zero workers.
- package.yml: drop job-level continue-on-error so an all-languages
  failure (which generate-pdf.ts surfaces via non-zero exit) still
  fails the job — partial failures continue to degrade gracefully
  inside the script.
- upload-release.js: usage text now mentions PDF as an accepted asset
  type alongside DMG and ZIP.

Author: yomybaby

.github/workflows/package.yml

@@ -217,14 +217,16 @@ jobs:
   # and build_desktop, so a healthy run does not extend the overall wall
   # clock (mac is the current critical path at ~10 min).
   #
-  # `continue-on-error: true` means a PDF failure logs warnings but does
-  # NOT block the release. Tighten this once the pipeline has soaked.
+  # Failure handling is scoped to the PDF build step itself (not the whole
+  # job), so partial per-language failures degrade gracefully but a full
+  # generator failure (all languages failed → generate-pdf.ts exits non-
+  # zero) still fails the job. This prevents shipping a release with zero
+  # PDF assets going unnoticed.
   # ──────────────────────────────────────────────────────────────────────
   build_docs:
     permissions:
       contents: write
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - name: Check out Git repository
         uses: actions/checkout@v5
@@ -261,9 +263,9 @@ jobs:
       # ships only a TTC bundle that pdf-lib/fontkit cannot embed, so we
       # use language-specific single-file packages whose paths are listed
       # in DEFAULT_CJK_FONT_CANDIDATES (pdf-renderer.ts):
-      #   - fonts-nanum     → /usr/share/fonts/truetype/nanum/NanumBarunGothic.ttf  (ko)
-      #   - fonts-takao-gothic → /usr/share/fonts/truetype/takao-gothic/TakaoGothic.ttf (ja)
-      #   - fonts-thai-tlwg → /usr/share/fonts/truetype/tlwg/Loma.ttf  (th)
+      #   - fonts-nanum         → /usr/share/fonts/truetype/nanum/NanumBarunGothic.ttf      (ko)
+      #   - fonts-takao-gothic  → /usr/share/fonts/truetype/takao-gothic/TakaoGothic.ttf    (ja)
+      #   - fonts-thai-tlwg     → /usr/share/fonts/opentype/tlwg/Loma.otf or Garuda.ttf     (th)
       # Languages whose font is missing will be reported as a failure by
       # generate-pdf.ts but will not abort the other language renders.
       - name: Install CJK + Thai fonts (best effort)

packages/backend.ai-docs-toolkit/src/generate-pdf.ts

@@ -96,9 +96,12 @@ export async function generatePdf(
     process.env.BAI_DOCS_PDF_CONCURRENCY ?? '',
     10,
   );
+  const optionConcurrency = Number.isFinite(args.concurrency)
+    ? args.concurrency
+    : undefined;
   const concurrency = Math.max(
     1,
-    args.concurrency ?? (Number.isFinite(envConcurrency) ? envConcurrency : 2),
+    optionConcurrency ?? (Number.isFinite(envConcurrency) ? envConcurrency : 2),
   );
 
   const productName = config.productName;

packages/backend.ai-docs-toolkit/src/pdf-renderer.ts

@@ -19,10 +19,17 @@ const DEFAULT_CJK_FONT_CANDIDATES = [
   path.join(os.homedir(), 'Library/Fonts/NanumBarunGothic.ttf'),
   path.join(os.homedir(), 'Library/Fonts/NanumSquareRegular.ttf'),
   '/System/Library/Fonts/Supplemental/Arial Unicode.ttf',
-  // Linux common paths
+  // Linux common paths — Korean
   '/usr/share/fonts/opentype/noto/NotoSansCJK-Regular.ttc',
   '/usr/share/fonts/truetype/noto/NotoSansKR-Regular.ttf',
   '/usr/share/fonts/truetype/nanum/NanumBarunGothic.ttf',
+  // Linux common paths — Japanese (fonts-takao-gothic on Debian/Ubuntu)
+  '/usr/share/fonts/truetype/takao-gothic/TakaoGothic.ttf',
+  '/usr/share/fonts/truetype/takao-mincho/TakaoMincho.ttf',
+  // Linux common paths — Thai (fonts-thai-tlwg on Debian/Ubuntu)
+  '/usr/share/fonts/truetype/tlwg/Loma.ttf',
+  '/usr/share/fonts/opentype/tlwg/Loma.otf',
+  '/usr/share/fonts/truetype/tlwg/Garuda.ttf',
 ];
 
 type EmbeddedFont = Awaited<ReturnType<PDFDocument['embedFont']>>;
@@ -63,9 +70,9 @@ export interface RenderOptions {
   config?: ResolvedDocConfig;
   /**
    * Optional shared Chromium instance. When provided, renderPdf reuses it
-   * (via newContext/newPage) and the caller owns its lifecycle. This avoids
-   * paying the per-call launch cost when generating multiple PDFs in one run
-   * (e.g. one PDF per language during release builds).
+   * by opening a new page on the existing browser, and the caller owns its
+   * lifecycle. This avoids paying the per-call launch cost when generating
+   * multiple PDFs in one run (e.g. one PDF per language during release builds).
    */
   browser?: Browser;
 }
@@ -389,17 +396,22 @@ export async function renderPdf(options: RenderOptions): Promise<void> {
 
   fs.mkdirSync(path.dirname(options.outputPath), { recursive: true });
 
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bai-docs-'));
-  const tmpHtmlPath = path.join(tmpDir, 'document.html');
-  fs.writeFileSync(tmpHtmlPath, options.html, 'utf-8');
-
   const ownsBrowser = !options.browser;
   const browser = options.browser ?? (await chromium.launch());
+
+  // tmpDir is created after the browser is ready so a chromium.launch()
+  // failure cannot leave an orphaned temp directory behind. Use an outer
+  // try/finally so a failure between mkdtempSync and the inner try also
+  // cleans up the browser when we own it.
+  let tmpDir: string | undefined;
   let pdfBuffer: Buffer;
   let chapterInfoList: ChapterInfo[] = [];
   let sectionList: SectionInfo[] = [];
   let page: Awaited<ReturnType<Browser['newPage']>> | undefined;
   try {
+    tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bai-docs-'));
+    const tmpHtmlPath = path.join(tmpDir, 'document.html');
+    fs.writeFileSync(tmpHtmlPath, options.html, 'utf-8');
     page = await browser.newPage({
       viewport: { width: PRINT_WIDTH_PX, height: 800 },
     });
@@ -494,7 +506,9 @@ export async function renderPdf(options: RenderOptions): Promise<void> {
     if (ownsBrowser) {
       await browser.close();
     }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
+    if (tmpDir) {
+      fs.rmSync(tmpDir, { recursive: true, force: true });
+    }
   }
 
   // ── Post-processing ──────────────────────────────────────────

upload-release.js

@@ -47,7 +47,7 @@ const getUploadURL = async (releaseId) => {
 
 const main = async () => {
     if (process.argv.length !== 3) {
-        console.error('usage: node upload-release.js <folder containing DMG/ZIP files>')
+        console.error('usage: node upload-release.js <folder containing DMG/ZIP/PDF files>')
         process.exit(1)
     }
     const folder = process.argv[2]