Skip to content

Commit 459ade2

Browse files
agatha197claude
andcommitted
fix(docs-toolkit): restore sidebar scrolling in preview:html output
FR-2768 made .doc-sidebar a fixed-height, overflow:hidden flex column and delegated scrolling to an inner .doc-sidebar__scroll element in styles-web.ts. website-builder.ts (build:web / serve:web) emits that wrapper, but the legacy single-page preview builder (html-builder-web.ts, used by preview:html / preview:html:ko) was never updated, so the nav overflowed a clipped container with no scrollport and the sidebar could not scroll. Wrap the nav list in .doc-sidebar__scroll to mirror website-builder.ts, restoring sidebar scrolling in the HTML preview server. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 3dfd501 commit 459ade2

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

packages/backend.ai-docs-toolkit/src/html-builder-web.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,24 @@ function buildSidebarHtml(
4444
})
4545
.join('\n');
4646

47+
// FR-2768 made .doc-sidebar a fixed-height, overflow:hidden flex column
48+
// and delegated scrolling to an inner .doc-sidebar__scroll element (see
49+
// styles-web.ts). website-builder.ts emits that wrapper; this legacy
50+
// single-page preview builder must too, otherwise the nav overflows a
51+
// clipped container with no scrollport and the sidebar can't scroll.
52+
// .doc-sidebar-header is display:none in Phase 2, so leaving it outside
53+
// the scrollport mirrors the pinned version block in website-builder.ts.
4754
return `
4855
<aside class="doc-sidebar">
4956
<div class="doc-sidebar-header">
5057
<h2>${metadata.title}</h2>
5158
<div class="doc-meta">${metadata.version} &middot; ${langLabel}</div>
5259
</div>
53-
<ul class="doc-sidebar-nav">
54-
${navItems}
55-
</ul>
60+
<div class="doc-sidebar__scroll">
61+
<ul class="doc-sidebar-nav">
62+
${navItems}
63+
</ul>
64+
</div>
5665
</aside>`;
5766
}
5867

0 commit comments

Comments
 (0)