Skip to content

Commit 492b168

Browse files
committed
chore(FR-2866): disable gitBranchLockfile and retire weekly merge workflow
1 parent b4004d6 commit 492b168

3 files changed

Lines changed: 10 additions & 96 deletions

File tree

.claude/commands/bump-alpha-version.md

Lines changed: 10 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -91,40 +91,14 @@ Update dependencies in the following package.json files within semver-compatible
9191

9292
Run `pnpm install` to update the lockfile with new dependency versions.
9393

94-
### 6. Merge pnpm Branch Lockfiles
94+
### 6. Verify Changes and Fix TypeScript Errors
9595

96-
This repository uses pnpm's `gitBranchLockfile` feature (see `pnpm-workspace.yaml`: `gitBranchLockfile: true` with `mergeGitBranchLockfilesBranchPattern: - main`). Feature branches accumulate per-branch lockfiles (`pnpm-lock.<branch-name>.yaml`) that must be periodically merged back into the main `pnpm-lock.yaml` so trunk stays consistent.
97-
98-
Run:
99-
100-
```bash
101-
pnpm install --merge-git-branch-lockfiles
102-
```
103-
104-
This command:
105-
106-
- Reads all `pnpm-lock.*.yaml` files at the repo root
107-
- Merges their resolutions into the main `pnpm-lock.yaml`
108-
- Deletes the per-branch lockfiles
109-
110-
After running, verify:
111-
112-
```bash
113-
ls pnpm-lock*.yaml # should show only pnpm-lock.yaml
114-
git status # confirm any removed branch lockfiles are staged for deletion
115-
```
116-
117-
If there are no branch lockfiles present, this step is effectively a no-op and the main lockfile is left unchanged — still run the command to be safe.
118-
119-
### 7. Verify Changes and Fix TypeScript Errors
120-
121-
After updating dependencies and merging branch lockfiles, verify everything works correctly:
96+
After updating dependencies, verify everything works correctly:
12297

12398
1. **Run `pnpm install`** to ensure no errors in dependency resolution
12499
2. **Check all package.json files** have the correct version
125-
3. **Confirm `pnpm-lock.*.yaml` branch lockfiles are gone** (only `pnpm-lock.yaml` should remain)
126-
4. **Note any peer dependency warnings**
127-
5. **Run TypeScript type checking** to detect any type errors caused by updated packages:
100+
3. **Note any peer dependency warnings**
101+
4. **Run TypeScript type checking** to detect any type errors caused by updated packages:
128102

129103
```bash
130104
# Check TypeScript errors in react package
@@ -138,15 +112,15 @@ pnpm --prefix ./react exec tsc --noEmit
138112
pnpm --prefix ./packages/backend.ai-ui exec tsc --noEmit
139113
```
140114

141-
6. **If TypeScript errors occur**, fix them before proceeding:
115+
5. **If TypeScript errors occur**, fix them before proceeding:
142116
- Review the error messages to identify which updated packages caused the issue
143117
- Common fixes include:
144118
- Updating type definitions (`@types/*` packages)
145119
- Adjusting code to match new API signatures
146120
- Adding type assertions where needed
147121
- Fix all errors before completing the version bump
148122

149-
7. **Run build to ensure everything compiles**:
123+
6. **Run build to ensure everything compiles**:
150124

151125
```bash
152126
pnpm run build
@@ -172,9 +146,6 @@ pnpm update --ignore-engines
172146

173147
# Install to update lockfile
174148
pnpm install
175-
176-
# Merge per-branch lockfiles back into pnpm-lock.yaml
177-
pnpm install --merge-git-branch-lockfiles
178149
```
179150

180151
## Output Summary
@@ -184,9 +155,8 @@ After completion, provide a summary including:
184155
1. **Version Update**: Old version -> New version
185156
2. **Files Updated**: List of files modified by `make versiontag`
186157
3. **Dependencies Updated**: Summary of updated packages with version changes
187-
4. **Branch Lockfiles Merged**: List of `pnpm-lock.*.yaml` files removed (empty if none existed)
188-
5. **Peer Dependency Warnings**: Any warnings encountered
189-
6. **Next Steps**: Suggest committing changes if everything looks good
158+
4. **Peer Dependency Warnings**: Any warnings encountered
159+
5. **Next Steps**: Suggest committing changes if everything looks good
190160

191161
## Example Workflow
192162

@@ -198,9 +168,8 @@ Claude:
198168
2. Runs make versiontag
199169
3. Updates dependencies in react/ and packages/backend.ai-ui/
200170
4. Runs pnpm install
201-
5. Runs pnpm install --merge-git-branch-lockfiles to fold stale branch lockfiles into pnpm-lock.yaml
202-
6. Runs typecheck + build
203-
7. Provides summary of all changes
171+
5. Runs typecheck + build
172+
6. Provides summary of all changes
204173
```
205174

206175
## Notes

.github/workflows/weekly-merge-branch-lockfiles.yml

Lines changed: 0 additions & 53 deletions
This file was deleted.

pnpm-workspace.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ catalog:
6767
uuid: ^13.0.0
6868
webpack: ^5.106.1
6969

70-
gitBranchLockfile: true
71-
7270
minimumReleaseAge: 10080
7371

7472
# Exclude packages that must be installable before they age out of the

0 commit comments

Comments
 (0)