Skip to content

Commit 4e858ab

Browse files
agatha197yomybaby
authored andcommitted
fix(FR-2836): remove unused revision name field from Add Revision modal
1 parent 316c42a commit 4e858ab

28 files changed

Lines changed: 18 additions & 69 deletions

react/src/components/DeploymentAddRevisionModal.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ interface DeploymentAddRevisionModalProps extends BAIModalProps {
116116
type FormValues = ImageEnvironmentFormInput &
117117
ResourceAllocationFormValue &
118118
VFolderTableFormValues & {
119-
name?: string;
120119
runtimeVariantId: string;
121120
modelFolderId: string;
122121
mountDestination: string;
@@ -294,7 +293,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
294293
addModelRevision(input: $input) {
295294
revision {
296295
id
297-
name
298296
clusterConfig {
299297
mode
300298
size
@@ -783,7 +781,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
783781
variables: {
784782
input: {
785783
deploymentId: toLocalId(deploymentId) ?? deploymentId,
786-
name: values.name || undefined,
787784
clusterConfig: {
788785
mode: clusterMode,
789786
size: values.cluster_size,
@@ -902,9 +899,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
902899
autoActivate: true,
903900
})}
904901
>
905-
<Form.Item name="name" label={t('deployment.RevisionName')}>
906-
<Input placeholder={t('deployment.RevisionNamePlaceholder')} />
907-
</Form.Item>
908902
<Form.Item name="autoActivate" valuePropName="checked">
909903
<Checkbox>{t('deployment.AutoActivate')}</Checkbox>
910904
</Form.Item>

react/src/components/DeploymentConfigurationSection.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,12 +202,10 @@ const DeploymentConfigurationSection: React.FC<
202202
}
203203
currentRevision @since(version: "26.4.3") {
204204
id
205-
name
206205
...DeploymentRevisionDetail_revision
207206
}
208207
deployingRevision @since(version: "26.4.3") {
209208
id
210-
name
211209
...DeploymentRevisionDetail_revision
212210
}
213211
...DeploymentRevisionHistoryTab_deployment
@@ -378,7 +376,7 @@ const DeploymentConfigurationSection: React.FC<
378376
icon={<LoadingOutlined spin />}
379377
showIcon
380378
title={t('deployment.DeployingRevisionApplying', {
381-
name: deployingRevision.name ?? '',
379+
name: toLocalId(deployingRevision.id) ?? '',
382380
})}
383381
action={
384382
<Button

react/src/components/DeploymentReplicasTab.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
BAIUnmountAfterClose,
2424
type GraphQLFilter,
2525
filterOutEmpty,
26+
toLocalId,
2627
} from 'backend.ai-ui';
2728
import dayjs from 'dayjs';
2829
import * as _ from 'lodash-es';
@@ -175,7 +176,6 @@ const DeploymentReplicasTab: React.FC<DeploymentReplicasTabProps> = ({
175176
createdAt
176177
revision {
177178
id
178-
name
179179
}
180180
}
181181
}
@@ -288,7 +288,9 @@ const DeploymentReplicasTab: React.FC<DeploymentReplicasTabProps> = ({
288288
key: 'revision',
289289
title: t('deployment.Revision'),
290290
render: (_: unknown, record: ReplicaNode) =>
291-
record.revision?.name ?? (
291+
record.revision?.id ? (
292+
toLocalId(record.revision.id)
293+
) : (
292294
<Typography.Text type="secondary"></Typography.Text>
293295
),
294296
},

react/src/components/DeploymentRevisionDetail.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const DeploymentRevisionDetail: React.FC<{
4040
graphql`
4141
fragment DeploymentRevisionDetail_revision on ModelRevision {
4242
id
43-
name
4443
createdAt
4544
clusterConfig {
4645
mode
@@ -132,9 +131,9 @@ const DeploymentRevisionDetail: React.FC<{
132131
{
133132
key: 'revision-name',
134133
label: t('modelService.RevisionID'),
135-
children: revision.name ? (
134+
children: revision.id ? (
136135
<BAIFlex gap="xs" align="center">
137-
<Typography.Text>{revision.name}</Typography.Text>
136+
<Typography.Text>{toLocalId(revision.id)}</Typography.Text>
138137
{status === 'current' && (
139138
<BAITag color="success">{t('deployment.Current')}</BAITag>
140139
)}

react/src/components/DeploymentRevisionHistoryTab.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ const DeploymentRevisionHistoryTab: React.FC<
195195
edges {
196196
node {
197197
id
198-
name
199198
createdAt
199+
200200
clusterConfig {
201201
mode
202202
size
@@ -245,7 +245,6 @@ const DeploymentRevisionHistoryTab: React.FC<
245245
currentRevisionId
246246
currentRevision {
247247
id
248-
name
249248
}
250249
}
251250
previousRevisionId
@@ -278,10 +277,7 @@ const DeploymentRevisionHistoryTab: React.FC<
278277
};
279278

280279
const handleRollback = (revision: RevisionNode): Promise<boolean> => {
281-
// The `name` field is the human-readable revision number label
282-
// ("#3"). Fall back to the trimmed UUID if absent so the confirm
283-
// text is never blank.
284-
const revisionLabel = revision.name ?? toLocalId(revision.id);
280+
const revisionLabel = toLocalId(revision.id);
285281
return new Promise<boolean>((resolveOuter) => {
286282
modal.confirm({
287283
title: t('deployment.Deploy'),
@@ -382,7 +378,7 @@ const DeploymentRevisionHistoryTab: React.FC<
382378
})
383379
}
384380
>
385-
{record.name ?? '-'}
381+
{recordLocalId ?? '-'}
386382
</Typography.Link>
387383
{isCurrent ? (
388384
<BAITag color="success">{t('deployment.Current')}</BAITag>

react/src/components/ServiceLauncherPageContent.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,6 @@ const ServiceLauncherPageContent: React.FC<ServiceLauncherPageContentProps> = ({
14051405
) {
14061406
edges {
14071407
node {
1408-
name
14091408
modelDefinition {
14101409
models {
14111410
service {

react/src/pages/EndpointDetailPage.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ import {
8181
GraphQLFilter,
8282
SemanticColor,
8383
toGlobalId,
84+
toLocalId,
8485
useFetchKey,
8586
useSemanticColorMap,
8687
BAITable,
@@ -365,7 +366,6 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
365366
}
366367
currentRevision {
367368
id
368-
name
369369
modelDefinition {
370370
models {
371371
name
@@ -389,7 +389,6 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
389389
edges {
390390
node {
391391
id
392-
name
393392
modelDefinition {
394393
models {
395394
name
@@ -807,9 +806,13 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
807806
const latestRevisionItems = buildModelDefinitionItems(
808807
modelDeployment?.revisionHistory?.edges?.[0]?.node?.modelDefinition?.models,
809808
);
810-
const currentRevisionName = modelDeployment?.currentRevision?.name;
811-
const latestRevisionName =
812-
modelDeployment?.revisionHistory?.edges?.[0]?.node?.name;
809+
const currentRevisionName = modelDeployment?.currentRevision?.id
810+
? toLocalId(modelDeployment.currentRevision.id)
811+
: undefined;
812+
const latestRevisionName = modelDeployment?.revisionHistory?.edges?.[0]?.node
813+
?.id
814+
? toLocalId(modelDeployment.revisionHistory.edges[0].node.id)
815+
: undefined;
813816
const isRevisionMismatch =
814817
modelDeployment?.currentRevision?.id != null &&
815818
modelDeployment?.revisionHistory?.edges?.[0]?.node?.id != null &&

resources/i18n/de.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -986,8 +986,6 @@
986986
"RevisionHistory": "Revisionsverlauf",
987987
"RevisionId": "Revisions-ID",
988988
"RevisionIdPlaceholder": "Revisions-ID eingeben (optional)",
989-
"RevisionName": "Revisionsname",
990-
"RevisionNamePlaceholder": "Leer lassen für automatische Generierung",
991989
"RevisionNumber": "Revisionsnummer",
992990
"Revisions": "Revisionen",
993991
"Running": "Läuft",

resources/i18n/el.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -986,8 +986,6 @@
986986
"RevisionHistory": "Ιστορικό Revision",
987987
"RevisionId": "ID Revision",
988988
"RevisionIdPlaceholder": "Εισάγετε ID Revision (προαιρετικό)",
989-
"RevisionName": "Όνομα Revision",
990-
"RevisionNamePlaceholder": "Αφήστε κενό για αυτόματη δημιουργία",
991989
"RevisionNumber": "Αριθμός Αναθεώρησης",
992990
"Revisions": "Revision",
993991
"Running": "Σε εκτέλεση",

resources/i18n/en.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -988,8 +988,6 @@
988988
"RevisionHistory": "Revision History",
989989
"RevisionId": "Revision ID",
990990
"RevisionIdPlaceholder": "Leave blank to auto-generate",
991-
"RevisionName": "Revision Name",
992-
"RevisionNamePlaceholder": "Leave blank to auto-generate",
993991
"RevisionNumber": "Revision Number",
994992
"Revisions": "Revisions",
995993
"Running": "Running",

0 commit comments

Comments
 (0)