Skip to content

Commit 73e58ea

Browse files
committed
feat(FR-2835): add auto-activate option to Add Revision modal
1 parent 1154189 commit 73e58ea

23 files changed

Lines changed: 31 additions & 4 deletions

data/schema.graphql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9571,9 +9571,6 @@ type ModelRevision implements Node
95719571
id: ID!
95729572
imageId: ID!
95739573

9574-
"""The name identifier for this revision."""
9575-
name: String!
9576-
95779574
"""Cluster configuration for replica distribution."""
95789575
clusterConfig: ClusterConfig!
95799576

@@ -14470,6 +14467,9 @@ enum RBACElementType
1447014467
DEPLOYMENT_REVISION @join__enumValue(graph: STRAWBERRY)
1447114468
IMAGE_ALIAS @join__enumValue(graph: STRAWBERRY)
1447214469
ROLE_ASSIGNMENT @join__enumValue(graph: STRAWBERRY)
14470+
VFOLDER_DATA @join__enumValue(graph: STRAWBERRY)
14471+
SESSION_APP_SERVICE @join__enumValue(graph: STRAWBERRY)
14472+
USER_EMAIL @join__enumValue(graph: STRAWBERRY)
1447314473
ARTIFACT_REVISION @join__enumValue(graph: STRAWBERRY)
1447414474
}
1447514475

react/src/components/DeploymentAddRevisionModal.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import VFolderTableFormItem, {
3939
} from './VFolderTableFormItem';
4040
import {
4141
App,
42+
Checkbox,
4243
Collapse,
4344
Divider,
4445
Form,
@@ -128,6 +129,7 @@ type FormValues = ImageEnvironmentFormInput &
128129
commandInitialDelay?: number;
129130
commandMaxRetries?: number;
130131
environ: EnvVarFormListValue[];
132+
autoActivate: boolean;
131133
};
132134

133135
interface DeploymentAddRevisionModalFormBodyProps {
@@ -809,7 +811,7 @@ const DeploymentAddRevisionModalFormBody: React.FC<
809811
},
810812
modelDefinition,
811813
extraMounts: extraMounts.length > 0 ? extraMounts : null,
812-
options: { autoActivate: true },
814+
options: { autoActivate: values.autoActivate },
813815
},
814816
},
815817
onCompleted: (_, errors) => {
@@ -897,11 +899,15 @@ const DeploymentAddRevisionModalFormBody: React.FC<
897899
commandInitialDelay: 60,
898900
commandMaxRetries: 10,
899901
environ: [],
902+
autoActivate: true,
900903
})}
901904
>
902905
<Form.Item name="name" label={t('deployment.RevisionName')}>
903906
<Input placeholder={t('deployment.RevisionNamePlaceholder')} />
904907
</Form.Item>
908+
<Form.Item name="autoActivate" valuePropName="checked">
909+
<Checkbox>{t('deployment.AutoActivate')}</Checkbox>
910+
</Form.Item>
905911

906912
<SectionHeader>{t('deployment.step.ModelAndRuntime')}</SectionHeader>
907913
<Form.Item

resources/i18n/de.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Revision hinzufügen",
896896
"AdditionalMounts": "Zusätzliche Einhängepunkte",
897897
"AnotherDeploymentInProgress": "Ein weiteres Deployment-Update wird bereits durchgeführt. Bitte warten Sie, bis es abgeschlossen ist, bevor Sie es erneut versuchen.",
898+
"AutoActivate": "Nach dem Hinzufügen automatisch aktivieren",
898899
"AutoScaling": "Automatische Skalierung",
899900
"AutoScalingRules": "Regeln für automatische Skalierung",
900901
"BasicInformation": "Grundlegende Informationen",

resources/i18n/el.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Προσθήκη Revision",
896896
"AdditionalMounts": "Πρόσθετες Προσαρτήσεις",
897897
"AnotherDeploymentInProgress": "Μια άλλη ενημέρωση ανάπτυξης βρίσκεται ήδη σε εξέλιξη. Παρακαλούμε περιμένετε να ολοκληρωθεί πριν προσπαθήσετε ξανά.",
898+
"AutoActivate": "Αυτόματη ενεργοποίηση μετά την προσθήκη",
898899
"AutoScaling": "Αυτόματη κλιμάκωση",
899900
"AutoScalingRules": "Κανόνες αυτόματης κλιμάκωσης",
900901
"BasicInformation": "Βασικές πληροφορίες",

resources/i18n/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -896,6 +896,7 @@
896896
"AddRevision": "Add Revision",
897897
"AdditionalMounts": "Additional Mounts",
898898
"AnotherDeploymentInProgress": "Another deployment update is already in progress. Please wait for it to complete before trying again.",
899+
"AutoActivate": "Auto-activate after adding",
899900
"AutoScaling": "Auto-scaling",
900901
"AutoScalingRules": "Auto-scaling Rules",
901902
"BasicInformation": "Basic Information",

resources/i18n/es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Agregar Revisión",
896896
"AdditionalMounts": "Montajes adicionales",
897897
"AnotherDeploymentInProgress": "Ya hay otra actualización de despliegue en curso. Por favor, espere a que se complete antes de intentarlo de nuevo.",
898+
"AutoActivate": "Activar automáticamente después de agregar",
898899
"AutoScaling": "Escalado automático",
899900
"AutoScalingRules": "Reglas de escalado automático",
900901
"BasicInformation": "Información básica",

resources/i18n/fi.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Lisää Revision",
896896
"AdditionalMounts": "Lisäliitokset",
897897
"AnotherDeploymentInProgress": "Toinen käyttöönoton päivitys on jo käynnissä. Odota sen valmistumista ennen kuin yrität uudelleen.",
898+
"AutoActivate": "Aktivoi automaattisesti lisäyksen jälkeen",
898899
"AutoScaling": "Automaattinen skaalaus",
899900
"AutoScalingRules": "Automaattisen skaalauksen säännöt",
900901
"BasicInformation": "Perustiedot",

resources/i18n/fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Ajouter une Revision",
896896
"AdditionalMounts": "Montages supplémentaires",
897897
"AnotherDeploymentInProgress": "Une autre mise à jour de déploiement est déjà en cours. Veuillez attendre qu'elle se termine avant de réessayer.",
898+
"AutoActivate": "Activer automatiquement après ajout",
898899
"AutoScaling": "Mise à l'échelle automatique",
899900
"AutoScalingRules": "Règles de mise à l'échelle automatique",
900901
"BasicInformation": "Informations de base",

resources/i18n/id.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Tambah Revision",
896896
"AdditionalMounts": "Pemasangan Tambahan",
897897
"AnotherDeploymentInProgress": "Pembaruan deployment lain sedang berlangsung. Harap tunggu hingga selesai sebelum mencoba lagi.",
898+
"AutoActivate": "Aktifkan otomatis setelah menambahkan",
898899
"AutoScaling": "Skala Otomatis",
899900
"AutoScalingRules": "Aturan Skala Otomatis",
900901
"BasicInformation": "Informasi Dasar",

resources/i18n/it.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@
895895
"AddRevision": "Aggiungi Revision",
896896
"AdditionalMounts": "Montaggio aggiuntivo",
897897
"AnotherDeploymentInProgress": "Un altro aggiornamento del deployment è già in corso. Attendere il completamento prima di riprovare.",
898+
"AutoActivate": "Attiva automaticamente dopo l'aggiunta",
898899
"AutoScaling": "Scalabilità automatica",
899900
"AutoScalingRules": "Regole di scalabilità automatica",
900901
"BasicInformation": "Informazioni di base",

0 commit comments

Comments
 (0)