Skip to content

Commit 7992da5

Browse files
committed
ci(FR-2861): drop pnpm/action-setup version: 11 (use packageManager field) (#7345)
Resolves #7344(FR-2861) ## Summary Since the pnpm v11 migration ([FR-2840 / #7307](#7307)), the root `package.json` declares `"packageManager": "pnpm@11.1.0"`. Several GitHub Actions workflows still pass `version: 11` to `pnpm/action-setup@v5`, which fails on every PR with: ``` Error: Multiple versions of pnpm specified: - version 11 in the GitHub Action config with the key "version" - version pnpm@11.1.0 in the package.json with the key "packageManager" Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION ``` Example failure: https://github.com/lablup/backend.ai-webui/actions/runs/25669252851/job/75349895261 This blocks `react-vitest` (and the publish / package / weekly-merge / e2e-watchdog / e2e-healer jobs) for every open PR. ## Fix Drop the `version: 11` input from all `pnpm/action-setup@v5` calls. With `packageManager` set, pnpm/action-setup uses it as the single source of truth. For two `.lock.yml` steps where `version: 11` was the only `with:` input, also drop the now-empty `with:` mapping (which GitHub Actions rejects). Also bump the pinned pnpm version from `11.0.8` to `11.1.0` (current npm `latest`) so the field reflects the latest patch. Verified via `corepack prepare pnpm@11.1.0 --activate` + `pnpm install --frozen-lockfile` (lockfile compatible — no migration). ## Changes - `.github/workflows/vitest.yml` (3 occurrences — the active PR blocker) - `.github/workflows/publish-backend.ai-ui.yml` - `.github/workflows/publish-backend.ai-docs-toolkit.yml` - `.github/workflows/package.yml` (4) - `.github/workflows/weekly-merge-branch-lockfiles.yml` - `.github/workflows/e2e-healer.lock.yml` (also drop empty `with:`) - `.github/workflows/e2e-watchdog.lock.yml` (also drop empty `with:`) - `.github/actions/daily-test-improver/coverage-steps/action.yml` (composite action, surfaced by Copilot) - `package.json` — bump `packageManager` to `pnpm@11.1.0` - `amplify.yml` — sync the pinned-version comment `e2e-watchdog.md` / `e2e-healer.md` are documentation, not active workflows — left untouched. ## Verification - The pnpm/action-setup error will not reproduce against this PR's CI. - Existing tests run as before (no change to install command, just the action input). - `pnpm install --frozen-lockfile` with `pnpm@11.1.0` reports `Already up to date` — lockfile remains valid.
1 parent 4ff04e7 commit 7992da5

10 files changed

Lines changed: 2 additions & 17 deletions

File tree

.github/actions/daily-test-improver/coverage-steps/action.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ runs:
88
- name: Install pnpm
99
uses: pnpm/action-setup@v5
1010
with:
11-
version: 11
1211
run_install: false
1312

1413
- name: Setup Node.js

.github/workflows/e2e-healer.lock.yml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/e2e-watchdog.lock.yml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/package.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ jobs:
4545
- uses: pnpm/action-setup@v5
4646
name: Install pnpm
4747
with:
48-
version: 11
4948
run_install: false
5049

5150
- name: Install Node.js
@@ -100,7 +99,6 @@ jobs:
10099
- uses: pnpm/action-setup@v5
101100
name: Install pnpm
102101
with:
103-
version: 11
104102
run_install: false
105103

106104
- name: Install Node.js
@@ -168,7 +166,6 @@ jobs:
168166
- uses: pnpm/action-setup@v5
169167
name: Install pnpm
170168
with:
171-
version: 11
172169
run_install: false
173170

174171
- name: Install Node.js
@@ -234,7 +231,6 @@ jobs:
234231
- uses: pnpm/action-setup@v5
235232
name: Install pnpm
236233
with:
237-
version: 11
238234
run_install: false
239235

240236
- name: Install Node.js

.github/workflows/publish-backend.ai-docs-toolkit.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
- uses: pnpm/action-setup@v5
2222
name: Install pnpm
2323
with:
24-
version: 11
2524
run_install: false
2625
- name: Install Node.js
2726
uses: actions/setup-node@v5

.github/workflows/publish-backend.ai-ui.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
- uses: pnpm/action-setup@v5
2222
name: Install pnpm
2323
with:
24-
version: 11
2524
run_install: false
2625
- name: Install Node.js
2726
uses: actions/setup-node@v5

.github/workflows/vitest.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ jobs:
5959
- uses: pnpm/action-setup@v5
6060
name: Install pnpm
6161
with:
62-
version: 11
6362
run_install: false
6463
- uses: actions/setup-node@v5
6564
with:
@@ -104,7 +103,6 @@ jobs:
104103
- uses: pnpm/action-setup@v5
105104
name: Install pnpm
106105
with:
107-
version: 11
108106
run_install: false
109107
- uses: actions/setup-node@v5
110108
with:
@@ -146,7 +144,6 @@ jobs:
146144
- uses: pnpm/action-setup@v5
147145
name: Install pnpm
148146
with:
149-
version: 11
150147
run_install: false
151148
- uses: actions/setup-node@v5
152149
with:

.github/workflows/weekly-merge-branch-lockfiles.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ jobs:
2222
- uses: pnpm/action-setup@v5
2323
name: Install pnpm
2424
with:
25-
version: 11
2625
run_install: false
2726

2827
- uses: actions/setup-node@v5

amplify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ applications:
113113
- nvm install
114114
- nvm use
115115
# Pin pnpm to the version declared by `package.json#packageManager`
116-
# (currently `pnpm@11.0.8`). With that field present, `corepack
116+
# (currently `pnpm@11.1.0`). With that field present, `corepack
117117
# enable` is sufficient — corepack auto-resolves the pinned
118118
# version on the first pnpm invocation. Do NOT add a
119119
# `corepack prepare pnpm@<major> --activate` line here: a stale

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"engines": {
99
"pnpm": "^11.0.0"
1010
},
11-
"packageManager": "pnpm@11.0.8",
11+
"packageManager": "pnpm@11.1.0",
1212
"scripts": {
1313
"lint": "eslint src --quiet; exit 0",
1414
"lint-fix": "eslint src --quiet --fix; exit 0",

0 commit comments

Comments
 (0)