Commit 99a2905
committed
resolves #3340, #3496 ([FR-820](https://lablup.atlassian.net/browse/FR-820))
## Remove redundant `onCollapse` handler in MainLayout to keep sidebar collapse after refreshing
This PR removes the redundant `onCollapse` handler from the MainLayout component. The handler was setting the `sideCollapsed` state, which is already being handled by the existing `onBreakpoint` function.
### Minimum requirements to check during review
- wide screen
- [ ] if compact sidebar is true, keep compact sidebar after refreshing.
- [ ] if compact sidebar is false, sidebar always expanded.
- middle screen
- [ ] always compact sidebar
- narrow screen
- [ ] always hidden sidebar
**Checklist:**
- [ ] Documentation
- [ ] Minium required manager version
- [x] Specific setting for review (eg., KB link, endpoint or how to setup)
- [x] Minimum requirements to check during review: toggle `Use Compact Sidebar by default` in usersettings page.
- [ ] Test case(s) to demonstrate the difference of before/after
[FR-820]: https://lablup.atlassian.net/browse/FR-820?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 44ee94f commit 99a2905
2 files changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
166 | | - | |
| 165 | + | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | | - | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
443 | 445 | | |
444 | 446 | | |
445 | 447 | | |
446 | | - | |
| 448 | + | |
447 | 449 | | |
448 | 450 | | |
449 | 451 | | |
| |||
0 commit comments