fix(FR-2831): disable Deploy as service action when no compatible presets exist

Author: ironAiken2

react/src/components/VFolderNodes.tsx

@@ -2,6 +2,7 @@
  @license
  Copyright (c) 2015-2026 Lablup Inc. All rights reserved.
  */
+import { VFolderNodesDeploymentPresetsCheckQuery } from '../__generated__/VFolderNodesDeploymentPresetsCheckQuery.graphql';
 import {
   VFolderNodesFragment$data,
   VFolderNodesFragment$key,
@@ -44,7 +45,7 @@ import dayjs from 'dayjs';
 import * as _ from 'lodash-es';
 import React, { useState } from 'react';
 import { useTranslation } from 'react-i18next';
-import { graphql, useFragment } from 'react-relay';
+import { graphql, useFragment, useLazyLoadQuery } from 'react-relay';
 
 export const statusTagColor = {
   // mountable
@@ -104,6 +105,15 @@ interface VFolderNameCellProps {
    * additionally redirects admins (project/domain/super) to that page.
    */
   disableProjectFolderActions?: boolean;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no compatible
+   * deployment presets are available. Computed once at the table level
+   * by `VFolderNodes` (via `deploymentRevisionPresets`) so we don't fire
+   * one query per row. The `VFolderDeployModal` retains a `null`-return
+   * fallback for the same condition as defense in depth.
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
@@ -114,6 +124,7 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
   onDeleteForever,
   onStartServiceFallback,
   disableProjectFolderActions = false,
+  hasNoCompatiblePresets = false,
 }) => {
   'use memo';
   const { t } = useTranslation();
@@ -149,6 +160,10 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
           key: 'start-service',
           title: t('modelService.DeployAsService'),
           icon: <BAIEndpointsIcon />,
+          disabled: hasNoCompatiblePresets,
+          disabledReason: hasNoCompatiblePresets
+            ? t('data.folders.NoCompatibleDeploymentPresets')
+            : undefined,
           onClick: () => onStartServiceFallback(vfolderId),
         }
       : null,
@@ -309,6 +324,28 @@ const VFolderNodes: React.FC<VFolderNodesProps> = ({
 
   const filteredVFolders = filterOutNullAndUndefined(vfolders);
 
+  // Project-scoped check: are any deployment presets available for this
+  // project? Used to gate the row-level "Deploy as service" action so model
+  // folders show a disabled tooltip ("No compatible deployment presets…")
+  // instead of a fully interactive button that opens a modal which then
+  // returns `null` (FR-2831). Run once per table mount, not once per row.
+  // TODO(needs-backend): once `deploymentRevisionPresets` exposes a
+  // per-vfolder compatibility filter, narrow this check to the rows that
+  // actually have a model folder and respect their compatibility.
+  const { deploymentRevisionPresets } =
+    useLazyLoadQuery<VFolderNodesDeploymentPresetsCheckQuery>(
+      graphql`
+        query VFolderNodesDeploymentPresetsCheckQuery {
+          deploymentRevisionPresets(first: 0) {
+            count
+          }
+        }
+      `,
+      {},
+      { fetchPolicy: 'store-or-network' },
+    );
+  const hasNoCompatiblePresets = (deploymentRevisionPresets?.count ?? 0) === 0;
+
   const deleteMutation = useTanMutation({
     mutationFn: (id: string) => {
       return baiClient.vfolder.delete_by_id(toLocalId(id));
@@ -347,6 +384,7 @@ const VFolderNodes: React.FC<VFolderNodesProps> = ({
                 <VFolderNameCell
                   vfolder={vfolder}
                   disableProjectFolderActions={disableProjectFolderActions}
+                  hasNoCompatiblePresets={hasNoCompatiblePresets}
                   onShare={() => {
                     vfolder?.user === currentUser?.uuid
                       ? setInviteFolderId(toLocalId(vfolder?.id ?? null))

react/src/components/VFolderNodesV2.tsx

@@ -3,6 +3,7 @@
  Copyright (c) 2015-2026 Lablup Inc. All rights reserved.
  */
 import { VFolderNodesV2DeleteMutation } from '../__generated__/VFolderNodesV2DeleteMutation.graphql';
+import { VFolderNodesV2DeploymentPresetsCheckQuery } from '../__generated__/VFolderNodesV2DeploymentPresetsCheckQuery.graphql';
 import {
   VFolderNodesV2Fragment$data,
   VFolderNodesV2Fragment$key,
@@ -49,7 +50,12 @@ import dayjs from 'dayjs';
 import * as _ from 'lodash-es';
 import React, { Suspense, useState } from 'react';
 import { useTranslation } from 'react-i18next';
-import { graphql, useFragment, useMutation } from 'react-relay';
+import {
+  graphql,
+  useFragment,
+  useLazyLoadQuery,
+  useMutation,
+} from 'react-relay';
 
 export const statusTagColor = {
   // V2 UPPERCASE enum values (VFolderOperationStatus)
@@ -115,6 +121,15 @@ interface VFolderNameCellProps {
    * (FR-2599) for the given vfolder instead of navigating away.
    */
   onStartServiceFallback: (vfolderId: string) => void;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no compatible
+   * deployment presets are available. Computed once at the table level
+   * by `VFolderNodesV2` (via `deploymentRevisionPresets`) so we don't fire
+   * one query per row. The `VFolderDeployModal` retains a `null`-return
+   * fallback for the same condition as defense in depth.
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
@@ -124,6 +139,7 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
   onRestore,
   onDeleteForever,
   onStartServiceFallback,
+  hasNoCompatiblePresets = false,
 }) => {
   'use memo';
   const { t } = useTranslation();
@@ -143,6 +159,10 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
           key: 'start-service',
           title: t('modelService.DeployAsService'),
           icon: <BAIEndpointsIcon />,
+          disabled: hasNoCompatiblePresets,
+          disabledReason: hasNoCompatiblePresets
+            ? t('data.folders.NoCompatibleDeploymentPresets')
+            : undefined,
           onClick: () => onStartServiceFallback(vfolderId),
         }
       : null,
@@ -488,6 +508,28 @@ const VFolderNodesV2: React.FC<VFolderNodesV2Props> = ({
 
   const filteredVFolders = filterOutNullAndUndefined(vfolders);
 
+  // Project-scoped check: are any deployment presets available? Used to
+  // gate the row-level "Deploy as service" action so model folders show a
+  // disabled tooltip ("No compatible deployment presets…") instead of a
+  // fully interactive button that opens a modal which then returns `null`
+  // (FR-2831). Run once per table mount, not once per row.
+  // TODO(needs-backend): once `deploymentRevisionPresets` exposes a
+  // per-vfolder compatibility filter, narrow this check to the rows that
+  // actually have a model folder and respect their compatibility.
+  const { deploymentRevisionPresets } =
+    useLazyLoadQuery<VFolderNodesV2DeploymentPresetsCheckQuery>(
+      graphql`
+        query VFolderNodesV2DeploymentPresetsCheckQuery {
+          deploymentRevisionPresets(first: 0) {
+            count
+          }
+        }
+      `,
+      {},
+      { fetchPolicy: 'store-or-network' },
+    );
+  const hasNoCompatiblePresets = (deploymentRevisionPresets?.count ?? 0) === 0;
+
   const [commitDeleteMutation] = useMutation<VFolderNodesV2DeleteMutation>(
     graphql`
       mutation VFolderNodesV2DeleteMutation($vfolderId: UUID!) {
@@ -566,6 +608,7 @@ const VFolderNodesV2: React.FC<VFolderNodesV2Props> = ({
               return (
                 <VFolderNameCell
                   vfolder={vfolder}
+                  hasNoCompatiblePresets={hasNoCompatiblePresets}
                   onShare={() => {
                     vfolder?.ownership?.userId === currentUser?.uuid
                       ? setInviteFolderId(toLocalId(vfolder?.id ?? null))

resources/i18n/en.json

@@ -790,6 +790,7 @@
       "MultipleFolderDeletedForever": "Permanently deleted {{count}} folders out of {{total}}.",
       "MultipleFolderRestored": "Selected {{ folderLength }} folders has been restored.",
       "Name": "Name",
+      "NoCompatibleDeploymentPresets": "No compatible deployment presets are available for this folder.",
       "NoDeletePermission": "No delete permission",
       "NoFolderToDisplay": "No Folders to display",
       "NoRestorePermission": "No restore permission",