Skip to content

Commit d7fb3b2

Browse files
committed
test(FR-2639): add E2E regression for sToken login boundary routes (#6865)
Resolves FR-2639 and FR-2643 (under Stories [FR-2626](https://lablup.atlassian.net/browse/FR-2626) / [FR-2627](https://lablup.atlassian.net/browse/FR-2627), Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack Story 2/3 E2E regression for Epic FR-2616. Sits on top of the Story 2 (#6861) and Story 3 (#6864) implementation PRs. [FR-2626]: https://lablup.atlassian.net/browse/FR-2626?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FR-2627]: https://lablup.atlassian.net/browse/FR-2627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 547b702 commit d7fb3b2

4 files changed

Lines changed: 875 additions & 593 deletions

File tree

.specs/draft-stoken-login-boundary/metadata.json

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,31 @@
7979
"subtasks": [
8080
{
8181
"key": "FR-2636",
82-
"title": "[2.1] Wrap / and /interactive-login routes with STokenLoginBoundary conditionally"
82+
"title": "[2.1] Wrap / and /interactive-login routes with STokenLoginBoundary conditionally",
83+
"prNumber": 6861,
84+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6861",
85+
"note": "bundled into Story 2 PR #6861"
8386
},
8487
{
8588
"key": "FR-2637",
86-
"title": "[2.2] Move postConnectSetup side effects into route-level onSuccess"
89+
"title": "[2.2] Move postConnectSetup side effects into route-level onSuccess",
90+
"prNumber": 6861,
91+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6861",
92+
"note": "bundled into Story 2 PR #6861"
8793
},
8894
{
8995
"key": "FR-2638",
90-
"title": "[2.3] Remove connectUsingSession sToken branch and URL parsing in LoginView"
96+
"title": "[2.3] Remove connectUsingSession sToken branch and URL parsing in LoginView",
97+
"prNumber": 6861,
98+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6861",
99+
"note": "bundled into Story 2 PR #6861"
91100
},
92101
{
93102
"key": "FR-2639",
94-
"title": "[2.4] E2E regression for LoginView sToken entry"
103+
"title": "[2.4] E2E regression for LoginView sToken entry",
104+
"prNumber": 6865,
105+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6865",
106+
"note": "bundled into E2E PR #6865"
95107
}
96108
]
97109
},
@@ -106,19 +118,31 @@
106118
"subtasks": [
107119
{
108120
"key": "FR-2640",
109-
"title": "[3.1] Investigate get_user_credential(sToken) liveness (Q8)"
121+
"title": "[3.1] Investigate get_user_credential(sToken) liveness (Q8)",
122+
"prNumber": null,
123+
"prUrl": null,
124+
"note": "investigation only (Jira comment); resolved to option (a) prop-threading"
110125
},
111126
{
112127
"key": "FR-2641",
113-
"title": "[3.2] Wrap /edu-applauncher and /applauncher routes with STokenLoginBoundary"
128+
"title": "[3.2] Wrap /edu-applauncher and /applauncher routes with STokenLoginBoundary",
129+
"prNumber": 6864,
130+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6864",
131+
"note": "bundled into Story 3 PR #6864"
114132
},
115133
{
116134
"key": "FR-2642",
117-
"title": "[3.3] Remove _token_login and manual backend-ai-connected dispatch in EduAppLauncher"
135+
"title": "[3.3] Remove _token_login and manual backend-ai-connected dispatch in EduAppLauncher",
136+
"prNumber": 6864,
137+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6864",
138+
"note": "bundled into Story 3 PR #6864"
118139
},
119140
{
120141
"key": "FR-2643",
121-
"title": "[3.4] E2E regression for EduApp sToken entry with and without session_id"
142+
"title": "[3.4] E2E regression for EduApp sToken entry with and without session_id",
143+
"prNumber": 6865,
144+
"prUrl": "https://github.com/lablup/backend.ai-webui/pull/6865",
145+
"note": "bundled into E2E PR #6865"
122146
}
123147
]
124148
}
@@ -149,5 +173,5 @@
149173
},
150174
"sourceIssues": [],
151175
"createdAt": "2026-04-21T00:00:00Z",
152-
"notes": "Epic FR-2616 filed. Spec Task FR-2618 created. Story 1 implementation: PRs #6850-#6853, #6855-#6857 submitted (FR-2628, FR-2629, FR-2630, FR-2631, FR-2632, FR-2633, refactor). FR-2634 closed as Not Planned (duplicate of FR-2633 test assertion). FR-2635 closed as investigation-only (Jira comment). Directory still uses draft- prefix; rename to FR-2616-stoken-login-boundary as a follow-up."
176+
"notes": "Epic FR-2616 filed. Spec Task FR-2618 + Story 1-3 (FR-2625, FR-2626, FR-2627). Story 1: PRs #6850-#6853, #6855-#6857 (7 PRs). Story 2: PR #6861 bundles FR-2636/2637/2638 (LoginView migration). Story 3: PR #6864 bundles FR-2641/2642 (EduAppLauncher migration). Q8 (FR-2640) resolved via prop-threading, no PR. E2E (FR-2639, FR-2643): PR #6865 bundles both. FR-2634 (CI grep rule) closed as redundant with FR-2633 test. FR-2635 (cookie encoding investigation) closed. Directory still uses draft- prefix; rename to FR-2616-stoken-login-boundary as a follow-up after spec PR merges."
153177
}

0 commit comments

Comments
 (0)