Skip to content

Commit e0ef71f

Browse files
committed
fix(FR-843): Users with a user role are incorrectly identified as the owner of the project folder. (#3509)
Resolves #3508 ([FR-843](https://lablup.atlassian.net/browse/FR-843)) # Update owner check in VFolderNodes component This PR modifies the owner check in the VFolderNodes component to only display the owner checkmark for group-owned folders when the user has an admin role. Previously, the checkmark would appear for any user if the folder belonged to the current project group. ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/2ec7c819-f91b-488d-94f0-f23b5484d531.png) **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-843]: https://lablup.atlassian.net/browse/FR-843?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 7b40af4 commit e0ef71f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

react/src/components/VFolderNodes.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,8 @@ const VFolderNodes: React.FC<VFolderNodesProps> = ({
398398
title: t('data.folders.Owner'),
399399
render: (__, vfolder) =>
400400
vfolder?.user === currentUser?.uuid ||
401-
vfolder?.group === currentProject?.id ? (
401+
(vfolder?.group === currentProject?.id &&
402+
userRole === 'admin') ? (
402403
<Flex justify="center">
403404
<CheckCircleOutlined />
404405
</Flex>

0 commit comments

Comments
 (0)