fix(FR-2831): disable Deploy as service action when no compatible presets exist

Author: ironAiken2

react/src/components/VFolderNodes.tsx

@@ -103,6 +103,23 @@ interface VFolderNameCellProps {
    * additionally redirects admins (project/domain/super) to that page.
    */
   disableProjectFolderActions?: boolean;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no deployment
+   * presets are available. Computed once at the page level (via the page's
+   * `useLazyLoadQuery` selecting `deploymentRevisionPresets(first: 0) { count }`)
+   * and forwarded down through `VFolderNodes` so we don't fire one query
+   * per row. The `VFolderDeployModal` retains a `null`-return fallback for
+   * the same condition as defense in depth.
+   *
+   * TODO(needs-backend): the schema exposes
+   * `modelCardAvailablePresets(scope: { modelCardId })`, but we have a
+   * vfolder, not a model card, in this row. Either add a vfolder scope
+   * (`VFolderAvailablePresetsScope`) or expose a vfolder→modelCard link
+   * so we can narrow this check per row. Today this boolean reflects
+   * "any preset exists in this project."
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
@@ -113,6 +130,7 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
   onDeleteForever,
   onStartServiceFallback,
   disableProjectFolderActions = false,
+  hasNoCompatiblePresets = false,
 }) => {
   'use memo';
   const { t } = useTranslation();
@@ -148,6 +166,10 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
           key: 'start-service',
           title: t('modelService.DeployAsService'),
           icon: <BAIEndpointsIcon />,
+          disabled: hasNoCompatiblePresets,
+          disabledReason: hasNoCompatiblePresets
+            ? t('data.folders.NoCompatibleDeploymentPresets')
+            : undefined,
           onClick: () => onStartServiceFallback(vfolderId),
         }
       : null,
@@ -248,12 +270,29 @@ interface VFolderNodesProps extends Omit<
    * component. This prop is the V1-friendly stopgap.
    */
   disableProjectFolderActions?: boolean;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no deployment
+   * presets are available. Derived at the page-level `useLazyLoadQuery`
+   * from `deploymentRevisionPresets(first: 0) { count }` so we don't fire
+   * one query per row. Defaults to `false` so existing call sites are
+   * additive — page hosts opt in by passing the derived value.
+   *
+   * TODO(needs-backend): the schema exposes
+   * `modelCardAvailablePresets(scope: { modelCardId })`, but we have a
+   * vfolder, not a model card, in this row. Either add a vfolder scope
+   * (`VFolderAvailablePresetsScope`) or expose a vfolder→modelCard link
+   * so we can narrow this check per row. Today this boolean reflects
+   * "any preset exists in this project."
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNodes: React.FC<VFolderNodesProps> = ({
   vfoldersFrgmt,
   onRemoveRow,
   disableProjectFolderActions,
+  hasNoCompatiblePresets = false,
   ...tableProps
 }) => {
   const { t } = useTranslation();
@@ -346,6 +385,7 @@ const VFolderNodes: React.FC<VFolderNodesProps> = ({
                 <VFolderNameCell
                   vfolder={vfolder}
                   disableProjectFolderActions={disableProjectFolderActions}
+                  hasNoCompatiblePresets={hasNoCompatiblePresets}
                   onShare={() => {
                     vfolder?.user === currentUser?.uuid
                       ? setInviteFolderId(toLocalId(vfolder?.id ?? null))

react/src/components/VFolderNodesV2.tsx

@@ -119,6 +119,23 @@ interface VFolderNameCellProps {
    * (FR-2599) for the given vfolder instead of navigating away.
    */
   onStartServiceFallback: (vfolderId: string) => void;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no deployment
+   * presets are available. Computed once at the page level (via the page's
+   * `useLazyLoadQuery` selecting `deploymentRevisionPresets(first: 0) { count }`)
+   * and forwarded down through `VFolderNodesV2` so we don't fire one query
+   * per row. The `VFolderDeployModal` retains a `null`-return fallback for
+   * the same condition as defense in depth.
+   *
+   * TODO(needs-backend): the schema exposes
+   * `modelCardAvailablePresets(scope: { modelCardId })`, but we have a
+   * vfolder, not a model card, in this row. Either add a vfolder scope
+   * (`VFolderAvailablePresetsScope`) or expose a vfolder→modelCard link
+   * so we can narrow this check per row. Today this boolean reflects
+   * "any preset exists in this project."
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
@@ -128,6 +145,7 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
   onRestore,
   onDeleteForever,
   onStartServiceFallback,
+  hasNoCompatiblePresets = false,
 }) => {
   'use memo';
   const { t } = useTranslation();
@@ -147,6 +165,10 @@ const VFolderNameCell: React.FC<VFolderNameCellProps> = ({
           key: 'start-service',
           title: t('modelService.DeployAsService'),
           icon: <BAIEndpointsIcon />,
+          disabled: hasNoCompatiblePresets,
+          disabledReason: hasNoCompatiblePresets
+            ? t('data.folders.NoCompatibleDeploymentPresets')
+            : undefined,
           onClick: () => onStartServiceFallback(vfolderId),
         }
       : null,
@@ -409,11 +431,28 @@ interface VFolderNodesV2Props extends Omit<
   vfoldersFrgmt: VFolderNodesV2Fragment$key;
   // Callback when a row is removed from current list
   onRemoveRow?: (updatedFolderId?: string) => void;
+  /**
+   * When true, the row-level "Deploy as service" action for model folders
+   * is rendered disabled with a tooltip explaining that no deployment
+   * presets are available. Derived at the page-level `useLazyLoadQuery`
+   * from `deploymentRevisionPresets(first: 0) { count }` so we don't fire
+   * one query per row. Defaults to `false` so existing call sites are
+   * additive — page hosts opt in by passing the derived value.
+   *
+   * TODO(needs-backend): the schema exposes
+   * `modelCardAvailablePresets(scope: { modelCardId })`, but we have a
+   * vfolder, not a model card, in this row. Either add a vfolder scope
+   * (`VFolderAvailablePresetsScope`) or expose a vfolder→modelCard link
+   * so we can narrow this check per row. Today this boolean reflects
+   * "any preset exists in this project."
+   */
+  hasNoCompatiblePresets?: boolean;
 }
 
 const VFolderNodesV2: React.FC<VFolderNodesV2Props> = ({
   vfoldersFrgmt,
   onRemoveRow,
+  hasNoCompatiblePresets = false,
   ...tableProps
 }) => {
   'use memo';
@@ -570,6 +609,7 @@ const VFolderNodesV2: React.FC<VFolderNodesV2Props> = ({
               return (
                 <VFolderNameCell
                   vfolder={vfolder}
+                  hasNoCompatiblePresets={hasNoCompatiblePresets}
                   onShare={() => {
                     vfolder?.ownership?.userId === currentUser?.uuid
                       ? setInviteFolderId(toLocalId(vfolder?.id ?? null))

react/src/pages/AdminVFolderNodeListPage.tsx

@@ -147,7 +147,7 @@ const AdminVFolderNodeListPage: React.FC = (props) => {
   const deferredQueryVariables = useDeferredValue(queryVariables);
   const deferredFetchKey = useDeferredValue(fetchKey);
 
-  const { vfolder_nodes, ...folderCounts } =
+  const { vfolder_nodes, deploymentRevisionPresets, ...folderCounts } =
     useLazyLoadQuery<AdminVFolderNodeListPageQuery>(
       graphql`
         query AdminVFolderNodeListPageQuery(
@@ -198,6 +198,17 @@ const AdminVFolderNodeListPage: React.FC = (props) => {
           ) {
             count
           }
+          # Project-scoped check: gates the row-level Deploy as service
+          # action so model folders show a disabled tooltip instead of a
+          # fully interactive button that opens a modal which then returns
+          # null (FR-2831). Hoisted to the page-level query so we do not
+          # fire one query per row or per table.
+          # first: 1 rather than 0 because the backend's
+          # SearchDeploymentRevisionPresetsInput validates first >= 1.
+          # We only read count, so the single returned edge is unused.
+          deploymentRevisionPresets(first: 1) {
+            count
+          }
         }
       `,
       deferredQueryVariables,
@@ -459,6 +470,10 @@ const AdminVFolderNodeListPage: React.FC = (props) => {
           <VFolderNodes
             order={queryParams.order}
             loading={deferredQueryVariables !== queryVariables}
+            // True only when we have a definitive zero — `null`/`undefined`
+            // (loading or query error) keeps the action enabled so we don't
+            // surface a misleading "no presets" tooltip in those cases.
+            hasNoCompatiblePresets={deploymentRevisionPresets?.count === 0}
             vfoldersFrgmt={filterOutNullAndUndefined(
               _.map(vfolder_nodes?.edges, 'node'),
             )}

react/src/pages/ProjectAdminDataPage.tsx

@@ -185,7 +185,7 @@ const ProjectAdminDataContent: React.FC<ProjectAdminDataContentProps> = ({
   const deferredQueryVariables = useDeferredValue(queryVariables);
   const deferredFetchKey = useDeferredValue(fetchKey);
 
-  const { projectVfolders, ...folderCounts } =
+  const { projectVfolders, deploymentRevisionPresets, ...folderCounts } =
     useLazyLoadQuery<ProjectAdminDataPageQuery>(
       graphql`
         query ProjectAdminDataPageQuery(
@@ -229,6 +229,17 @@ const ProjectAdminDataContent: React.FC<ProjectAdminDataContentProps> = ({
           ) {
             count
           }
+          # Project-scoped check: gates the row-level Deploy as service
+          # action so model folders show a disabled tooltip instead of a
+          # fully interactive button that opens a modal which then returns
+          # null (FR-2831). Hoisted to the page-level query so we do not
+          # fire one query per row or per table.
+          # first: 1 rather than 0 because the backend's
+          # SearchDeploymentRevisionPresetsInput validates first >= 1.
+          # We only read count, so the single returned edge is unused.
+          deploymentRevisionPresets(first: 1) {
+            count
+          }
         }
       `,
       deferredQueryVariables,
@@ -433,6 +444,10 @@ const ProjectAdminDataContent: React.FC<ProjectAdminDataContentProps> = ({
         <VFolderNodesV2
           order={queryParams.order}
           loading={deferredQueryVariables !== queryVariables}
+          // True only when we have a definitive zero — `null`/`undefined`
+          // (loading or query error) keeps the action enabled so we don't
+          // surface a misleading "no presets" tooltip in those cases.
+          hasNoCompatiblePresets={deploymentRevisionPresets?.count === 0}
           vfoldersFrgmt={filterOutNullAndUndefined(
             _.map(projectVfolders?.edges, 'node'),
           )}

react/src/pages/VFolderNodeListPage.tsx

@@ -181,7 +181,7 @@ const VFolderNodeListPage: React.FC<VFolderNodeListPageProps> = ({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [invitations.length]);
 
-  const { vfolder_nodes, ...folderCounts } =
+  const { vfolder_nodes, deploymentRevisionPresets, ...folderCounts } =
     useLazyLoadQuery<VFolderNodeListPageQuery>(
       graphql`
         query VFolderNodeListPageQuery(
@@ -236,6 +236,17 @@ const VFolderNodeListPage: React.FC<VFolderNodeListPageProps> = ({
           ) {
             count
           }
+          # Project-scoped check: gates the row-level Deploy as service
+          # action so model folders show a disabled tooltip instead of a
+          # fully interactive button that opens a modal which then returns
+          # null (FR-2831). Hoisted to the page-level query so we do not
+          # fire one query per row or per table.
+          # first: 1 rather than 0 because the backend's
+          # SearchDeploymentRevisionPresetsInput validates first >= 1.
+          # We only read count, so the single returned edge is unused.
+          deploymentRevisionPresets(first: 1) {
+            count
+          }
         }
       `,
       deferredQueryVariables,
@@ -509,6 +520,10 @@ const VFolderNodeListPage: React.FC<VFolderNodeListPageProps> = ({
             order={queryParams.order}
             loading={deferredQueryVariables !== queryVariables}
             disableProjectFolderActions
+            // True only when we have a definitive zero — `null`/`undefined`
+            // (loading or query error) keeps the action enabled so we don't
+            // surface a misleading "no presets" tooltip in those cases.
+            hasNoCompatiblePresets={deploymentRevisionPresets?.count === 0}
             vfoldersFrgmt={filterOutNullAndUndefined(
               _.map(vfolder_nodes?.edges, 'node'),
             )}

resources/i18n/de.json

@@ -790,6 +790,7 @@
       "MultipleFolderDeletedForever": "{{count}} von {{total}} Ordnern wurden dauerhaft gelöscht.",
       "MultipleFolderRestored": "Ausgewählte {{ folderLength }} Ordner wurden wiederhergestellt.",
       "Name": "Name",
+      "NoCompatibleDeploymentPresets": "No deployment presets available in this project.",
       "NoDeletePermission": "Keine Löschberechtigung",
       "NoFolderToDisplay": "Keine Ordner anzeigen",
       "NoRestorePermission": "Keine Wiederherstellungsberechtigung",

resources/i18n/el.json

@@ -790,6 +790,7 @@
       "MultipleFolderDeletedForever": "Διαγράφηκαν οριστικά {{count}} από τους {{total}} φακέλους.",
       "MultipleFolderRestored": "Επιλεγμένα {{ folderLength }} Φάκελοι έχει αποκατασταθεί.",
       "Name": "Ονομα",
+      "NoCompatibleDeploymentPresets": "No deployment presets available in this project.",
       "NoDeletePermission": "Δεν υπάρχει δικαίωμα διαγραφής",
       "NoFolderToDisplay": "Δεν εμφανίζονται φάκελοι",
       "NoRestorePermission": "Δεν υπάρχει δικαίωμα επαναφοράς",

resources/i18n/en.json

@@ -791,6 +791,7 @@
       "MultipleFolderDeletedForever": "Permanently deleted {{count}} folders out of {{total}}.",
       "MultipleFolderRestored": "Selected {{ folderLength }} folders has been restored.",
       "Name": "Name",
+      "NoCompatibleDeploymentPresets": "No deployment presets available in this project.",
       "NoDeletePermission": "No delete permission",
       "NoFolderToDisplay": "No Folders to display",
       "NoRestorePermission": "No restore permission",

resources/i18n/es.json

@@ -790,6 +790,7 @@
       "MultipleFolderDeletedForever": "Se eliminaron permanentemente {{count}} carpetas de {{total}}.",
       "MultipleFolderRestored": "Se han restaurado las carpetas seleccionadas {{ folderLength }}.",
       "Name": "Nombre",
+      "NoCompatibleDeploymentPresets": "No deployment presets available in this project.",
       "NoDeletePermission": "Sin permiso de eliminación",
       "NoFolderToDisplay": "No hay carpetas que mostrar",
       "NoRestorePermission": "Sin permiso de restauración",

resources/i18n/fi.json

@@ -790,6 +790,7 @@
       "MultipleFolderDeletedForever": "Poistettiin pysyvästi {{count}}/{{total}} kansiota.",
       "MultipleFolderRestored": "Valitut {{ folderLength }} kansiot on palautettu.",
       "Name": "Nimi",
+      "NoCompatibleDeploymentPresets": "No deployment presets available in this project.",
       "NoDeletePermission": "Ei poistolupaa",
       "NoFolderToDisplay": "Ei näytettäviä kansioita",
       "NoRestorePermission": "Ei palautuslupaa",