Skip to content

Commit efa0d5a

Browse files
committed
fix(FR-1916): change propagated required fields of useRuntimeEnvVarConfigs to optional. (#5052)
Resolves #5051 ([FR-1916](https://lablup.atlassian.net/browse/FR-1916)) ## Make `BACKEND_MODEL_NAME` optional for vllm and sglang variants This PR changes the environment variable configuration for vllm, sglang, and nim variants: - Moves `BACKEND_MODEL_NAME` from required to optional environment variables for both vllm and sglang variants - Simplifies the nim variant configuration by using only optionalEnvVars array **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1916]: https://lablup.atlassian.net/browse/FR-1916?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 9f77fcf commit efa0d5a

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

react/src/hooks/useVariantConfigs.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,11 @@ export const useRuntimeEnvVarConfigs = (): Record<
1414

1515
return {
1616
vllm: {
17-
requiredEnvVars: [
17+
optionalEnvVars: [
1818
{
1919
variable: 'BACKEND_MODEL_NAME',
2020
placeholder: t('modelService.VllmModelName'),
2121
},
22-
],
23-
optionalEnvVars: [
2422
{
2523
variable: 'VLLM_QUANTIZATION',
2624
placeholder: t('modelService.VllmQuantization'),
@@ -40,13 +38,11 @@ export const useRuntimeEnvVarConfigs = (): Record<
4038
],
4139
},
4240
sglang: {
43-
requiredEnvVars: [
41+
optionalEnvVars: [
4442
{
4543
variable: 'BACKEND_MODEL_NAME',
4644
placeholder: t('modelService.SglangModelName'),
4745
},
48-
],
49-
optionalEnvVars: [
5046
{
5147
variable: 'SGLANG_QUANTIZATION',
5248
placeholder: t('modelService.SglangQuantization'),
@@ -66,13 +62,12 @@ export const useRuntimeEnvVarConfigs = (): Record<
6662
],
6763
},
6864
nim: {
69-
requiredEnvVars: [
65+
optionalEnvVars: [
7066
{
7167
variable: 'NGC_API_KEY',
7268
placeholder: t('modelService.NimApiKey'),
7369
},
7470
],
75-
optionalEnvVars: [],
7671
},
7772
};
7873
};

0 commit comments

Comments
 (0)