Skip to content

Commit 13a39f5

Browse files
jopemachineclaude
andcommitted
fix(test): drop DeploymentNode.policy references after v2 scope-id refactor
a70582c dropped the ``policy`` field from ``DeploymentNode`` (v2 GQL response) but left this test module still building / asserting on it, so mypy hit ``"DeploymentNode" has no attribute "policy"`` in 7 spots and the typecheck CI job failed. Remove the ``policy`` default from the test factory, drop the three now-meaningless policy test cases, and prune the imports they exclusively used. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent a70582c commit 13a39f5

1 file changed

Lines changed: 0 additions & 36 deletions

File tree

tests/unit/common/dto/manager/v2/deployment/test_response.py

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,15 @@
2929
UpdateDeploymentPayload,
3030
)
3131
from ai.backend.common.dto.manager.v2.deployment.types import (
32-
BlueGreenConfigInfo,
3332
ClusterConfigInfoDTO,
3433
DeploymentMetadataInfoDTO,
3534
DeploymentNetworkAccessInfoDTO,
36-
DeploymentPolicyInfo,
3735
DeploymentStrategyInfoDTO,
3836
ExtraVFolderMountGQLDTO,
39-
IntOrPercent,
4037
ModelMountConfigInfoDTO,
4138
ModelRuntimeConfigInfoDTO,
4239
ReplicaStateInfo,
4340
ResourceConfigInfoDTO,
44-
RollingUpdateConfigInfo,
4541
)
4642
from ai.backend.common.dto.manager.v2.deployment_options.response import (
4743
DeploymentHandlerOptionsInfo,
@@ -169,7 +165,6 @@ def _make_deployment_node(**kwargs: object) -> DeploymentNode:
169165
"options": _make_deployment_options(),
170166
"scaling_state": ScalingState.STABLE,
171167
"current_revision_id": None,
172-
"policy": None,
173168
}
174169
defaults.update(kwargs)
175170
return DeploymentNode(**defaults)
@@ -316,48 +311,17 @@ def test_creation_with_required_fields(self) -> None:
316311
)
317312
assert node.id == deployment_id
318313
assert node.current_revision_id is None
319-
assert node.policy is None
320314

321315
def test_current_revision_id_defaults_to_none(self) -> None:
322316
node = _make_deployment_node()
323317
assert node.current_revision_id is None
324318

325-
def test_policy_defaults_to_none(self) -> None:
326-
node = _make_deployment_node()
327-
assert node.policy is None
328-
329319
def test_with_current_revision_id(self) -> None:
330320
revision_id = uuid.uuid4()
331321
node = _make_deployment_node(current_revision_id=revision_id)
332322
assert node.current_revision_id is not None
333323
assert node.current_revision_id == revision_id
334324

335-
def test_with_rolling_policy(self) -> None:
336-
rolling = RollingUpdateConfigInfo(
337-
max_surge=IntOrPercent(count=1),
338-
max_unavailable=IntOrPercent(count=0),
339-
)
340-
policy = DeploymentPolicyInfo(
341-
strategy=DeploymentStrategy.ROLLING,
342-
rolling_update=rolling,
343-
blue_green=None,
344-
)
345-
node = _make_deployment_node(policy=policy)
346-
assert node.policy is not None
347-
assert node.policy.strategy == DeploymentStrategy.ROLLING
348-
assert node.policy.rolling_update is not None
349-
350-
def test_with_blue_green_policy(self) -> None:
351-
bg = BlueGreenConfigInfo(auto_promote=False, promote_delay_seconds=0)
352-
policy = DeploymentPolicyInfo(
353-
strategy=DeploymentStrategy.BLUE_GREEN,
354-
rolling_update=None,
355-
blue_green=bg,
356-
)
357-
node = _make_deployment_node(policy=policy)
358-
assert node.policy is not None
359-
assert node.policy.strategy == DeploymentStrategy.BLUE_GREEN
360-
361325
def test_metadata_accessible(self) -> None:
362326
project_id = str(uuid.uuid4())
363327
metadata = _make_deployment_metadata(project_id=project_id, name="my-deploy")

0 commit comments

Comments
 (0)