|
| 1 | +"""Component tests for v2 VFolder RBAC-enforced purge mutation via SDK. |
| 2 | +
|
| 3 | +Exercises purge mutation through the real HTTP server + V2ClientRegistry SDK. |
| 4 | +""" |
| 5 | + |
| 6 | +from __future__ import annotations |
| 7 | + |
| 8 | +import secrets |
| 9 | +import uuid |
| 10 | +from collections.abc import AsyncIterator |
| 11 | +from dataclasses import dataclass |
| 12 | +from typing import TYPE_CHECKING |
| 13 | +from unittest.mock import MagicMock |
| 14 | + |
| 15 | +import pytest |
| 16 | +import yarl |
| 17 | + |
| 18 | +from ai.backend.client.v2.auth import HMACAuth |
| 19 | +from ai.backend.client.v2.config import ClientConfig |
| 20 | +from ai.backend.client.v2.exceptions import PermissionDeniedError |
| 21 | +from ai.backend.client.v2.v2_registry import V2ClientRegistry |
| 22 | +from ai.backend.common.types import QuotaScopeID, QuotaScopeType, VFolderUsageMode |
| 23 | +from ai.backend.manager.actions.validators import ActionValidators |
| 24 | +from ai.backend.manager.actions.validators.rbac import RBACValidators |
| 25 | +from ai.backend.manager.actions.validators.rbac.scope import ScopeActionRBACValidator |
| 26 | +from ai.backend.manager.actions.validators.rbac.single_entity import ( |
| 27 | + SingleEntityActionRBACValidator, |
| 28 | +) |
| 29 | +from ai.backend.manager.api.adapters.vfolder import VFolderAdapter |
| 30 | +from ai.backend.manager.api.rest.routing import RouteRegistry |
| 31 | +from ai.backend.manager.api.rest.types import RouteDeps |
| 32 | +from ai.backend.manager.api.rest.v2.vfolder.handler import V2VFolderHandler |
| 33 | +from ai.backend.manager.api.rest.v2.vfolder.registry import register_v2_vfolder_routes |
| 34 | +from ai.backend.manager.data.vfolder.types import ( |
| 35 | + VFolderMountPermission, |
| 36 | + VFolderOperationStatus, |
| 37 | + VFolderOwnershipType, |
| 38 | +) |
| 39 | +from ai.backend.manager.models.utils import ExtendedAsyncSAEngine |
| 40 | +from ai.backend.manager.models.vfolder import vfolders |
| 41 | +from ai.backend.manager.repositories.permission_controller.repository import ( |
| 42 | + PermissionControllerRepository, |
| 43 | +) |
| 44 | +from ai.backend.manager.repositories.user.repository import UserRepository |
| 45 | +from ai.backend.manager.repositories.vfolder.repository import VfolderRepository |
| 46 | +from ai.backend.manager.services.processors import Processors |
| 47 | +from ai.backend.manager.services.vfolder.processors.vfolder import VFolderProcessors |
| 48 | +from ai.backend.manager.services.vfolder.services.vfolder import VFolderService |
| 49 | + |
| 50 | +if TYPE_CHECKING: |
| 51 | + from sqlalchemy.ext.asyncio.engine import AsyncEngine as SAEngine |
| 52 | + from tests.component.conftest import ServerInfo, UserFixtureData |
| 53 | + |
| 54 | + |
| 55 | +@dataclass(frozen=True) |
| 56 | +class ProjectVFolderFixtureData: |
| 57 | + id: uuid.UUID |
| 58 | + project_id: uuid.UUID |
| 59 | + |
| 60 | + |
| 61 | +# -- Fixtures ------------------------------------------------------------------ |
| 62 | + |
| 63 | + |
| 64 | +@pytest.fixture() |
| 65 | +def rbac_permission_repo( |
| 66 | + database_engine: ExtendedAsyncSAEngine, |
| 67 | +) -> PermissionControllerRepository: |
| 68 | + return PermissionControllerRepository(database_engine) |
| 69 | + |
| 70 | + |
| 71 | +@pytest.fixture() |
| 72 | +def vfolder_processors( |
| 73 | + database_engine: ExtendedAsyncSAEngine, |
| 74 | + rbac_permission_repo: PermissionControllerRepository, |
| 75 | +) -> VFolderProcessors: |
| 76 | + """Override: real scope + single-entity RBAC validators.""" |
| 77 | + vfolder_repository = VfolderRepository(database_engine) |
| 78 | + user_repository = UserRepository(database_engine) |
| 79 | + service = VFolderService( |
| 80 | + config_provider=MagicMock(), |
| 81 | + etcd=MagicMock(), |
| 82 | + storage_manager=MagicMock(), |
| 83 | + background_task_manager=MagicMock(), |
| 84 | + vfolder_repository=vfolder_repository, |
| 85 | + user_repository=user_repository, |
| 86 | + valkey_stat_client=MagicMock(), |
| 87 | + ) |
| 88 | + return VFolderProcessors( |
| 89 | + service=service, |
| 90 | + action_monitors=[], |
| 91 | + validators=ActionValidators( |
| 92 | + rbac=RBACValidators( |
| 93 | + scope=ScopeActionRBACValidator(rbac_permission_repo), |
| 94 | + single_entity=SingleEntityActionRBACValidator(rbac_permission_repo), |
| 95 | + ) |
| 96 | + ), |
| 97 | + ) |
| 98 | + |
| 99 | + |
| 100 | +@pytest.fixture() |
| 101 | +def server_module_registries( |
| 102 | + route_deps: RouteDeps, |
| 103 | + vfolder_processors: VFolderProcessors, |
| 104 | +) -> list[RouteRegistry]: |
| 105 | + """Register v2 vfolder REST routes with real RBAC.""" |
| 106 | + processors = MagicMock(spec=Processors) |
| 107 | + processors.vfolder = vfolder_processors |
| 108 | + adapter = VFolderAdapter(processors) |
| 109 | + handler = V2VFolderHandler(adapter=adapter) |
| 110 | + v2_reg = RouteRegistry.create("v2", route_deps.cors_options) |
| 111 | + v2_reg.add_subregistry(register_v2_vfolder_routes(handler, route_deps)) |
| 112 | + return [v2_reg] |
| 113 | + |
| 114 | + |
| 115 | +@pytest.fixture() |
| 116 | +async def admin_v2_registry( |
| 117 | + server: ServerInfo, |
| 118 | + admin_user_fixture: UserFixtureData, |
| 119 | +) -> AsyncIterator[V2ClientRegistry]: |
| 120 | + registry = await V2ClientRegistry.create( |
| 121 | + ClientConfig(endpoint=yarl.URL(server.url)), |
| 122 | + HMACAuth( |
| 123 | + access_key=admin_user_fixture.keypair.access_key, |
| 124 | + secret_key=admin_user_fixture.keypair.secret_key, |
| 125 | + ), |
| 126 | + ) |
| 127 | + try: |
| 128 | + yield registry |
| 129 | + finally: |
| 130 | + await registry.close() |
| 131 | + |
| 132 | + |
| 133 | +@pytest.fixture() |
| 134 | +async def user_v2_registry( |
| 135 | + server: ServerInfo, |
| 136 | + regular_user_fixture: UserFixtureData, |
| 137 | +) -> AsyncIterator[V2ClientRegistry]: |
| 138 | + registry = await V2ClientRegistry.create( |
| 139 | + ClientConfig(endpoint=yarl.URL(server.url)), |
| 140 | + HMACAuth( |
| 141 | + access_key=regular_user_fixture.keypair.access_key, |
| 142 | + secret_key=regular_user_fixture.keypair.secret_key, |
| 143 | + ), |
| 144 | + ) |
| 145 | + try: |
| 146 | + yield registry |
| 147 | + finally: |
| 148 | + await registry.close() |
| 149 | + |
| 150 | + |
| 151 | +@pytest.fixture() |
| 152 | +async def project_vfolder( |
| 153 | + db_engine: SAEngine, |
| 154 | + domain_fixture: str, |
| 155 | + group_fixture: uuid.UUID, |
| 156 | + vfolder_host_permission_fixture: None, |
| 157 | +) -> AsyncIterator[ProjectVFolderFixtureData]: |
| 158 | + """Seed a project-owned vfolder row directly in the DB.""" |
| 159 | + unique = secrets.token_hex(4) |
| 160 | + vfolder_id = uuid.uuid4() |
| 161 | + quota_scope_id = QuotaScopeID(scope_type=QuotaScopeType.PROJECT, scope_id=group_fixture) |
| 162 | + async with db_engine.begin() as conn: |
| 163 | + await conn.execute( |
| 164 | + vfolders.insert().values( |
| 165 | + id=vfolder_id, |
| 166 | + name=f"test-proj-vfolder-{unique}", |
| 167 | + host="local", |
| 168 | + domain_name=domain_fixture, |
| 169 | + quota_scope_id=str(quota_scope_id), |
| 170 | + usage_mode=VFolderUsageMode.GENERAL, |
| 171 | + permission=VFolderMountPermission.READ_WRITE, |
| 172 | + ownership_type=VFolderOwnershipType.GROUP, |
| 173 | + user=None, |
| 174 | + group=group_fixture, |
| 175 | + creator="admin-test@test.local", |
| 176 | + status=VFolderOperationStatus.READY, |
| 177 | + cloneable=False, |
| 178 | + ) |
| 179 | + ) |
| 180 | + yield ProjectVFolderFixtureData(id=vfolder_id, project_id=group_fixture) |
| 181 | + async with db_engine.begin() as conn: |
| 182 | + await conn.execute(vfolders.delete().where(vfolders.c.id == vfolder_id)) |
| 183 | + |
| 184 | + |
| 185 | +# -- Tests --------------------------------------------------------------------- |
| 186 | + |
| 187 | + |
| 188 | +class TestPurgeVFolderRBAC: |
| 189 | + """POST /v2/vfolders/{id}/purge -- SingleEntityActionProcessor RBAC.""" |
| 190 | + |
| 191 | + async def test_regular_user_denied( |
| 192 | + self, |
| 193 | + user_v2_registry: V2ClientRegistry, |
| 194 | + project_vfolder: ProjectVFolderFixtureData, |
| 195 | + ) -> None: |
| 196 | + with pytest.raises(PermissionDeniedError): |
| 197 | + await user_v2_registry.vfolder.purge(project_vfolder.id) |
0 commit comments