refactor: rename RouteTargetStatuses.traffic_status to traffic

The dataclass field shares its name with ``RoutingRow.traffic_status``
(the SQL column) and ``RouteBatchUpdaterSpec.traffic_status`` (a writer
field) — both unrelated. Shorten to ``traffic`` so the call site reads
as a target filter axis next to ``lifecycle`` and ``health`` instead of
echoing the column name.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: fregataa

src/ai/backend/manager/data/deployment/types.py

@@ -252,13 +252,13 @@ class DeploymentTargetStatuses:
 class RouteTargetStatuses:
     """Target statuses for route handler filtering (lifecycle x health x traffic).
 
-    ``traffic_status=None`` skips the filter; otherwise the row's
-    ``traffic_status`` must match.
+    ``traffic=None`` skips the filter; otherwise the row's
+    ``traffic_status`` column must match.
     """
 
     lifecycle: list[RouteStatus]
     health: list[RouteHealthStatus]
-    traffic_status: RouteTrafficStatus | None = None
+    traffic: RouteTrafficStatus | None = None
 
 
 @dataclass(frozen=True)

src/ai/backend/manager/repositories/deployment/db_source/db_source.py

@@ -1619,7 +1619,7 @@ async def get_routes_by_statuses(
         self,
         target: RouteTargetStatuses,
     ) -> list[RouteData]:
-        """Routes matching ``(lifecycle, health, traffic_status)``.
+        """Routes matching ``(lifecycle, health, traffic)``.
 
         ``model_definition`` is selected so the resolved
         ``ModelHealthCheck`` (or ``None``) can be attached to each
@@ -1643,8 +1643,8 @@ async def get_routes_by_statuses(
                     RoutingRow.health_status.in_(target.health),
                 )
             )
-            if target.traffic_status is not None:
-                query = query.where(RoutingRow.traffic_status == target.traffic_status)
+            if target.traffic is not None:
+                query = query.where(RoutingRow.traffic_status == target.traffic)
             result = await db_sess.execute(query)
             return [
                 RouteData(

src/ai/backend/manager/repositories/deployment/repository.py

@@ -632,7 +632,7 @@ async def get_routes_by_statuses(
         self,
         target: RouteTargetStatuses,
     ) -> list[RouteData]:
-        """Routes matching ``(lifecycle, health, traffic_status)``."""
+        """Routes matching ``(lifecycle, health, traffic)``."""
         return await self._db_source.get_routes_by_statuses(target)
 
     @deployment_repository_resilience.apply()

src/ai/backend/manager/sokovan/deployment/route/handlers/appproxy_sync.py

@@ -63,7 +63,7 @@ def target_statuses(cls) -> RouteTargetStatuses:
         return RouteTargetStatuses(
             lifecycle=[RouteStatus.RUNNING],
             health=[RouteHealthStatus.HEALTHY, RouteHealthStatus.NOT_CHECKED],
-            traffic_status=RouteTrafficStatus.ACTIVE,
+            traffic=RouteTrafficStatus.ACTIVE,
         )
 
     @classmethod

tests/unit/manager/repositories/deployment/test_deployment_repository.py

@@ -3955,14 +3955,14 @@ async def test_traffic_status_filter(
         deployment_repository: DeploymentRepository,
         populated_routes: dict[str, uuid.UUID],
     ) -> None:
-        """``traffic_status=INACTIVE`` excludes ACTIVE rows; omitting it (``None``)
+        """``traffic=INACTIVE`` excludes ACTIVE rows; omitting it (``None``)
         keeps both ACTIVE and INACTIVE rows in the result set.
         """
         only_inactive = await deployment_repository.get_routes_by_statuses(
             RouteTargetStatuses(
                 lifecycle=[RouteStatus.RUNNING],
                 health=[RouteHealthStatus.HEALTHY],
-                traffic_status=RouteTrafficStatus.INACTIVE,
+                traffic=RouteTrafficStatus.INACTIVE,
             ),
         )
         both = await deployment_repository.get_routes_by_statuses(