fix(BA-6024): relax AddRevisionInput schema to accept a draft (#11585)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: octodog <mu001@lablup.com>

Author: 3 people

changes/11585.fix.md

@@ -0,0 +1 @@
+Make `AddRevisionInput` fields optional except `deployment_id`.

docs/manager/graphql-reference/supergraph.graphql

@@ -151,17 +151,25 @@ type ActiveResourceOverview
 input AddRevisionInput
   @join__type(graph: STRAWBERRY)
 {
-  name: String = null
-
   """
   Added in 26.4.2. DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.
   """
   revisionPresetId: UUID = null
   deploymentId: ID!
-  clusterConfig: ClusterConfigInput!
-  resourceConfig: ResourceConfigInput!
-  image: ImageInput!
-  modelRuntimeConfig: ModelRuntimeConfigInput!
+
+  """Cluster configuration"""
+  clusterConfig: ClusterConfigInput = null
+
+  """Resource configuration"""
+  resourceConfig: ResourceConfigInput = null
+
+  """Container image"""
+  image: ImageInput = null
+
+  """Runtime configuration"""
+  modelRuntimeConfig: ModelRuntimeConfigInput = null
+
+  """Model mount configuration"""
   modelMountConfig: ModelMountConfigInput!
 
   """
@@ -3843,8 +3851,6 @@ Added in 25.19.0. Input for specifying revision configuration within a deploymen
 input CreateRevisionInput
   @join__type(graph: STRAWBERRY)
 {
-  name: String = null
-
   """
   Added in 26.4.2. DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.
   """
@@ -9778,7 +9784,6 @@ input ModelRuntimeConfigInput
   @join__type(graph: STRAWBERRY)
 {
   runtimeVariantId: UUID!
-  inferenceRuntimeConfig: JSON = null
 
   """Environment variables for the service."""
   environ: EnvironmentVariablesInput = null
@@ -14056,10 +14061,10 @@ type Query
   """
   Added in 25.16.0. Get configuration JSON Schemas for all inference runtimes.
   """
-  inferenceRuntimeConfigs: JSON @join__field(graph: STRAWBERRY)
+  inferenceRuntimeConfigs: JSON @join__field(graph: STRAWBERRY) @deprecated(reason: "Deprecated since UNRELEASED. Use the runtime_variant resources instead.")
 
   """Added in 25.16.0. Get JSON Schema for inference runtime configuration"""
-  inferenceRuntimeConfig(name: String!): JSON @join__field(graph: STRAWBERRY)
+  inferenceRuntimeConfig(name: String!): JSON @join__field(graph: STRAWBERRY) @deprecated(reason: "Deprecated since UNRELEASED. Use the runtime_variant resources instead.")
 
   """Added in 25.19.0. Get a specific route by ID."""
   route(id: ID!): Route @join__field(graph: STRAWBERRY)

docs/manager/graphql-reference/v2-schema.graphql

@@ -109,17 +109,25 @@ enum ActivenessStatus {
 
 """Added in 25.19.0. """
 input AddRevisionInput {
-  name: String = null
-
   """
   Added in 26.4.2. DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.
   """
   revisionPresetId: UUID = null
   deploymentId: ID!
-  clusterConfig: ClusterConfigInput!
-  resourceConfig: ResourceConfigInput!
-  image: ImageInput!
-  modelRuntimeConfig: ModelRuntimeConfigInput!
+
+  """Cluster configuration"""
+  clusterConfig: ClusterConfigInput = null
+
+  """Resource configuration"""
+  resourceConfig: ResourceConfigInput = null
+
+  """Container image"""
+  image: ImageInput = null
+
+  """Runtime configuration"""
+  modelRuntimeConfig: ModelRuntimeConfigInput = null
+
+  """Model mount configuration"""
   modelMountConfig: ModelMountConfigInput!
 
   """
@@ -2423,8 +2431,6 @@ input CreateResourcePresetV2Input {
 Added in 25.19.0. Input for specifying revision configuration within a deployment.
 """
 input CreateRevisionInput {
-  name: String = null
-
   """
   Added in 26.4.2. DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.
   """
@@ -6533,7 +6539,6 @@ type ModelRuntimeConfig {
 """Added in 25.19.0. """
 input ModelRuntimeConfigInput {
   runtimeVariantId: UUID!
-  inferenceRuntimeConfig: JSON = null
 
   """Environment variables for the service."""
   environ: EnvironmentVariablesInput = null
@@ -9180,10 +9185,10 @@ type Query {
   """
   Added in 25.16.0. Get configuration JSON Schemas for all inference runtimes.
   """
-  inferenceRuntimeConfigs: JSON
+  inferenceRuntimeConfigs: JSON @deprecated(reason: "Deprecated since UNRELEASED. Use the runtime_variant resources instead.")
 
   """Added in 25.16.0. Get JSON Schema for inference runtime configuration"""
-  inferenceRuntimeConfig(name: String!): JSON
+  inferenceRuntimeConfig(name: String!): JSON @deprecated(reason: "Deprecated since UNRELEASED. Use the runtime_variant resources instead.")
 
   """Added in 25.19.0. Get a specific route by ID."""
   route(id: ID!): Route

src/ai/backend/client/cli/v2/deployment/commands.py

@@ -149,21 +149,21 @@ def create(
     from ai.backend.common.data.model_deployment.types import DeploymentStrategy
     from ai.backend.common.dto.manager.v2.deployment.request import (
         CreateDeploymentInput,
-        CreateRevisionInputDTO,
+        CreateRevisionInput,
         DeploymentStrategyInput,
         ModelDeploymentMetadataInput,
         ModelDeploymentNetworkAccessInput,
     )
     from ai.backend.common.identifier.resource_group import ResourceGroupName
 
-    revision_dto: CreateRevisionInputDTO | None = None
+    revision_dto: CreateRevisionInput | None = None
     if initial_revision is not None:
         if initial_revision.startswith("@"):
             with Path(initial_revision[1:]).open() as f:
                 rev_data = json.load(f)
         else:
             rev_data = json.loads(initial_revision)
-        revision_dto = CreateRevisionInputDTO.model_validate(rev_data)
+        revision_dto = CreateRevisionInput.model_validate(rev_data)
 
     body = CreateDeploymentInput(
         metadata=ModelDeploymentMetadataInput(

src/ai/backend/client/cli/v2/deployment/revision.py

@@ -37,7 +37,7 @@ def add(deployment_id: str, config: str, preset_id: str | None, auto_activate: b
     """Add a new revision to a deployment."""
 
     from ai.backend.common.dto.manager.v2.deployment.request import (
-        AddRevisionGQLInputDTO,
+        AddRevisionInput,
     )
 
     if config.startswith("@"):
@@ -50,7 +50,7 @@ def add(deployment_id: str, config: str, preset_id: str | None, auto_activate: b
     if preset_id is not None:
         data["revision_preset_id"] = preset_id
     data["auto_activate"] = auto_activate
-    body = AddRevisionGQLInputDTO.model_validate(data)
+    body = AddRevisionInput.model_validate(data)
 
     async def _run() -> None:
         registry = await create_v2_registry(load_v2_config())

src/ai/backend/client/v2/domains_v2/deployment.py

@@ -13,7 +13,7 @@
 )
 from ai.backend.common.dto.manager.v2.deployment.request import (
     ActivateRevisionInput,
-    AddRevisionGQLInputDTO,
+    AddRevisionInput,
     AdminSearchDeploymentsInput,
     AdminSearchRevisionsInput,
     BulkDeleteAccessTokensInput,
@@ -169,7 +169,7 @@ async def delete(
     async def add_revision(
         self,
         deployment_id: UUID,
-        body: AddRevisionGQLInputDTO,
+        body: AddRevisionInput,
     ) -> AddRevisionPayload:
         """Add a new model revision to a deployment."""
         return await self._client.typed_request(

src/ai/backend/common/dto/manager/deployment/request.py

@@ -279,7 +279,6 @@ class ExtraVFolderMountInput(BaseRequestModel):
 class RevisionInput(BaseRequestModel):
     """Revision input for creating a new revision."""
 
-    name: str | None = Field(default=None, description="Revision name")
     cluster_config: ClusterConfigInput = Field(description="Cluster configuration")
     resource_config: ResourceConfigInput = Field(description="Resource configuration")
     image: ImageInput = Field(description="Container image")

src/ai/backend/common/dto/manager/v2/deployment/__init__.py

@@ -45,7 +45,6 @@
     ResourceSlotEntryInput,
     ResourceSlotInput,
     RevisionFilter,
-    RevisionInput,
     RevisionOrder,
     RollingUpdateConfigInput,
     RouteFilter,
@@ -211,7 +210,6 @@
     "ResourceSlotEntryInput",
     "ResourceSlotInput",
     "RevisionFilter",
-    "RevisionInput",
     "RevisionOrder",
     "RollingUpdateConfigInput",
     "RouteFilter",

src/ai/backend/common/dto/manager/v2/deployment/request.py

@@ -4,7 +4,6 @@
 
 from __future__ import annotations
 
-from collections.abc import Mapping
 from datetime import datetime
 from decimal import Decimal
 from typing import Any
@@ -61,15 +60,14 @@
     "AccessTokenOrder",
     "ActivateDeploymentInput",
     "ActivateRevisionInput",
-    "AddRevisionGQLInputDTO",
     "AddRevisionInput",
     "AdminSearchDeploymentsInput",
     "AdminSearchRevisionsInput",
     "AutoScalingRuleFilter",
     "AutoScalingRuleOrder",
     "BlueGreenConfigInput",
     "ClusterConfigInput",
-    "CreateRevisionInputDTO",
+    "CreateRevisionInput",
     "CreateAccessTokenInput",
     "CreateAutoScalingRuleInput",
     "CreateDeploymentInput",
@@ -101,7 +99,6 @@
     "ResourceSlotEntryInput",
     "ResourceSlotInput",
     "RevisionFilter",
-    "RevisionInput",
     "RevisionOrder",
     "ReplaceDeploymentOptionsGQLInput",
     "ReplaceDeploymentOptionsInput",
@@ -257,9 +254,6 @@ class ModelRuntimeConfigInput(BaseRequestModel):
             " RuntimeVariant resolver service before invoking internal flows."
         ),
     )
-    inference_runtime_config: dict[str, Any] | None = Field(
-        default=None, description="Framework-specific inference runtime configuration"
-    )
     environ: EnvironmentVariablesInput | None = Field(
         default=None, description="Environment variables for the service"
     )
@@ -295,10 +289,9 @@ class ExtraVFolderMountInput(BaseRequestModel):
     )
 
 
-class CreateRevisionInputDTO(BaseRequestModel):
+class CreateRevisionInput(BaseRequestModel):
     """Input for a deployment revision (nested structure matching GQL CreateRevisionInput)."""
 
-    name: str | None = Field(default=None, description="Revision name")
     revision_preset_id: DeploymentPresetID | None = Field(
         default=None,
         description="DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.",
@@ -330,19 +323,24 @@ class AddRevisionOptions(BaseRequestModel):
     )
 
 
-class AddRevisionGQLInputDTO(BaseRequestModel):
+class AddRevisionInput(BaseRequestModel):
     """Input for adding a revision. Used by both GQL and REST v2 APIs."""
 
-    name: str | None = Field(default=None, description="Revision name")
     revision_preset_id: DeploymentPresetID | None = Field(
         default=None,
         description="DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.",
     )
     deployment_id: UUID = Field(description="Deployment ID")
-    cluster_config: ClusterConfigInput = Field(description="Cluster configuration")
-    resource_config: ResourceConfigInput = Field(description="Resource configuration")
-    image: ImageInput = Field(description="Container image")
-    model_runtime_config: ModelRuntimeConfigInput = Field(description="Runtime configuration")
+    cluster_config: ClusterConfigInput | None = Field(
+        default=None, description="Cluster configuration"
+    )
+    resource_config: ResourceConfigInput | None = Field(
+        default=None, description="Resource configuration"
+    )
+    image: ImageInput | None = Field(default=None, description="Container image")
+    model_runtime_config: ModelRuntimeConfigInput | None = Field(
+        default=None, description="Runtime configuration"
+    )
     model_mount_config: ModelMountConfigInput = Field(description="Model mount configuration")
     model_definition: ModelDefinitionInput | None = Field(
         default=None,
@@ -447,40 +445,6 @@ class DeploymentStrategyInput(BaseRequestModel):
     )
 
 
-class RevisionInput(BaseRequestModel):
-    """Input for a deployment revision."""
-
-    name: str | None = Field(default=None, description="Revision name")
-    revision_preset_id: DeploymentPresetID | None = Field(
-        default=None,
-        description="DeploymentRevisionPreset ID. When specified, preset values are used as defaults and can be overridden by explicitly provided fields.",
-    )
-    image_id: UUID = Field(description="Container image ID")
-    cluster_mode: ClusterMode = Field(description="Cluster mode for the revision")
-    cluster_size: int = Field(default=1, ge=1, description="Number of nodes in the cluster")
-    resource_slots: Mapping[str, Any] = Field(description="Resource slot requirements")
-    resource_opts: Mapping[str, Any] | None = Field(
-        default=None, description="Optional resource options"
-    )
-    runtime_variant_id: RuntimeVariantID = Field(description="Runtime variant ID (UUID)")
-    inference_runtime_config: dict[str, Any] | None = Field(
-        default=None, description="Framework-specific inference runtime configuration"
-    )
-    model_vfolder_id: VFolderUUID = Field(description="Model VFolder ID")
-    model_mount_destination: str = Field(
-        default="/models", description="Mount destination for model vfolder"
-    )
-    model_definition_path: str = Field(description="Path to model definition file")
-    model_definition: ModelDefinitionInput | None = Field(
-        default=None,
-        description="Model definition to override the default values generated by the server",
-    )
-    extra_mounts: list[ExtraVFolderMountInput] | None = Field(
-        default=None, description="Additional vfolder mounts"
-    )
-    environ: Mapping[str, str] | None = Field(default=None, description="Environment variables")
-
-
 class CreateDeploymentInput(BaseRequestModel):
     """Input for creating a deployment."""
 
@@ -492,7 +456,7 @@ class CreateDeploymentInput(BaseRequestModel):
         description="Deployment strategy configuration"
     )
     replica_count: int = Field(ge=0, description="Number of replicas")
-    initial_revision: CreateRevisionInputDTO | None = Field(
+    initial_revision: CreateRevisionInput | None = Field(
         default=None,
         description="Initial revision configuration. If omitted, deployment is created without a revision and must be added later via add_revision.",
     )
@@ -546,13 +510,6 @@ class ScaleDeploymentInput(BaseRequestModel):
     replicas: int = Field(ge=0, description="Target replica count")
 
 
-class AddRevisionInput(BaseRequestModel):
-    """Input for adding a revision to a deployment."""
-
-    deployment_id: UUID = Field(description="Deployment ID")
-    revision: RevisionInput = Field(description="Revision configuration")
-
-
 # ---------------------------------------------------------------------------
 # Filter types
 # ---------------------------------------------------------------------------