Commit 5732246
test(agent): Cover empty allocation and clarify k8s/dummy NUMA skip
Post-review follow-ups on PR #11222:
- Add an `empty_allocation` scenario to `_NUMA_SCENARIOS` so the `cores=[]`
path through `_resolve_node_local_mem` / `generate_docker_args` is locked
in (must not emit `CpusetMems`).
- Document in `kubernetes/intrinsic.py::CPUPlugin.generate_docker_args` why
the NUMA pinning from the Docker backend is not mirrored (k8s drives
node-local memory via the kubelet Topology Manager).
- Document in `dummy/intrinsic.py::CPUPlugin.generate_docker_args` why
dummy intentionally skips the NUMA pinning (never runs real containers).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 5d46d65 commit 5732246
3 files changed
Lines changed: 17 additions & 1 deletion
File tree
- src/ai/backend/agent
- dummy
- kubernetes
- tests/unit/agent
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
140 | 144 | | |
141 | 145 | | |
142 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
195 | 198 | | |
196 | 199 | | |
197 | 200 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
683 | 683 | | |
684 | 684 | | |
685 | 685 | | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
686 | 695 | | |
687 | 696 | | |
688 | 697 | | |
| |||
0 commit comments