Skip to content

Commit 5ea1195

Browse files
committed
fix(BA-5710): restrict slice B to UserPermission-only test changes
Earlier the branch pulled test fixtures that also referenced later slices' renames (SessionMetadata.owner_id, ScheduledSessionData .main_access_key, SessionDataForPull/Start.main_access_key, SessionData.owner_id). Revert those fixtures to main state and re-apply only the UserPermission field renames (user_uuid -> owner_id, access_key -> main_access_key) which are in this slice's scope. Also update the two remaining live readers of UserPermission: - sokovan/scheduler/fair_share/aggregator.py - api/adapters/session.py (kernel_info_to_node) And fix the SessionRow.delegate_ownership caller of KernelRow.delegate_ownership to match the new single-argument signature.
1 parent d88a14b commit 5ea1195

6 files changed

Lines changed: 17 additions & 15 deletions

File tree

src/ai/backend/manager/api/adapters/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,8 +1011,8 @@ def _kernel_info_to_node(info: KernelInfo) -> KernelNode:
10111011
session_type=info.session.session_type.value,
10121012
),
10131013
user_info=KernelUserInfoGQLDTO(
1014-
user_id=info.user_permission.user_uuid,
1015-
access_key=info.user_permission.access_key,
1014+
user_id=info.user_permission.owner_id,
1015+
access_key=info.user_permission.main_access_key,
10161016
domain_name=info.user_permission.domain_name,
10171017
group_id=info.user_permission.group_id,
10181018
),

src/ai/backend/manager/models/session/row.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,7 @@ def delegate_ownership(self, user_uuid: UUID, access_key: AccessKey) -> None:
12881288
self.user_uuid = user_uuid
12891289
self.access_key = access_key
12901290
for kernel_row in self.kernels:
1291-
kernel_row.delegate_ownership(user_uuid, access_key)
1291+
kernel_row.delegate_ownership(user_uuid)
12921292

12931293
@staticmethod
12941294
async def delete_by_user_id(user_uuid: UUID, *, db_session: SASession) -> None:

src/ai/backend/manager/sokovan/scheduler/fair_share/aggregator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ def _generate_slice_specs(
484484
spec = KernelUsageRecordCreatorSpec(
485485
kernel_id=UUID(str(kernel.id)),
486486
session_id=UUID(kernel.session.session_id),
487-
user_uuid=kernel.user_permission.user_uuid,
487+
user_uuid=kernel.user_permission.owner_id,
488488
project_id=kernel.user_permission.group_id,
489489
domain_name=kernel.user_permission.domain_name,
490490
resource_group=scaling_group,

tests/unit/manager/api/compute_sessions/test_handler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def create_session_data(
7070
cluster_size=1,
7171
domain_name="default",
7272
group_id=uuid4(),
73-
owner_id=uuid4(),
73+
user_uuid=uuid4(),
7474
occupying_slots=ResourceSlot({"cpu": Decimal("2.0"), "mem": Decimal("4294967296")}),
7575
requested_slots=ResourceSlot({"cpu": Decimal("4.0"), "mem": Decimal("8589934592")}),
7676
use_host_network=False,
@@ -80,6 +80,7 @@ def create_session_data(
8080
num_queries=0,
8181
creation_id="test-creation-id",
8282
name=name,
83+
access_key=None,
8384
agent_ids=["agent-001"],
8485
images=images or ["cr.backend.ai/stable/python:3.11"],
8586
tag=None,

tests/unit/manager/sokovan/scheduler/handlers/conftest.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ def _create_session(
106106
name=f"session-{sid}",
107107
domain_name="default",
108108
group_id=group_id,
109-
owner_id=user_uuid,
109+
user_uuid=user_uuid,
110+
access_key=access_key,
110111
session_type=session_type,
111112
priority=0,
112113
created_at=now,
@@ -160,7 +161,7 @@ def _create_session(
160161
),
161162
user_permission=UserPermission(
162163
owner_id=user_uuid,
163-
main_access_key=None,
164+
main_access_key=access_key,
164165
domain_name="default",
165166
group_id=group_id,
166167
uid=None,
@@ -261,7 +262,7 @@ def _create_kernel(
261262
),
262263
user_permission=UserPermission(
263264
owner_id=user_uuid,
264-
main_access_key=None,
265+
main_access_key="test-access-key",
265266
domain_name="default",
266267
group_id=group_id,
267268
uid=None,
@@ -544,7 +545,7 @@ def _create(sessions: list[SessionWithKernels]) -> ScheduleResult:
544545
ScheduledSessionData(
545546
session_id=s.session_info.identity.id,
546547
creation_id=s.session_info.identity.creation_id,
547-
main_access_key=AccessKey("test-access-key"),
548+
access_key=AccessKey(s.session_info.metadata.access_key),
548549
reason="scheduled-successfully",
549550
)
550551
for s in sessions
@@ -563,7 +564,7 @@ def _create(sessions: list[SessionWithKernels]) -> SessionsForPullWithImages:
563564
SessionDataForPull(
564565
session_id=s.session_info.identity.id,
565566
creation_id=s.session_info.identity.creation_id,
566-
main_access_key=AccessKey("test-access-key"),
567+
access_key=AccessKey(s.session_info.metadata.access_key),
567568
kernels=[
568569
KernelBindingData(
569570
kernel_id=KernelId(k.id),
@@ -608,7 +609,7 @@ def _create(sessions: list[SessionWithKernels]) -> SessionsForStartWithImages:
608609
SessionDataForStart(
609610
session_id=s.session_info.identity.id,
610611
creation_id=s.session_info.identity.creation_id,
611-
main_access_key=AccessKey("test-access-key"),
612+
access_key=AccessKey(s.session_info.metadata.access_key),
612613
session_type=s.session_info.identity.session_type,
613614
name=s.session_info.identity.name,
614615
cluster_mode=ClusterMode(s.session_info.resource.cluster_mode),
@@ -623,7 +624,7 @@ def _create(sessions: list[SessionWithKernels]) -> SessionsForStartWithImages:
623624
)
624625
for k in s.kernel_infos
625626
],
626-
owner_id=s.session_info.metadata.owner_id,
627+
user_uuid=s.session_info.metadata.user_uuid,
627628
user_email="test@example.com",
628629
user_name="test-user",
629630
environ={},
@@ -659,7 +660,7 @@ def _create(sessions: list[SessionWithKernels]) -> list[TerminatingSessionData]:
659660
return [
660661
TerminatingSessionData(
661662
session_id=s.session_info.identity.id,
662-
main_access_key=AccessKey("test-access-key"),
663+
access_key=AccessKey(s.session_info.metadata.access_key),
663664
creation_id=s.session_info.identity.creation_id,
664665
status=s.session_info.lifecycle.status,
665666
status_info="user-requested",

tests/unit/manager/sokovan/scheduler/terminator/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def _create_terminating_session_data(
137137

138138
return TerminatingSessionData(
139139
session_id=session_id or SessionId(uuid4()),
140-
main_access_key=AccessKey("test-key"),
140+
access_key=AccessKey("test-key"),
141141
creation_id=str(uuid4()),
142142
status=SessionStatus.TERMINATING,
143143
status_info=status_info,
@@ -214,7 +214,7 @@ def _create_kernel_info(
214214
),
215215
user_permission=UserPermission(
216216
owner_id=uuid4(),
217-
main_access_key=None,
217+
main_access_key="test-access-key",
218218
domain_name="default",
219219
group_id=uuid4(),
220220
uid=None,

0 commit comments

Comments
 (0)