Commit 6ffb749
refactor(BA-7353): define the kernel payload beside the events that carry it
Review follow-up. A payload that only ever travels on a kernel event does not need a
package of its own — it belongs with the other kernel event types.
- Drop `common/interchange/` and define the payload in
`events/event_types/kernel/types.py`, next to `KernelLifecycleEventReason`. Revert
`common/AGENTS.md` and `common/KNOWLEDGE.md`, which only described that package.
- Give each level of the occupancy its own model with a mapping field rather than
nesting three dicts inline: `KernelOccupancy.devices` (by `DeviceName`) →
`DeviceOccupancy.slots` (by `ResourceSlotName`) → `SlotOccupancy.amounts` (by
`DeviceId`). A device supplies more than one slot when it is metered along more than
one axis, as `cuda` does with `cuda.device` and `cuda.shares`.
- Name it after what the manager does with it. It records the value as the kernel's
occupancy, so the field is `occupancy` and the per-slot sum is `slot_totals`.
- Key slots by `ResourceSlotName` throughout, not the legacy `SlotName`.
`slot_totals` stays a property rather than a `computed_field`: a computed field is
written into the payload beside the occupancy it is derived from, where nothing reads it
— a receiver recomputes it — and it can disagree with the value next to it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent fefbdf6 commit 6ffb749
10 files changed
Lines changed: 255 additions & 282 deletions
File tree
- src/ai/backend/common
- events/event_types/kernel
- interchange
- tests/unit/common
- events
- interchange
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
3 | 16 | | |
4 | 17 | | |
5 | 18 | | |
| |||
43 | 56 | | |
44 | 57 | | |
45 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
This file was deleted.
This file was deleted.
Whitespace-only changes.
This file was deleted.
0 commit comments