refactor(BA-5982): drop list_active_deployments action; reuse search_deployments

Adding a dedicated read-side action for the bulk-refresh pre-fetch was
unnecessary — ``SearchDeploymentsAction`` already returns
``ModelDeploymentData`` with ``revision`` populated to the current
revision (via ``_convert_deployment_info_to_data``). Reuse it directly:

- Delete ``actions/list_active_deployments_with_current_revision.py``
  and the matching service method, processor, and spec entry.
- ``DeploymentRevisionAdapter.admin_refresh_deployment_revisions`` now
  builds a ``BatchQuerier`` with
  ``DeploymentConditions.by_lifecycle_stages(EndpointLifecycle.active_states())``,
  calls ``processor.search_deployments``, and iterates the resulting
  ``ModelDeploymentData`` list — skipping entries whose ``revision``
  is ``None`` (deployments that only have a deploying revision and no
  current one to project from).

Conversion still happens entirely in the adapter; ``creators_by_id``
is then handed to the existing batch ``RefreshDeploymentRevisionsAction``.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: jopemachine

src/ai/backend/manager/api/adapters/deployment_revision/adapter.py

@@ -9,6 +9,7 @@
 
 from __future__ import annotations
 
+from ai.backend.common.data.endpoint.types import EndpointLifecycle
 from ai.backend.common.dto.manager.v2.deployment.response import (
     AdminRefreshDeploymentRevisionsPayload,
     RevisionRefreshResultInfo,
@@ -25,12 +26,14 @@
     ResourceSpec,
 )
 from ai.backend.manager.errors.api import InvalidAPIParameters
-from ai.backend.manager.services.deployment.actions.list_active_deployments_with_current_revision import (
-    ListActiveDeploymentsWithCurrentRevisionAction,
-)
+from ai.backend.manager.models.endpoint.conditions import DeploymentConditions
+from ai.backend.manager.repositories.base import BatchQuerier, NoPagination
 from ai.backend.manager.services.deployment.actions.refresh_deployment_revisions import (
     RefreshDeploymentRevisionsAction,
 )
+from ai.backend.manager.services.deployment.actions.search_deployments import (
+    SearchDeploymentsAction,
+)
 
 
 class DeploymentRevisionAdapter(BaseAdapter):
@@ -45,21 +48,31 @@ async def admin_refresh_deployment_revisions(
     ) -> AdminRefreshDeploymentRevisionsPayload:
         """Create and activate a fresh revision for every active deployment.
 
-        Two-phase orchestration: a read-side action returns the current
-        ``ModelRevisionData`` for every active deployment, this adapter
-        projects each onto a ``ModelRevisionCreator`` (failures here
-        surface per-item without aborting the whole sweep), and the batch
-        refresh action processes the resulting ``creators_by_id`` map in a
-        single service call.
+        Two-phase orchestration: ``search_deployments`` returns the active
+        deployments along with each one's current ``ModelRevisionData``;
+        this adapter projects each onto a ``ModelRevisionCreator``
+        (per-item conversion failures surface in the response without
+        aborting the sweep), and the batch refresh action processes the
+        resulting ``creators_by_id`` map in a single service call.
         """
-        list_result = await self._processors.deployment.list_active_deployments_with_current_revision.wait_for_complete(
-            ListActiveDeploymentsWithCurrentRevisionAction()
+        active_querier = BatchQuerier(
+            pagination=NoPagination(),
+            conditions=[
+                DeploymentConditions.by_lifecycle_stages(EndpointLifecycle.active_states()),
+            ],
+        )
+        search_result = await self._processors.deployment.search_deployments.wait_for_complete(
+            SearchDeploymentsAction(querier=active_querier)
         )
         creators_by_id: dict[DeploymentID, ModelRevisionCreator] = {}
         conversion_failures: list[RevisionRefreshResultInfo] = []
-        for revision in list_result.revisions:
+        for deployment in search_result.data:
+            if deployment.revision is None:
+                # No current revision (e.g., still PENDING with only a
+                # deploying revision) — nothing to refresh from.
+                continue
             try:
-                creators_by_id[revision.deployment_id] = self._creator_from_data(revision)
+                creators_by_id[deployment.id] = self._creator_from_data(deployment.revision)
             except InvalidAPIParameters as exc:
                 # Conversion failed (e.g., revision missing the model
                 # vfolder after a SET-NULL FK cleanup). Surface it as a
@@ -68,7 +81,7 @@ async def admin_refresh_deployment_revisions(
                 # to provide via try/except.
                 conversion_failures.append(
                     RevisionRefreshResultInfo(
-                        deployment_id=revision.deployment_id,
+                        deployment_id=deployment.id,
                         new_revision_id=None,
                         success=False,
                         failure_reason=f"{type(exc).__name__}: {exc}",

src/ai/backend/manager/services/deployment/actions/list_active_deployments_with_current_revision.py

@@ -82,10 +82,6 @@
     GetReplicaByIdAction,
     GetReplicaByIdActionResult,
 )
-from ai.backend.manager.services.deployment.actions.list_active_deployments_with_current_revision import (
-    ListActiveDeploymentsWithCurrentRevisionAction,
-    ListActiveDeploymentsWithCurrentRevisionActionResult,
-)
 from ai.backend.manager.services.deployment.actions.model_revision.add_model_revision import (
     AddModelRevisionAction,
     AddModelRevisionActionResult,
@@ -187,10 +183,6 @@ class DeploymentProcessors(AbstractProcessorPackage):
         SearchRevisionResourceSlotsAction, SearchRevisionResourceSlotsActionResult
     ]
     activate_revision: ActionProcessor[ActivateRevisionAction, ActivateRevisionActionResult]
-    list_active_deployments_with_current_revision: ActionProcessor[
-        ListActiveDeploymentsWithCurrentRevisionAction,
-        ListActiveDeploymentsWithCurrentRevisionActionResult,
-    ]
     refresh_deployment_revisions: ActionProcessor[
         RefreshDeploymentRevisionsAction, RefreshDeploymentRevisionsActionResult
     ]
@@ -281,9 +273,6 @@ def __init__(
             service.search_revision_resource_slots, action_monitors
         )
         self.activate_revision = ActionProcessor(service.activate_revision, action_monitors)
-        self.list_active_deployments_with_current_revision = ActionProcessor(
-            service.list_active_deployments_with_current_revision, action_monitors
-        )
         self.refresh_deployment_revisions = ActionProcessor(
             service.refresh_deployment_revisions, action_monitors
         )
@@ -347,7 +336,6 @@ def supported_actions(self) -> list[ActionSpec]:
             SearchRevisionsAction.spec(),
             SearchRevisionResourceSlotsAction.spec(),
             ActivateRevisionAction.spec(),
-            ListActiveDeploymentsWithCurrentRevisionAction.spec(),
             RefreshDeploymentRevisionsAction.spec(),
             # Route operations
             SyncReplicaAction.spec(),

src/ai/backend/manager/services/deployment/processors.py

@@ -41,8 +41,6 @@
     DeploymentPolicyRow,
 )
 from ai.backend.manager.models.endpoint import EndpointTokenRow
-from ai.backend.manager.models.endpoint.conditions import DeploymentConditions
-from ai.backend.manager.repositories.base import BatchQuerier, NoPagination
 from ai.backend.manager.repositories.base.rbac.entity_creator import RBACEntityCreator
 from ai.backend.manager.repositories.base.upserter import Upserter
 from ai.backend.manager.repositories.deployment import DeploymentRepository
@@ -129,10 +127,6 @@
     GetReplicaByIdAction,
     GetReplicaByIdActionResult,
 )
-from ai.backend.manager.services.deployment.actions.list_active_deployments_with_current_revision import (
-    ListActiveDeploymentsWithCurrentRevisionAction,
-    ListActiveDeploymentsWithCurrentRevisionActionResult,
-)
 from ai.backend.manager.services.deployment.actions.model_revision.add_model_revision import (
     AddModelRevisionAction,
     AddModelRevisionActionResult,
@@ -612,46 +606,6 @@ async def activate_revision(
             deployment_policy=result.deployment_policy,
         )
 
-    async def list_active_deployments_with_current_revision(
-        self,
-        action: ListActiveDeploymentsWithCurrentRevisionAction,
-    ) -> ListActiveDeploymentsWithCurrentRevisionActionResult:
-        """List active deployments paired with their current revision data.
-
-        Backs the admin bulk revision refresh: the adapter consumes this
-        list, projects each ``ModelRevisionData`` onto a
-        ``ModelRevisionCreator``, then invokes
-        ``refresh_deployment_revisions`` once with the prepared map. All
-        type conversions stay in the adapter; the service only orchestrates
-        the read pass.
-        """
-        # Bulk scan + per-id read: two-phase fetch is required to preserve
-        # partial-success semantics in the adapter (a single missing
-        # revision must not abort the entire refresh).
-        active_querier = BatchQuerier(
-            pagination=NoPagination(),
-            conditions=[
-                DeploymentConditions.by_lifecycle_stages(EndpointLifecycle.active_states()),
-            ],
-        )
-        deployment_ids = await self._deployment_repository.search_deployment_ids(
-            querier=active_querier,
-        )
-        revisions: list[ModelRevisionData] = []
-        for deployment_id in deployment_ids:
-            try:
-                revision = await self._deployment_repository.get_current_revision(deployment_id)
-            except Exception as exc:
-                log.warning(
-                    "list_active_deployments_with_current_revision: skipping {}: {}: {}",
-                    deployment_id,
-                    type(exc).__name__,
-                    exc,
-                )
-                continue
-            revisions.append(revision)
-        return ListActiveDeploymentsWithCurrentRevisionActionResult(revisions=revisions)
-
     async def refresh_deployment_revisions(
         self,
         action: RefreshDeploymentRevisionsAction,