Commit ab4ce5f
committed
fix(BA-5829): break AppConfig <-> AppConfigFragment GQL import cycle
`app_config/types/node.py` imports `AppConfigFragmentGQL` (AppConfig's
`fragments` field), which loads `app_config_fragment/__init__.py`.
That used to eagerly re-export the mutation resolvers, which then
imported back from `app_config.types.bulk_payloads` -> `node` (still
mid-load) -> ImportError.
Three small surgeries break the cycle:
- `app_config_fragment/__init__.py` no longer re-exports its resolver
symbols; `schema.py` now imports them straight from the resolver
submodules.
- `app_config/types/__init__.py` no longer re-exports the My-bulk
payload GQL types, so loading the package no longer drags in
`bulk_payloads.py` before `node.py` finishes.
- `mutation.py` imports the My-bulk payload types from the
`bulk_payloads` submodule directly.
`tests/component/user/test_keypair_ops.py` collection (and the
`api-updated` schema-dump step) used to fail because of this cycle.1 parent c7b65a7 commit ab4ce5f
4 files changed
Lines changed: 14 additions & 47 deletions
File tree
- src/ai/backend/manager/api/gql
- app_config_fragment
- resolver
- app_config/types
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | 1 | | |
6 | 2 | | |
7 | 3 | | |
| |||
14 | 10 | | |
15 | 11 | | |
16 | 12 | | |
17 | | - | |
18 | | - | |
19 | 13 | | |
Lines changed: 8 additions & 37 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
28 | | - | |
29 | 27 | | |
30 | 28 | | |
31 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments