refactor(BA-5040): Remove unused domain_name field and require user_uuid in scope actions

Remove dead domain_name field from SearchImagesAction and
GetAllImagesAction. Make user_uuid required (no default) and
update all callers to provide it explicitly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: fregataa

src/ai/backend/manager/api/gql/data_loader/image/loader.py

@@ -2,6 +2,7 @@
 
 from collections.abc import Sequence
 
+from ai.backend.common.contexts.user import current_user
 from ai.backend.common.types import ImageID
 from ai.backend.manager.data.image.types import ImageData
 from ai.backend.manager.repositories.base import BatchQuerier, NoPagination
@@ -31,8 +32,9 @@ async def load_images_by_ids(
         conditions=[ImageConditions.by_ids(image_ids)],
     )
 
+    user = current_user()
     action_result = await processor.search_images.wait_for_complete(
-        SearchImagesAction(querier=querier)
+        SearchImagesAction(querier=querier, user_uuid=str(user.user_id) if user else "")
     )
 
     image_map: dict[ImageID, ImageData] = {ImageID(image.id): image for image in action_result.data}

src/ai/backend/manager/api/gql/image/fetcher.py

@@ -12,6 +12,7 @@
 import strawberry
 from strawberry import Info
 
+from ai.backend.common.contexts.user import current_user
 from ai.backend.common.types import ImageID
 from ai.backend.manager.api.gql.adapter import PaginationOptions, PaginationSpec
 from ai.backend.manager.api.gql.base import encode_cursor
@@ -84,8 +85,9 @@ async def fetch_images(
         base_conditions=base_conditions,
     )
 
+    user = current_user()
     action_result = await info.context.processors.image.search_images.wait_for_complete(
-        SearchImagesAction(querier=querier)
+        SearchImagesAction(querier=querier, user_uuid=str(user.user_id) if user else "")
     )
 
     edges = []

src/ai/backend/manager/api/gql_legacy/image.py

@@ -311,7 +311,6 @@ async def load_all(
             GetAllImagesAction(
                 status_filter=filter_by_statuses,
                 user_uuid=str(ctx.user["uuid"]),
-                domain_name=ctx.user["domain_name"],
             )
         )
         all_items = [cls.from_image_with_agent_install_status(img) for img in result.data.values()]

src/ai/backend/manager/api/rest/image/handler.py

@@ -59,7 +59,6 @@ async def search(
             SearchImagesAction(
                 querier=querier,
                 user_uuid=str(ctx.user_uuid),
-                domain_name=ctx.user_domain,
             )
         )
         resp = SearchImagesResponse(

src/ai/backend/manager/services/image/actions/get_all_images.py

@@ -23,8 +23,7 @@ class GetAllImagesAction(ImageScopeAction):
     """
 
     status_filter: list[ImageStatus] | None
-    user_uuid: str = ""
-    domain_name: str = ""
+    user_uuid: str
 
     @override
     @classmethod

src/ai/backend/manager/services/image/actions/search_images.py

@@ -14,8 +14,7 @@
 @dataclass
 class SearchImagesAction(ImageScopeAction):
     querier: BatchQuerier
-    user_uuid: str = ""
-    domain_name: str = ""
+    user_uuid: str
 
     @override
     @classmethod

tests/unit/manager/api/image/test_handler.py

@@ -428,7 +428,7 @@ async def test_search_images_calls_processor(
     ) -> None:
         """Search handler should call search_images processor."""
         await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock())
+            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
         )
         mock_processors.image.search_images.wait_for_complete.assert_called_once()
 
@@ -438,7 +438,7 @@ async def test_search_images_returns_correct_count(
     ) -> None:
         """Search result should have correct total count."""
         result = await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock())
+            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
         )
         assert result.total_count == 2
         assert len(result.data) == 2
@@ -449,7 +449,7 @@ async def test_search_images_converts_to_dto(
     ) -> None:
         """Search result data should be convertible to DTOs."""
         result = await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock())
+            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
         )
         adapter = ImageAdapter()
         items = [adapter.convert_to_dto(img) for img in result.data]
@@ -591,7 +591,7 @@ async def test_search_empty_result(self) -> None:
         processors.image.search_images.wait_for_complete = AsyncMock(return_value=result)
 
         search_result = await processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock())
+            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
         )
         assert search_result.data == []
         assert search_result.total_count == 0

tests/unit/manager/services/image/test_image_service.py

@@ -903,7 +903,7 @@ async def test_search_images_success(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier)
+        action = SearchImagesAction(querier=querier, user_uuid="test-user")
 
         result = await processors.search_images.wait_for_complete(action)
 
@@ -933,7 +933,7 @@ async def test_search_images_empty_result(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier)
+        action = SearchImagesAction(querier=querier, user_uuid="test-user")
 
         result = await processors.search_images.wait_for_complete(action)
 
@@ -961,7 +961,7 @@ async def test_search_images_with_pagination(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier)
+        action = SearchImagesAction(querier=querier, user_uuid="test-user")
 
         result = await processors.search_images.wait_for_complete(action)