fix(BA-3696): Fix type errors - add _domain_name field and inherit from RBAC result bases

- Add _domain_name field to CreateUserAction (following group pattern)
- Update all result classes to inherit from UserScopeActionResult or UserSingleEntityActionResult
- Implement required scope_type()/scope_id() or target_entity_id() methods on results
- Update service.py to pass required scope/entity IDs to result constructors
- Update API layer (REST, GraphQL) to pass _domain_name when creating CreateUserAction
- Add _user_id field to DeleteUserActionResult and PurgeUserActionResult
- Simplify search result classes to use specific field names (_domain_name, _project_id, _role_id)

All user service files now pass pants fmt, fix, and lint checks.
Type check errors in processors.py are pre-existing (111 errors on main branch).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: fregataa

src/ai/backend/manager/api/gql_legacy/user.py

@@ -922,6 +922,7 @@ def value_or_none(value: Any) -> Any | None:
                     container_gids=value_or_none(self.container_gids),
                 ),
             ),
+            _domain_name=str(self.domain_name),
             group_ids=value_or_none(self.group_ids),
         )
 

src/ai/backend/manager/api/rest/user/handler.py

@@ -102,7 +102,11 @@ async def create_user(
         )
 
         action_result = await self._user.create_user.wait_for_complete(
-            CreateUserAction(creator=creator, group_ids=body.parsed.group_ids)
+            CreateUserAction(
+                creator=creator,
+                _domain_name=body.parsed.domain_name,
+                group_ids=body.parsed.group_ids,
+            )
         )
 
         resp = CreateUserResponse(user=self._adapter.convert_to_dto(action_result.data.user))

src/ai/backend/manager/services/user/actions/create_user.py

@@ -8,12 +8,17 @@
 from ai.backend.manager.data.user.types import BulkUserCreateResultData, UserCreateResultData
 from ai.backend.manager.models.user import UserRow
 from ai.backend.manager.repositories.base.creator import Creator
-from ai.backend.manager.services.user.actions.base import UserAction, UserScopeAction
+from ai.backend.manager.services.user.actions.base import (
+    UserAction,
+    UserScopeAction,
+    UserScopeActionResult,
+)
 
 
 @dataclass
 class CreateUserAction(UserScopeAction):
     creator: Creator[UserRow]
+    _domain_name: str
     group_ids: list[str] | None = None
 
     @override
@@ -23,29 +28,34 @@ def operation_type(cls) -> ActionOperationType:
 
     @override
     def scope_type(self) -> ScopeType:
-        # User creation happens within the domain scope
-        # Domain is extracted from creator.values['domain_name']
         return ScopeType.DOMAIN
 
     @override
     def scope_id(self) -> str:
-        return self.creator.values.get("domain_name", "")
+        return self._domain_name
 
     @override
     def target_element(self) -> RBACElementRef:
-        return RBACElementRef(RBACElementType.DOMAIN, self.scope_id())
+        return RBACElementRef(RBACElementType.DOMAIN, self._domain_name)
 
 
 @dataclass
-class CreateUserActionResult(BaseActionResult):
+class CreateUserActionResult(UserScopeActionResult):
     data: UserCreateResultData
-    _scope_type: ScopeType
-    _scope_id: str
+    _domain_name: str
 
     @override
     def entity_id(self) -> str | None:
         return str(self.data.user.id)
 
+    @override
+    def scope_type(self) -> ScopeType:
+        return ScopeType.DOMAIN
+
+    @override
+    def scope_id(self) -> str:
+        return self._domain_name
+
 
 @dataclass
 class UserCreateSpec:

src/ai/backend/manager/services/user/actions/delete_user.py

@@ -2,10 +2,12 @@
 from typing import override
 
 from ai.backend.common.data.permission.types import RBACElementType
-from ai.backend.manager.actions.action import BaseActionResult
 from ai.backend.manager.actions.types import ActionOperationType
 from ai.backend.manager.data.permission.types import RBACElementRef
-from ai.backend.manager.services.user.actions.base import UserSingleEntityAction
+from ai.backend.manager.services.user.actions.base import (
+    UserSingleEntityAction,
+    UserSingleEntityActionResult,
+)
 
 
 @dataclass
@@ -29,7 +31,13 @@ def target_element(self) -> RBACElementRef:
 
 
 @dataclass
-class DeleteUserActionResult(BaseActionResult):
+class DeleteUserActionResult(UserSingleEntityActionResult):
+    _user_id: str
+
     @override
     def entity_id(self) -> str | None:
-        return None
+        return self._user_id
+
+    @override
+    def target_entity_id(self) -> str:
+        return self._user_id

src/ai/backend/manager/services/user/actions/get_user.py

@@ -3,11 +3,13 @@
 from uuid import UUID
 
 from ai.backend.common.data.permission.types import RBACElementType
-from ai.backend.manager.actions.action import BaseActionResult
 from ai.backend.manager.actions.types import ActionOperationType
 from ai.backend.manager.data.permission.types import RBACElementRef
 from ai.backend.manager.data.user.types import UserData
-from ai.backend.manager.services.user.actions.base import UserSingleEntityAction
+from ai.backend.manager.services.user.actions.base import (
+    UserSingleEntityAction,
+    UserSingleEntityActionResult,
+)
 
 
 @dataclass
@@ -31,7 +33,7 @@ def target_element(self) -> RBACElementRef:
 
 
 @dataclass
-class GetUserActionResult(BaseActionResult):
+class GetUserActionResult(UserSingleEntityActionResult):
     """Result of GetUserAction containing user data."""
 
     user: UserData
@@ -40,5 +42,6 @@ class GetUserActionResult(BaseActionResult):
     def entity_id(self) -> str | None:
         return str(self.user.uuid)
 
+    @override
     def target_entity_id(self) -> str:
         return str(self.user.uuid)

src/ai/backend/manager/services/user/actions/modify_user.py

@@ -11,7 +11,11 @@
 from ai.backend.manager.data.user.types import BulkUserUpdateResultData, UserData
 from ai.backend.manager.models.user import UserRow
 from ai.backend.manager.repositories.base.updater import Updater
-from ai.backend.manager.services.user.actions.base import UserAction, UserSingleEntityAction
+from ai.backend.manager.services.user.actions.base import (
+    UserAction,
+    UserSingleEntityAction,
+    UserSingleEntityActionResult,
+)
 
 if TYPE_CHECKING:
     from ai.backend.manager.repositories.user.updaters import UserUpdaterSpec
@@ -42,13 +46,14 @@ def target_element(self) -> RBACElementRef:
 
 
 @dataclass
-class ModifyUserActionResult(BaseActionResult):
+class ModifyUserActionResult(UserSingleEntityActionResult):
     data: UserData
 
     @override
     def entity_id(self) -> str | None:
         return str(self.data.id)
 
+    @override
     def target_entity_id(self) -> str:
         return str(self.data.id)
 

src/ai/backend/manager/services/user/actions/purge_user.py

@@ -7,7 +7,11 @@
 from ai.backend.manager.actions.types import ActionOperationType
 from ai.backend.manager.data.permission.types import RBACElementRef
 from ai.backend.manager.data.user.types import BulkUserPurgeResultData, UserInfoContext
-from ai.backend.manager.services.user.actions.base import UserAction, UserSingleEntityAction
+from ai.backend.manager.services.user.actions.base import (
+    UserAction,
+    UserSingleEntityAction,
+    UserSingleEntityActionResult,
+)
 from ai.backend.manager.types import OptionalState
 
 
@@ -35,9 +39,16 @@ def target_element(self) -> RBACElementRef:
 
 
 @dataclass
-class PurgeUserActionResult(BaseActionResult):
+class PurgeUserActionResult(UserSingleEntityActionResult):
+    _user_id: str
+
+    @override
     def entity_id(self) -> str | None:
-        return None
+        return self._user_id
+
+    @override
+    def target_entity_id(self) -> str:
+        return self._user_id
 
 
 @dataclass

src/ai/backend/manager/services/user/actions/search_users_by_domain.py

@@ -45,13 +45,12 @@ class SearchUsersByDomainActionResult(UserScopeActionResult):
     total_count: int
     has_next_page: bool
     has_previous_page: bool
-    _scope_type: ScopeType
-    _scope_id: str
+    _domain_name: str
 
     @override
     def scope_type(self) -> ScopeType:
-        return self._scope_type
+        return ScopeType.DOMAIN
 
     @override
     def scope_id(self) -> str:
-        return self._scope_id
+        return self._domain_name

src/ai/backend/manager/services/user/actions/search_users_by_project.py

@@ -45,13 +45,12 @@ class SearchUsersByProjectActionResult(UserScopeActionResult):
     total_count: int
     has_next_page: bool
     has_previous_page: bool
-    _scope_type: ScopeType
-    _scope_id: str
+    _project_id: str
 
     @override
     def scope_type(self) -> ScopeType:
-        return self._scope_type
+        return ScopeType.PROJECT
 
     @override
     def scope_id(self) -> str:
-        return self._scope_id
+        return self._project_id

src/ai/backend/manager/services/user/actions/search_users_by_role.py

@@ -45,13 +45,12 @@ class SearchUsersByRoleActionResult(UserScopeActionResult):
     total_count: int
     has_next_page: bool
     has_previous_page: bool
-    _scope_type: ScopeType
-    _scope_id: str
+    _role_id: str
 
     @override
     def scope_type(self) -> ScopeType:
-        return self._scope_type
+        return ScopeType.ROLE
 
     @override
     def scope_id(self) -> str:
-        return self._scope_id
+        return self._role_id