fix(test): use real ActionValidators instance in notification processor fixtures

Replace MagicMock(spec=ActionValidators) with ActionValidators(rbac=RBACValidators(...))
in notification processor test fixtures, matching the pattern already used in session
and vfolder processor fixtures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: fregataa

tests/component/notification/conftest.py

@@ -1,10 +1,11 @@
 from __future__ import annotations
 
-from unittest.mock import AsyncMock, MagicMock
+from unittest.mock import AsyncMock
 
 import pytest
 
 from ai.backend.manager.actions.validators import ActionValidators
+from ai.backend.manager.actions.validators.rbac import RBACValidators
 from ai.backend.manager.api.rest.notification.handler import NotificationHandler
 from ai.backend.manager.api.rest.notification.registry import register_notification_routes
 from ai.backend.manager.api.rest.routing import RouteRegistry
@@ -23,13 +24,13 @@ def notification_processors(
 ) -> NotificationProcessors:
     repo = NotificationRepository(database_engine)
     service = NotificationService(repo, notification_center)
-    # Create properly structured ActionValidators mock with async validators
-    validators = MagicMock(spec=ActionValidators)
-    validators.rbac = MagicMock()
-    validators.rbac.scope = AsyncMock()
-    validators.rbac.single_entity = AsyncMock()
-    return NotificationProcessors(service=service, action_monitors=[], validators=validators)
-
+    return NotificationProcessors(
+        service=service,
+        action_monitors=[],
+        validators=ActionValidators(
+            rbac=RBACValidators(scope=AsyncMock(), single_entity=AsyncMock())
+        ),
+    )
 
 @pytest.fixture()
 def server_module_registries(

tests/unit/manager/services/notification/test_notification_processing.py

@@ -22,6 +22,7 @@
     WebhookSpec,
 )
 from ai.backend.manager.actions.validators import ActionValidators
+from ai.backend.manager.actions.validators.rbac import RBACValidators
 from ai.backend.manager.data.notification import (
     NotificationChannelData,
     NotificationRuleData,
@@ -55,12 +56,13 @@ def notification_processors(
     notification_center: NotificationCenter,
 ) -> NotificationProcessors:
     service = NotificationService(mock_repository, notification_center)
-    # Create properly structured ActionValidators mock with async validators
-    validators = MagicMock(spec=ActionValidators)
-    validators.rbac = MagicMock()
-    validators.rbac.scope = AsyncMock()
-    validators.rbac.single_entity = AsyncMock()
-    return NotificationProcessors(service=service, action_monitors=[], validators=validators)
+    return NotificationProcessors(
+        service=service,
+        action_monitors=[],
+        validators=ActionValidators(
+            rbac=RBACValidators(scope=AsyncMock(), single_entity=AsyncMock())
+        ),
+    )
 
 
 @pytest.fixture()