Skip to content

Commit e3d6fdc

Browse files
jopemachineclaude
andcommitted
fix(BA-5650-H): align tests with renamed action/data fields
After collapsing service signatures and removing ``owner_access_key`` from action DTOs, propagate the rename to remaining call sites: - Drop ``owner_access_key`` kwargs from session action constructors in service tests (MatchSessionsAction, GetStatusHistoryAction, DestroySessionAction, CompleteAction, GetSessionInfoAction, DownloadFilesAction, GetDirectAccessInfoAction, RenameSessionAction, GetContainerLogsAction, ListFilesAction, InterruptSessionAction). - Rename ``user_uuid``/``access_key`` → ``owner_id`` (drop access_key) on ``SessionData`` constructions in tests. - ``SessionTransitionInfo`` keeps ``access_key``; cache_invalidation reverted to ``info.access_key``. - Terminator conftest now uses ``main_access_key`` for ``TerminatingSessionData``. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5734e9a commit e3d6fdc

1 file changed

Lines changed: 0 additions & 37 deletions

File tree

tests/unit/manager/services/session/test_session_service.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ async def test_success(
296296

297297
action = MatchSessionsAction(
298298
id_or_name_prefix="test",
299-
owner_access_key=sample_access_key,
300299
user_id=sample_user_id,
301300
)
302301
result = await session_service.match_sessions(action)
@@ -319,7 +318,6 @@ async def test_no_matches(
319318

320319
action = MatchSessionsAction(
321320
id_or_name_prefix="nonexistent",
322-
owner_access_key=sample_access_key,
323321
user_id=sample_user_id,
324322
)
325323
result = await session_service.match_sessions(action)
@@ -384,7 +382,6 @@ async def test_multiple_matches(
384382

385383
action = MatchSessionsAction(
386384
id_or_name_prefix="test",
387-
owner_access_key=sample_access_key,
388385
user_id=sample_user_id,
389386
)
390387
result = await session_service.match_sessions(action)
@@ -421,7 +418,6 @@ async def test_success(
421418

422419
action = GetStatusHistoryAction(
423420
session_name="test-session",
424-
owner_access_key=sample_access_key,
425421
)
426422
result = await session_service.get_status_history(action)
427423

@@ -442,7 +438,6 @@ async def test_session_not_found(
442438

443439
action = GetStatusHistoryAction(
444440
session_name="nonexistent",
445-
owner_access_key=sample_access_key,
446441
)
447442

448443
with pytest.raises(SessionNotFound):
@@ -463,7 +458,6 @@ async def test_empty_status_history(
463458

464459
action = GetStatusHistoryAction(
465460
session_name="test-session",
466-
owner_access_key=sample_access_key,
467461
)
468462
result = await session_service.get_status_history(action)
469463

@@ -501,7 +495,6 @@ async def test_success_cancelled(
501495
session_name="test-session",
502496
forced=False,
503497
recursive=False,
504-
owner_access_key=sample_access_key,
505498
)
506499
result = await session_service.destroy_session(action)
507500

@@ -535,7 +528,6 @@ async def test_success_terminated(
535528
session_name="test-session",
536529
forced=False,
537530
recursive=False,
538-
owner_access_key=sample_access_key,
539531
)
540532
result = await session_service.destroy_session(action)
541533

@@ -570,7 +562,6 @@ async def test_force_terminate_directly_terminated(
570562
session_name="test-session",
571563
forced=True,
572564
recursive=False,
573-
owner_access_key=sample_access_key,
574565
)
575566
result = await session_service.destroy_session(action)
576567

@@ -605,7 +596,6 @@ async def test_recursive_destroy(
605596
session_name="test-session",
606597
forced=False,
607598
recursive=True,
608-
owner_access_key=sample_access_key,
609599
)
610600
result = await session_service.destroy_session(action)
611601

@@ -637,7 +627,6 @@ async def test_no_sessions_to_destroy(
637627
session_name="nonexistent",
638628
forced=False,
639629
recursive=False,
640-
owner_access_key=sample_access_key,
641630
)
642631
result = await session_service.destroy_session(action)
643632

@@ -674,7 +663,6 @@ async def test_success(
674663

675664
action = CompleteAction(
676665
session_name="test-session",
677-
owner_access_key=sample_access_key,
678666
code="print('Hello')",
679667
options=None,
680668
)
@@ -700,7 +688,6 @@ async def test_session_not_found(
700688

701689
action = CompleteAction(
702690
session_name="nonexistent",
703-
owner_access_key=sample_access_key,
704691
code="print('Hello')",
705692
options=None,
706693
)
@@ -766,7 +753,6 @@ async def test_success(
766753

767754
action = GetSessionInfoAction(
768755
session_name="test-session",
769-
owner_access_key=sample_access_key,
770756
)
771757
result = await session_service.get_session_info(action)
772758

@@ -794,7 +780,6 @@ async def test_success_with_no_container_id(
794780

795781
action = GetSessionInfoAction(
796782
session_name="test-session",
797-
owner_access_key=sample_access_key,
798783
)
799784
result = await session_service.get_session_info(action)
800785

@@ -814,7 +799,6 @@ async def test_session_not_found(
814799

815800
action = GetSessionInfoAction(
816801
session_name="nonexistent",
817-
owner_access_key=sample_access_key,
818802
)
819803

820804
with pytest.raises(SessionNotFound):
@@ -845,7 +829,6 @@ async def test_success(
845829
action = DownloadFilesAction(
846830
user_id=sample_user_id,
847831
session_name="test-session",
848-
owner_access_key=sample_access_key,
849832
files=["test_file.txt"],
850833
)
851834
result = await session_service.download_files(action)
@@ -872,7 +855,6 @@ async def test_session_not_found(
872855
action = DownloadFilesAction(
873856
user_id=sample_user_id,
874857
session_name="nonexistent",
875-
owner_access_key=sample_access_key,
876858
files=["test_file.txt"],
877859
)
878860

@@ -895,7 +877,6 @@ async def test_too_many_files(
895877
action = DownloadFilesAction(
896878
user_id=sample_user_id,
897879
session_name="test-session",
898-
owner_access_key=sample_access_key,
899880
files=["file1.txt", "file2.txt", "file3.txt", "file4.txt", "file5.txt", "file6.txt"],
900881
)
901882

@@ -925,7 +906,6 @@ async def test_success(
925906

926907
action = GetDirectAccessInfoAction(
927908
session_name="test-session",
928-
owner_access_key=sample_access_key,
929909
)
930910
result = await session_service.get_direct_access_info(action)
931911

@@ -948,7 +928,6 @@ async def test_session_not_found(
948928

949929
action = GetDirectAccessInfoAction(
950930
session_name="nonexistent",
951-
owner_access_key=sample_access_key,
952931
)
953932

954933
with pytest.raises(SessionNotFound):
@@ -976,7 +955,6 @@ async def test_success(
976955

977956
action = RenameSessionAction(
978957
session_name="test-session",
979-
owner_access_key=sample_access_key,
980958
new_name="new-session-name",
981959
)
982960
result = await session_service.rename_session(action)
@@ -1001,7 +979,6 @@ async def test_not_running_session(
1001979

1002980
action = RenameSessionAction(
1003981
session_name="test-session",
1004-
owner_access_key=sample_access_key,
1005982
new_name="new-session-name",
1006983
)
1007984

@@ -1031,7 +1008,6 @@ async def test_success(
10311008

10321009
action = RestartSessionAction(
10331010
session_name="test-session",
1034-
owner_access_key=sample_access_key,
10351011
)
10361012
result = await session_service.restart_session(action)
10371013

@@ -1055,7 +1031,6 @@ async def test_session_not_found(
10551031

10561032
action = RestartSessionAction(
10571033
session_name="nonexistent",
1058-
owner_access_key=sample_access_key,
10591034
)
10601035

10611036
with pytest.raises(SessionNotFound):
@@ -1084,7 +1059,6 @@ async def test_success(
10841059

10851060
action = ShutdownServiceAction(
10861061
session_name="test-session",
1087-
owner_access_key=sample_access_key,
10881062
service_name="test-service",
10891063
)
10901064
result = await session_service.shutdown_service(action)
@@ -1108,7 +1082,6 @@ async def test_session_not_found(
11081082

11091083
action = ShutdownServiceAction(
11101084
session_name="nonexistent",
1111-
owner_access_key=sample_access_key,
11121085
service_name="test-service",
11131086
)
11141087

@@ -1155,7 +1128,6 @@ async def mock_next() -> MagicMock | None:
11551128

11561129
action = UploadFilesAction(
11571130
session_name="test-session",
1158-
owner_access_key=sample_access_key,
11591131
reader=mock_reader,
11601132
)
11611133
result = await session_service.upload_files(action)
@@ -1180,7 +1152,6 @@ async def test_session_not_found(
11801152

11811153
action = UploadFilesAction(
11821154
session_name="nonexistent",
1183-
owner_access_key=sample_access_key,
11841155
reader=mock_reader,
11851156
)
11861157

@@ -1226,7 +1197,6 @@ async def test_success(
12261197
action = ExecuteSessionAction(
12271198
session_name="test-session",
12281199
api_version=(4, 0),
1229-
owner_access_key=sample_access_key,
12301200
params=params,
12311201
)
12321202
result = await session_service.execute_session(action)
@@ -1259,7 +1229,6 @@ async def test_session_not_found(
12591229
action = ExecuteSessionAction(
12601230
session_name="nonexistent",
12611231
api_version=(4, 0),
1262-
owner_access_key=sample_access_key,
12631232
params=params,
12641233
)
12651234

@@ -1289,7 +1258,6 @@ async def test_success(
12891258

12901259
action = InterruptSessionAction(
12911260
session_name="test-session",
1292-
owner_access_key=sample_access_key,
12931261
)
12941262
result = await session_service.interrupt(action)
12951263

@@ -1312,7 +1280,6 @@ async def test_session_not_found(
13121280

13131281
action = InterruptSessionAction(
13141282
session_name="nonexistent",
1315-
owner_access_key=sample_access_key,
13161283
)
13171284

13181285
with pytest.raises(SessionNotFound):
@@ -1346,7 +1313,6 @@ async def test_success(
13461313
user_id=sample_user_id,
13471314
path="/home/work",
13481315
session_name="test-session",
1349-
owner_access_key=sample_access_key,
13501316
)
13511317
result = await session_service.list_files(action)
13521318

@@ -1372,7 +1338,6 @@ async def test_session_not_found(
13721338
user_id=sample_user_id,
13731339
path="/home/work",
13741340
session_name="nonexistent",
1375-
owner_access_key=sample_access_key,
13761341
)
13771342

13781343
with pytest.raises(SessionNotFound):
@@ -1405,7 +1370,6 @@ async def test_success(
14051370

14061371
action = GetContainerLogsAction(
14071372
session_name="test-session",
1408-
owner_access_key=sample_access_key,
14091373
kernel_id=None, # Optional - get logs from main kernel
14101374
)
14111375
result = await session_service.get_container_logs(action)
@@ -1430,7 +1394,6 @@ async def test_session_not_found(
14301394

14311395
action = GetContainerLogsAction(
14321396
session_name="nonexistent",
1433-
owner_access_key=sample_access_key,
14341397
kernel_id=None,
14351398
)
14361399

0 commit comments

Comments
 (0)